From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3484C433EF for ; Thu, 27 Jan 2022 19:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231310AbiA0TN5 (ORCPT ); Thu, 27 Jan 2022 14:13:57 -0500 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:48856 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbiA0TN4 (ORCPT ); Thu, 27 Jan 2022 14:13:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1643310837; x=1674846837; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mV9Rntd10MU7cdeZ3c0E0Qx20jU1t4bULsvd73nv/E4=; b=LCYx+3t92J6b7hnH/lTshzY5eqNdm9wA6BE27Jp0DpbnM5x0H/so5/eT r9F5pF00jicVnHTgAQOeTCyqjrfNYbLNCIFVeHEcndUS19+sovc1MPVXO Znoru1jL5m1PQPZiPEiqcmM1g/33CkamiU7SaznbEP9/zea3NLo8gItKy c=; X-IronPort-AV: E=Sophos;i="5.88,321,1635206400"; d="scan'208";a="173626860" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 27 Jan 2022 19:13:56 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com (Postfix) with ESMTPS id 9B8DA1A0067; Thu, 27 Jan 2022 19:13:51 +0000 (UTC) Received: from EX13D02UWB002.ant.amazon.com (10.43.161.160) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 27 Jan 2022 19:13:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D02UWB002.ant.amazon.com (10.43.161.160) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 27 Jan 2022 19:13:50 +0000 Received: from dev-dsk-alisaidi-i31e-9f3421fe.us-east-1.amazon.com (10.200.138.153) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1497.28 via Frontend Transport; Thu, 27 Jan 2022 19:13:50 +0000 Received: by dev-dsk-alisaidi-i31e-9f3421fe.us-east-1.amazon.com (Postfix, from userid 5131138) id 72BD921BE9; Thu, 27 Jan 2022 19:13:49 +0000 (UTC) From: Ali Saidi To: CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/2] perf arm-spe: Add arm_spe_record to synthesized Date: Thu, 27 Jan 2022 19:13:45 +0000 Message-ID: <20220127191345.18173-1-alisaidi@amazon.com> X-Mailer: git-send-email 2.24.4.AMZN In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 26/01/2022 19:07, German Gomez wrote: [...] >>> Have you tried this with perf-inject? I think it would need the PERF_SAMPLE_RAW bit in the sample_type, >> Yes I've tried the following and it worked as expected with the original >> perf.data or the perf.data.jitted after perf-inject. >> >> perf record -e arm_spe_0/jitter=1/ -k 1 java ... >> perf inject -f --jit -i perf.data -o perf.data.jitted > >This is not injecting the synthesized samples. I think it is still     >processing from the aux trace. Try adding "--itrace=i1i --strip" to the >inject command to remove the AUXTRACE events. Judging by the raw >samples, the data is missing: > > [...] Yep, you're correct here. If I use the command above the raw samples are lost. >>> Although I quickly looked over the perf inject code and it looks like it's expecting some type of padding: >>> >>> [...] >>> >>> I'm seeing some comments in utils/event.h related to this on the intel events. >> Yes i noticed this too,but looking at how the raw data is added to the same >> other places like intel-pt.c:1703 the perf_synth__raw*() functions are used to >> strip away the 4 bytes bytes before the data is added to the sample. The other >> places i can find the padding used is in builtin-script.c but given we have the >> --dump-raw-trace option it's not clear to me that it's needed to wrap the >> arm_spe_event in another struct with padding like perf_synth_intel_ptwrite? > >I think the intel use case makes sense because the layout of the data >is fixed and documented. If we modify the struct arm_spe_record later it >may not be obvious how to match it to the raw data of an older perf.data >file. And we're generating bigger files with redundant information. Not injecting the samples into the perf trace, but having a way to support custom scripts parsing the data would be really useful and much faster than trying to parse back the --dump-raw-trace output into something useful. The other way to go would be to put a header that describes the version of the spe struct at the head of it to address any future changes, but I'm not familiar with a workflow that would benefit from the added complexity. Thanks, Ali From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDFF1C433F5 for ; Thu, 27 Jan 2022 19:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lKg8sLR3WF9hW+iO4tedZve1aqr+jWKXejAN3nB0SSE=; b=QqUlxF5MSShCah SEFTF8velpTllpb+r+Wk2C1TZU4s3eLdSnNH/yJPbLT/dfqJlaLIroV9XO9O99hb15EWR7nYc/cA9 yQ/ft5mvieTdOMzxRYeJ7Resk5A1f8p3j5e3pI17diq9jPSPDqtDJPtrzJtEQ3XSx2y5hW7cqMbr8 28FWpulzU3tBAR2Z0/laZeWTYfHOJb5KCecrPNadWXZD2cbt25lYjGJJ90MiY/gOgP7f8kAO69bVM nWUNO1muIk0x1OH6LBKANvwwA3HImfpEQsgY+Z91nPrtymBY3lHLu62Qg9cZY+ibR3tAS3lKxusNY pj3b555QievAlVPCxgFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDADa-00GvEm-Dp; Thu, 27 Jan 2022 19:14:02 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDADW-00GvDu-Kf for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 19:14:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1643310839; x=1674846839; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mV9Rntd10MU7cdeZ3c0E0Qx20jU1t4bULsvd73nv/E4=; b=W3DB/VbuNepsjXVbGZXSxE5Ti5Ss+guVMazIB7tsnxenV2khO2LM/OGM pLzv9JO8Wajzui+jZ2F740arZzbhA19kz0GBZDjGJpUEUwcqIzVbdUA0i U7tmgmV55Mq7zGhFDp6aG7sb86nOSyg65zZG849YgyiIjBWwhGlicECq9 U=; X-IronPort-AV: E=Sophos;i="5.88,321,1635206400"; d="scan'208";a="173626860" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 27 Jan 2022 19:13:56 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com (Postfix) with ESMTPS id 9B8DA1A0067; Thu, 27 Jan 2022 19:13:51 +0000 (UTC) Received: from EX13D02UWB002.ant.amazon.com (10.43.161.160) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 27 Jan 2022 19:13:50 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D02UWB002.ant.amazon.com (10.43.161.160) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 27 Jan 2022 19:13:50 +0000 Received: from dev-dsk-alisaidi-i31e-9f3421fe.us-east-1.amazon.com (10.200.138.153) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1497.28 via Frontend Transport; Thu, 27 Jan 2022 19:13:50 +0000 Received: by dev-dsk-alisaidi-i31e-9f3421fe.us-east-1.amazon.com (Postfix, from userid 5131138) id 72BD921BE9; Thu, 27 Jan 2022 19:13:49 +0000 (UTC) From: Ali Saidi To: CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/2] perf arm-spe: Add arm_spe_record to synthesized Date: Thu, 27 Jan 2022 19:13:45 +0000 Message-ID: <20220127191345.18173-1-alisaidi@amazon.com> X-Mailer: git-send-email 2.24.4.AMZN In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_111358_855207_A77C791C X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDI2LzAxLzIwMjIgMTk6MDcsIEdlcm1hbiBHb21leiB3cm90ZToKWy4uLl0KPj4+IEhhdmUg eW91IHRyaWVkIHRoaXMgd2l0aCBwZXJmLWluamVjdD8gSSB0aGluayBpdCB3b3VsZCBuZWVkIHRo ZSBQRVJGX1NBTVBMRV9SQVcgYml0IGluIHRoZSBzYW1wbGVfdHlwZSwKPj4gWWVzIEkndmUgdHJp ZWQgdGhlIGZvbGxvd2luZyBhbmQgaXQgd29ya2VkIGFzIGV4cGVjdGVkIHdpdGggdGhlIG9yaWdp bmFsCj4+IHBlcmYuZGF0YSBvciB0aGUgcGVyZi5kYXRhLmppdHRlZCBhZnRlciBwZXJmLWluamVj dC4gCj4+Cj4+IHBlcmYgcmVjb3JkIC1lIGFybV9zcGVfMC9qaXR0ZXI9MS8gLWsgMSBqYXZhIC4u Lgo+PiBwZXJmICBpbmplY3QgLWYgLS1qaXQgLWkgcGVyZi5kYXRhIC1vIHBlcmYuZGF0YS5qaXR0 ZWQKPgo+VGhpcyBpcyBub3QgaW5qZWN0aW5nIHRoZSBzeW50aGVzaXplZCBzYW1wbGVzLiBJIHRo aW5rIGl0IGlzIHN0aWxswqDCoMKgwqAKPnByb2Nlc3NpbmcgZnJvbSB0aGUgYXV4IHRyYWNlLiBU cnkgYWRkaW5nICItLWl0cmFjZT1pMWkgLS1zdHJpcCIgdG8gdGhlCj5pbmplY3QgY29tbWFuZCB0 byByZW1vdmUgdGhlIEFVWFRSQUNFIGV2ZW50cy4gSnVkZ2luZyBieSB0aGUgcmF3Cj5zYW1wbGVz LCB0aGUgZGF0YSBpcyBtaXNzaW5nOgo+Cj4gWy4uLl0KClllcCwgeW91J3JlIGNvcnJlY3QgaGVy ZS4gSWYgSSB1c2UgdGhlIGNvbW1hbmQgYWJvdmUgdGhlIHJhdyBzYW1wbGVzIGFyZSBsb3N0LgoK Pj4+IEFsdGhvdWdoIEkgcXVpY2tseSBsb29rZWQgb3ZlciB0aGUgcGVyZiBpbmplY3QgY29kZSBh bmQgaXQgbG9va3MgbGlrZSBpdCdzIGV4cGVjdGluZyBzb21lIHR5cGUgb2YgcGFkZGluZzoKPj4+ Cj4+PiBbLi4uXQo+Pj4KPj4+IEknbSBzZWVpbmcgc29tZSBjb21tZW50cyBpbiB1dGlscy9ldmVu dC5oIHJlbGF0ZWQgdG8gdGhpcyBvbiB0aGUgaW50ZWwgZXZlbnRzLgo+PiBZZXMgaSBub3RpY2Vk IHRoaXMgdG9vLGJ1dCBsb29raW5nIGF0IGhvdyB0aGUgcmF3IGRhdGEgaXMgYWRkZWQgdG8gdGhl IHNhbWUKPj4gb3RoZXIgcGxhY2VzIGxpa2UgaW50ZWwtcHQuYzoxNzAzIHRoZSBwZXJmX3N5bnRo X19yYXcqKCkgZnVuY3Rpb25zIGFyZSB1c2VkIHRvCj4+IHN0cmlwIGF3YXkgdGhlIDQgYnl0ZXMg Ynl0ZXMgYmVmb3JlIHRoZSBkYXRhIGlzIGFkZGVkIHRvIHRoZSBzYW1wbGUuIFRoZSBvdGhlcgo+ PiBwbGFjZXMgaSBjYW4gZmluZCB0aGUgcGFkZGluZyB1c2VkIGlzIGluIGJ1aWx0aW4tc2NyaXB0 LmMgYnV0IGdpdmVuIHdlIGhhdmUgdGhlCj4+IC0tZHVtcC1yYXctdHJhY2Ugb3B0aW9uIGl0J3Mg bm90IGNsZWFyIHRvIG1lIHRoYXQgaXQncyBuZWVkZWQgdG8gd3JhcCB0aGUKPj4gYXJtX3NwZV9l dmVudCBpbiBhbm90aGVyIHN0cnVjdCB3aXRoIHBhZGRpbmcgbGlrZSBwZXJmX3N5bnRoX2ludGVs X3B0d3JpdGU/Cj4KPkkgdGhpbmsgdGhlIGludGVsIHVzZSBjYXNlIG1ha2VzIHNlbnNlIGJlY2F1 c2UgdGhlIGxheW91dCBvZiB0aGUgZGF0YQo+aXMgZml4ZWQgYW5kIGRvY3VtZW50ZWQuIElmIHdl IG1vZGlmeSB0aGUgc3RydWN0IGFybV9zcGVfcmVjb3JkIGxhdGVyIGl0Cj5tYXkgbm90IGJlIG9i dmlvdXMgaG93IHRvIG1hdGNoIGl0IHRvIHRoZSByYXcgZGF0YSBvZiBhbiBvbGRlciBwZXJmLmRh dGEKPmZpbGUuIEFuZCB3ZSdyZSBnZW5lcmF0aW5nIGJpZ2dlciBmaWxlcyB3aXRoIHJlZHVuZGFu dCBpbmZvcm1hdGlvbi4KCk5vdCBpbmplY3RpbmcgdGhlIHNhbXBsZXMgaW50byB0aGUgcGVyZiB0 cmFjZSwgYnV0IGhhdmluZyBhIHdheSB0byBzdXBwb3J0CmN1c3RvbSBzY3JpcHRzIHBhcnNpbmcg dGhlIGRhdGEgd291bGQgYmUgcmVhbGx5IHVzZWZ1bCBhbmQgbXVjaCBmYXN0ZXIgdGhhbgp0cnlp bmcgdG8gcGFyc2UgYmFjayB0aGUgLS1kdW1wLXJhdy10cmFjZSBvdXRwdXQgaW50byBzb21ldGhp bmcgdXNlZnVsLiBUaGUKb3RoZXIgd2F5IHRvIGdvIHdvdWxkIGJlIHRvIHB1dCBhIGhlYWRlciB0 aGF0IGRlc2NyaWJlcyB0aGUgdmVyc2lvbiBvZiB0aGUgc3BlCnN0cnVjdCBhdCB0aGUgaGVhZCBv ZiBpdCB0byBhZGRyZXNzIGFueSBmdXR1cmUgY2hhbmdlcywgYnV0IEknbSBub3QgZmFtaWxpYXIK d2l0aCBhIHdvcmtmbG93IHRoYXQgd291bGQgYmVuZWZpdCBmcm9tIHRoZSBhZGRlZCBjb21wbGV4 aXR5LiAKClRoYW5rcywKQWxpCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK