From: Fabiano Rosas <farosas@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, mark.cave-ayland@ilande.co.uk,
qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v2 7/8] target/ppc: 74xx: System Reset interrupt cleanup
Date: Thu, 27 Jan 2022 17:11:15 -0300 [thread overview]
Message-ID: <20220127201116.1154733-8-farosas@linux.ibm.com> (raw)
In-Reply-To: <20220127201116.1154733-1-farosas@linux.ibm.com>
The whole power saving states logic seems to be dependent on HV mode,
which don't exist for 74xx so I'm removing it all and leaving the
abort message.
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
target/ppc/excp_helper.c | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 396e25ed35..b7921c0956 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -703,23 +703,9 @@ static void powerpc_excp_74xx(PowerPCCPU *cpu, int excp)
case POWERPC_EXCP_DECR: /* Decrementer exception */
break;
case POWERPC_EXCP_RESET: /* System reset exception */
- /* A power-saving exception sets ME, otherwise it is unchanged */
if (msr_pow) {
- /* indicate that we resumed from power save mode */
- msr |= 0x10000;
- new_msr |= ((target_ulong)1 << MSR_ME);
- }
- if (env->msr_mask & MSR_HVB) {
- /*
- * ISA specifies HV, but can be delivered to guest with HV
- * clear (e.g., see FWNMI in PAPR, NMI injection in QEMU).
- */
- new_msr |= (target_ulong)MSR_HVB;
- } else {
- if (msr_pow) {
- cpu_abort(cs, "Trying to deliver power-saving system reset "
- "exception %d with no HV support\n", excp);
- }
+ cpu_abort(cs, "Trying to deliver power-saving system reset "
+ "exception %d with no HV support\n", excp);
}
break;
case POWERPC_EXCP_TRACE: /* Trace exception */
--
2.34.1
next prev parent reply other threads:[~2022-01-27 20:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 20:11 [PATCH v2 0/8] target/ppc: powerpc_excp improvements [74xx] (5/n) Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 1/8] target/ppc: Introduce powerpc_excp_74xx Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 2/8] target/ppc: Simplify powerpc_excp_74xx Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 3/8] target/ppc: 74xx: Machine Check exception cleanup Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 4/8] target/ppc: 74xx: External interrupt cleanup Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 5/8] target/ppc: 74xx: Program exception cleanup Fabiano Rosas
2022-01-27 20:11 ` [PATCH v2 6/8] target/ppc: 74xx: System Call " Fabiano Rosas
2022-01-27 22:20 ` BALATON Zoltan
2022-01-27 20:11 ` Fabiano Rosas [this message]
2022-01-27 20:11 ` [PATCH v2 8/8] target/ppc: 74xx: Set SRRs directly in exception code Fabiano Rosas
2022-01-27 22:28 ` BALATON Zoltan
2022-01-27 22:37 ` BALATON Zoltan
2022-01-27 22:52 ` Fabiano Rosas
2022-01-27 21:29 ` [PATCH v2 0/8] target/ppc: powerpc_excp improvements [74xx] (5/n) Mark Cave-Ayland
2022-01-27 22:58 ` BALATON Zoltan
2022-01-27 23:08 ` Fabiano Rosas
2022-01-27 23:16 ` Mark Cave-Ayland
2022-01-30 18:11 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127201116.1154733-8-farosas@linux.ibm.com \
--to=farosas@linux.ibm.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.