From: Trevor Woerner <twoerner@gmail.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH v3] knotty: improve the UI information
Date: Thu, 27 Jan 2022 15:51:38 -0500 [thread overview]
Message-ID: <20220127205138.29159-1-twoerner@gmail.com> (raw)
During a build you might end up with bitbake telling you:
Currently 30 running tasks (2757 of 2757/3476 of 6390)
Which, to me, is really confusing. The forward slash separator and the two
numbers immediately on each side of which are likely to be interpreted as
being one unit (i.e. 2757/3476) but they're not. Also nothing is labeled,
leaving the user to wonder what these numbers are.
Add labels, spaces, etc. to help clarify the information bitbake is trying to
convey. The resulting line would appear as:
30 running tasks (setscene:2757/2757 tasks:3476/6390)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
changes since v2:
- update the "No currently running tasks" message to "No running tasks"
(i.e. remove the word "currently") for consistency
- remove the double space between the two sets of values
changes since v1:
- improve the commit message
- remove the redundant word "Currently" in order to help keep the total
line length manageable for users of 80-column terminals
---
lib/bb/ui/knotty.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py
index 484545a6..2404d996 100644
--- a/lib/bb/ui/knotty.py
+++ b/lib/bb/ui/knotty.py
@@ -276,11 +276,11 @@ class TerminalFilter(object):
print(content)
else:
if self.quiet:
- content = "Running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+ content = "Running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
elif not len(activetasks):
- content = "No currently running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+ content = "No running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
else:
- content = "Currently %2s running tasks (%s of %s/%s of %s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+ content = "%2s running tasks (setscene:%s/%s tasks:%s/%s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
maxtask = self.helper.tasknumber_total
if not self.main_progress or self.main_progress.maxval != maxtask:
widgets = [' ', progressbar.Percentage(), ' ', progressbar.Bar()]
--
2.34.1.75.gabe6bb3905
next reply other threads:[~2022-01-27 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 20:51 Trevor Woerner [this message]
2022-02-01 8:00 ` [bitbake-devel] [PATCH v3] knotty: improve the UI information Richard Purdie
2022-02-01 14:17 ` Michael Opdenacker
2022-02-02 2:17 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127205138.29159-1-twoerner@gmail.com \
--to=twoerner@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.