All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Rik van Riel <riel@surriel.com>
Subject: Re: [RFC PATCH 1/2] NUMA balancing: fix NUMA topology type for memory tiering system
Date: Fri, 28 Jan 2022 10:53:45 +0530	[thread overview]
Message-ID: <20220128052345.GA618915@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220128023842.1946583-1-ying.huang@intel.com>

* Huang Ying <ying.huang@intel.com> [2022-01-28 10:38:41]:

> 
> One possible fix is to ignore CPU-less nodes when detecting NUMA
> topology type in init_numa_topology_type().  That works well for the
> example system.  Is it good in general for any system with CPU-less
> nodes?
> 

A CPUless node at the time online doesn't necessarily mean a CPUless node
for the entire boot. For example: On PowerVM Lpars, aka powerpc systems,
some of the nodes may start as CPUless nodes and then CPUS may get
populated/hotplugged on them.

Hence I am not sure if adding a check for CPUless nodes at node online may
work for such systems.

> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  kernel/sched/topology.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

-- 
Thanks and Regards
Srikar Dronamraju

  parent reply	other threads:[~2022-01-28  5:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28  2:38 [RFC PATCH 1/2] NUMA balancing: fix NUMA topology type for memory tiering system Huang Ying
2022-01-28  2:38 ` [RFC PATCH 2/2] NUMA balancing: avoid to migrate task to CPU-less node Huang Ying
2022-01-28  5:33   ` Srikar Dronamraju
2022-01-28  7:51     ` Huang, Ying
2022-02-01  5:59       ` Srikar Dronamraju
2022-02-08  8:19         ` Huang, Ying
2022-01-28  5:23 ` Srikar Dronamraju [this message]
2022-01-28  7:30   ` [RFC PATCH 1/2] NUMA balancing: fix NUMA topology type for memory tiering system Huang, Ying
2022-01-28 15:13     ` Peter Zijlstra
2022-01-30  1:07       ` Huang, Ying
2022-01-28 15:06 ` Peter Zijlstra
2022-01-28 17:08   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128052345.GA618915@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.