Re: [PATCH v2 3/3] dm: properly fix redundant bio-based IO accounting

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2635 bytes --]

Hi Mike,

I love your patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on device-mapper-dm/for-next hch-configfs/for-next v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mike-Snitzer/block-dm-fix-bio-based-DM-IO-accounting/20220128-065741
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20220128/202201281121.YMTa5Abg-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8bce71c28a009209a279db6200c981596b769dd1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mike-Snitzer/block-dm-fix-bio-based-DM-IO-accounting/20220128-065741
        git checkout 8bce71c28a009209a279db6200c981596b769dd1
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/md/dm.c: In function 'start_io_acct':
>> drivers/md/dm.c:492:9: error: implicit declaration of function '__bio_start_io_acct'; did you mean 'bio_start_io_acct'? [-Werror=implicit-function-declaration]
     492 |         __bio_start_io_acct(bio, io->start_time);
         |         ^~~~~~~~~~~~~~~~~~~
         |         bio_start_io_acct
   cc1: some warnings being treated as errors


vim +492 drivers/md/dm.c

   486	
   487	static void start_io_acct(struct dm_io *io)
   488	{
   489		struct mapped_device *md = io->md;
   490		struct bio *bio = io->orig_bio;
   491	
 > 492		__bio_start_io_acct(bio, io->start_time);
   493		if (unlikely(dm_stats_used(&md->stats)))
   494			dm_stats_account_io(&md->stats, bio_data_dir(bio),
   495					    bio->bi_iter.bi_sector, bio_sectors(bio),
   496					    false, 0, &io->stats_aux);
   497	}
   498	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org