From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 047D2C433F5 for ; Fri, 28 Jan 2022 11:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0FGGHp1bQDXs+TToGuZTEGnvLLKiLohZf4JnNhqG2WQ=; b=v93MSBSFIjFraH hyohRzRoLjp9kebXWftfgEAwtFk6DhPZ65hn+ngdvY5r9cy2db5JC3BhNQKZVJpq/ZdpVAgSXKqJ6 UoKFV/R+mys40Q8HmgxNa6sBqnpacPAJwA37ARHR+mJ/ANmHwwn313ZgwIIjQCTTqwaq30jWEXi8K CB38TN6mBLBJr7QQc90DhWe7kH/6M8XbzL6O/htLB1WsaA++Q/VpU1qCBDOohjbXAJmtG6DWnQdvC 8FNLoS4xmCPi7WeIfLfE09ig0VpFR/0G7fuu/2wEkqOSjPb7So76mkoHMUG+1mwV/KSzu8OI+4NFo fu+xEXxn05H0luZJXYEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcX-001kVm-92; Fri, 28 Jan 2022 11:40:49 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcU-001kSd-FP; Fri, 28 Jan 2022 11:40:48 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 17EA760008; Fri, 28 Jan 2022 11:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1643370040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQ1me8J/Zy0/NpDBsjxiNJCRMDYVYBgfgf4KXYlMBQE=; b=mhkRrkTFQg/3TwqlXdkqBpBcXYqooijDEC2Kv+kedQOmu14iMZ3uqYYp7BiMJpKHPzO7iy K64mkM4MAc2MJ7OVlGPAgcqvyNzthsTgD/NKZuOl7ELRyABV+8rc8HwoIbzZmAtRAuWGg+ fzwgwjlFGo6ML3GP5Mj3WTlewRxkK7vgDTYSnmuUQ8OA+C5eK0WJSiW0qjzuSdhgMtfPC0 8FQsAx5DK5K0oJiMV2V1Tq1YhS+iDXdMMvRuwx48thJ7g0dGuFvVEItgQzpadG/4q3RABR FvkCkJISCwUQzpok9OZsWFy77buG+yRQap9aK4cOeMt6MKRMAkLsFcmMpngpDg== Date: Fri, 28 Jan 2022 12:40:36 +0100 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v2 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220128124036.25fe0539@xps13> In-Reply-To: <20220128113237.39996-2-liang.yang@amlogic.com> References: <20220128113237.39996-1-liang.yang@amlogic.com> <20220128113237.39996-2-liang.yang@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_034046_857388_2D8D7355 X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIEZyaSwgMjggSmFuIDIw MjIgMTk6MzI6MzYgKzA4MDA6Cgo+IEVNTUMgYW5kIE5BTkQgaGFzIHRoZSBzYW1lIGNsb2NrIGNv bnRyb2wgcmVnaXN0ZXIgbmFtZWQgJ1NEX0VNTUNfQ0xPQ0snIHdoaWNoIGlzCgpoYXZlCgo+IGRl ZmluZWQgaW4gRU1NQyBwb3J0IGludGVybmFsbHkuIGJpdDB+NSBvZiAnU0RfRU1NQ19DTE9DSycg aXMgdGhlIGRpdmlkZXIgYW5kCj4gYml0Nn43IGlzIHRoZSBtdXggZm9yIGZpeCBwbGwgYW5kIHh0 YWwuCgo+IFByZXZpb3VzbHkgYSBjb21tb24gTU1DIHN1YiBjbG9jayBmcmFtZXdvcmsgaXMgaW1w bGVtZW50ZWQgYW5kIHNoYXJlZCBieSBFTU1DIGFuZAoKSSBiZWxpZXZlIHlvdSBtZWFudCB0aGF0 IHRoaXMgaGFzYSBhbHJlYWR5IGJlZW4gY29udHJpYnV0ZWQ/IEkgd291bGQKdGhlbiByZXBocmFz ZSB3aXRoOgoKQSBjb21tb24gTU1DIGFuZCBOQU5EIHN1Yi1jbG9jayBoYXMgYmVlbiBpbXBsZW1l bnRlZCBhbmQgY2FuIGJlIHVzZWQgYnkKdGhlIGVNTUMgYW5kIE5BTkQgY29udHJvbGxlciAod2hp Y2ggYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSBhbnl3YXkpLgoKTGV0J3MgdXNlIHRoaXMgbmV3IGNs b2NrLgoKPiBOQU5ELCBidXQgdGhhdCBpcyBjb3VwbGluZyB0aGUgRU1NQyBhbmQgTkFORCwgYWx0 aG91Z2ggRU1NQyBhbmQgTkFORCBpcyBtdXR1YWxseQo+IGV4Y2x1c2l2ZS4KPiAKPiBDaGFuZ2Ut SWQ6IEliZWI0YzdmZjg4NmY1ODg2YWFjNGQ2YzY2NGQ3YmJkMWIxYmNiOTk3CgpObyBjaGFuZ2Ug SWRzLgoKPiBTaWduZWQtb2ZmLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAxNjEgKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4OSBpbnNlcnRpb25z KCspLCA3MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9y YXcvbWVzb25fbmFuZC5jIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gaW5k ZXggYWMzYmU5Mjg3MmQwLi5mNmEzZDVjMmVhMWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tdGQv bmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gQEAgLTIsNyArMiw3IEBACj4gIC8qCj4gICAqIEFtbG9naWMgTWVzb24gTmFuZCBG bGFzaCBDb250cm9sbGVyIERyaXZlcgo+ICAgKgo+IC0gKiBDb3B5cmlnaHQgKGMpIDIwMTggQW1s b2dpYywgaW5jLgo+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMTgtMjAyMSBBbWxvZ2ljLCBpbmMuCgpQ bGVhc2UgZG9uJ3QuCgo+ICAgKiBBdXRob3I6IExpYW5nIFlhbmcgPGxpYW5nLnlhbmdAYW1sb2dp Yy5jb20+Cj4gICAqLwo+ICAKPiBAQCAtMTAsNiArMTAsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgv ZG1hLW1hcHBpbmcuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ICAjaW5jbHVk ZSA8bGludXgvY2xrLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9jbGstcHJvdmlkZXIuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L210ZC9yYXduYW5kLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tdGQvbXRkLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+Cj4gQEAgLTE5LDYgKzIwLDcgQEAKPiAg I2luY2x1ZGUgPGxpbnV4L2lvcG9sbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5o Pgo+ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvdGFza19zdGFjay5oPgo+ICAKPiAgI2RlZmluZSBO RkNfUkVHX0NNRAkJMHgwMAo+IEBAIC0xMDQsNiArMTA2LDkgQEAKPiAgCj4gICNkZWZpbmUgUEVS X0lORk9fQllURQkJOAo+ICAKPiArI2RlZmluZSBDTEtfRElWX1NISUZUCQkwCj4gKyNkZWZpbmUg Q0xLX0RJVl9XSURUSAkJNgo+ICsKPiAgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgewo+ICAJ c3RydWN0IGxpc3RfaGVhZCBub2RlOwo+ICAJc3RydWN0IG5hbmRfY2hpcCBuYW5kOwo+IEBAIC0x NTEsMTUgKzE1NiwxNyBAQCBzdHJ1Y3QgbWVzb25fbmZjIHsKPiAgCXN0cnVjdCBuYW5kX2NvbnRy b2xsZXIgY29udHJvbGxlcjsKPiAgCXN0cnVjdCBjbGsgKmNvcmVfY2xrOwo+ICAJc3RydWN0IGNs ayAqZGV2aWNlX2NsazsKPiAtCXN0cnVjdCBjbGsgKnBoYXNlX3R4Owo+IC0Jc3RydWN0IGNsayAq cGhhc2Vfcng7Cj4gKwlzdHJ1Y3QgY2xrICpuYW5kX2NsazsKPiArCXN0cnVjdCBjbGtfZGl2aWRl ciBuYW5kX2RpdmlkZXI7Cj4gIAo+ICAJdW5zaWduZWQgbG9uZyBjbGtfcmF0ZTsKPiAgCXUzMiBi dXNfdGltaW5nOwo+ICAKPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsKPiAtCXZvaWQgX19pb21lbSAq cmVnX2Jhc2U7Cj4gLQlzdHJ1Y3QgcmVnbWFwICpyZWdfY2xrOwo+ICsJc3RydWN0IHsKPiArCQl2 b2lkIF9faW9tZW0gKnJlZ19iYXNlOwo+ICsJCXZvaWQgX19pb21lbSAqc2RfZW1tY19jbG9jazsK PiArCX0gcmVzOwoKUGxlYXNlIHNwbGl0IHlvdXIgY29tbWl0OiBmaXJzdCB0aGUgbWVjaGFuaWNh bCBjaGFuZ2VzLCB0aGVuIHRoZSB1c2Ugb2YKdGhlIG5ldyBhcmVhIG9yIHNvbWV0aGluZyBsaWtl IHRoYXQuCgpPdGhlcndpc2UgdGhlcmUgYXJlIHRvbyBtYW55IGxpbmVzIGNoYW5nZWQsIEkgY2Fu J3Qgc3BvdCB3aGVyZSBpdCBpcwppbnRlcmVzdGluZy4KClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBt YWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7637EC433EF for ; Fri, 28 Jan 2022 11:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xBFA20jG//Wsg3hJ8Z1Zx7ZgESUNg7cZpDJpAZh5rts=; b=kpUk2GlRBfORjV ENyuQwy5v7k3SPh6gZ4/FUa/weKOTU0wtNqYM2VsAwkig4twVz5qYgdmMwrpsiRWA+/l4XGNmatdG nmWiA/Ixp7Mw6q9wcsBqLoUIkwq6J5B0U1OP96TxVaEUe4ItJBsqPBpDFYrm8Ye+E8IFKuM+UgeUA UOZJi0HvEy2owVJb+HCGId738d0fi8GvbrFGjqOjCogBgarv8YFhmLk/j+oL7UXKRmla54gj00hTP YBKZ7KXp8PvVyfs8716lqE1k7SFcd0FfIxS8B+Jy2yiPAceRyhy8ks2WW8D1Sfjl7Y+abfutu6Jzd faRXNS7FqSO043cMlu0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcv-001kbw-II; Fri, 28 Jan 2022 11:41:13 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcU-001kSd-FP; Fri, 28 Jan 2022 11:40:48 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 17EA760008; Fri, 28 Jan 2022 11:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1643370040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQ1me8J/Zy0/NpDBsjxiNJCRMDYVYBgfgf4KXYlMBQE=; b=mhkRrkTFQg/3TwqlXdkqBpBcXYqooijDEC2Kv+kedQOmu14iMZ3uqYYp7BiMJpKHPzO7iy K64mkM4MAc2MJ7OVlGPAgcqvyNzthsTgD/NKZuOl7ELRyABV+8rc8HwoIbzZmAtRAuWGg+ fzwgwjlFGo6ML3GP5Mj3WTlewRxkK7vgDTYSnmuUQ8OA+C5eK0WJSiW0qjzuSdhgMtfPC0 8FQsAx5DK5K0oJiMV2V1Tq1YhS+iDXdMMvRuwx48thJ7g0dGuFvVEItgQzpadG/4q3RABR FvkCkJISCwUQzpok9OZsWFy77buG+yRQap9aK4cOeMt6MKRMAkLsFcmMpngpDg== Date: Fri, 28 Jan 2022 12:40:36 +0100 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v2 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220128124036.25fe0539@xps13> In-Reply-To: <20220128113237.39996-2-liang.yang@amlogic.com> References: <20220128113237.39996-1-liang.yang@amlogic.com> <20220128113237.39996-2-liang.yang@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_034046_857388_2D8D7355 X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIEZyaSwgMjggSmFuIDIw MjIgMTk6MzI6MzYgKzA4MDA6Cgo+IEVNTUMgYW5kIE5BTkQgaGFzIHRoZSBzYW1lIGNsb2NrIGNv bnRyb2wgcmVnaXN0ZXIgbmFtZWQgJ1NEX0VNTUNfQ0xPQ0snIHdoaWNoIGlzCgpoYXZlCgo+IGRl ZmluZWQgaW4gRU1NQyBwb3J0IGludGVybmFsbHkuIGJpdDB+NSBvZiAnU0RfRU1NQ19DTE9DSycg aXMgdGhlIGRpdmlkZXIgYW5kCj4gYml0Nn43IGlzIHRoZSBtdXggZm9yIGZpeCBwbGwgYW5kIHh0 YWwuCgo+IFByZXZpb3VzbHkgYSBjb21tb24gTU1DIHN1YiBjbG9jayBmcmFtZXdvcmsgaXMgaW1w bGVtZW50ZWQgYW5kIHNoYXJlZCBieSBFTU1DIGFuZAoKSSBiZWxpZXZlIHlvdSBtZWFudCB0aGF0 IHRoaXMgaGFzYSBhbHJlYWR5IGJlZW4gY29udHJpYnV0ZWQ/IEkgd291bGQKdGhlbiByZXBocmFz ZSB3aXRoOgoKQSBjb21tb24gTU1DIGFuZCBOQU5EIHN1Yi1jbG9jayBoYXMgYmVlbiBpbXBsZW1l bnRlZCBhbmQgY2FuIGJlIHVzZWQgYnkKdGhlIGVNTUMgYW5kIE5BTkQgY29udHJvbGxlciAod2hp Y2ggYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSBhbnl3YXkpLgoKTGV0J3MgdXNlIHRoaXMgbmV3IGNs b2NrLgoKPiBOQU5ELCBidXQgdGhhdCBpcyBjb3VwbGluZyB0aGUgRU1NQyBhbmQgTkFORCwgYWx0 aG91Z2ggRU1NQyBhbmQgTkFORCBpcyBtdXR1YWxseQo+IGV4Y2x1c2l2ZS4KPiAKPiBDaGFuZ2Ut SWQ6IEliZWI0YzdmZjg4NmY1ODg2YWFjNGQ2YzY2NGQ3YmJkMWIxYmNiOTk3CgpObyBjaGFuZ2Ug SWRzLgoKPiBTaWduZWQtb2ZmLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAxNjEgKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4OSBpbnNlcnRpb25z KCspLCA3MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9y YXcvbWVzb25fbmFuZC5jIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gaW5k ZXggYWMzYmU5Mjg3MmQwLi5mNmEzZDVjMmVhMWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tdGQv bmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gQEAgLTIsNyArMiw3IEBACj4gIC8qCj4gICAqIEFtbG9naWMgTWVzb24gTmFuZCBG bGFzaCBDb250cm9sbGVyIERyaXZlcgo+ICAgKgo+IC0gKiBDb3B5cmlnaHQgKGMpIDIwMTggQW1s b2dpYywgaW5jLgo+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMTgtMjAyMSBBbWxvZ2ljLCBpbmMuCgpQ bGVhc2UgZG9uJ3QuCgo+ICAgKiBBdXRob3I6IExpYW5nIFlhbmcgPGxpYW5nLnlhbmdAYW1sb2dp Yy5jb20+Cj4gICAqLwo+ICAKPiBAQCAtMTAsNiArMTAsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgv ZG1hLW1hcHBpbmcuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ICAjaW5jbHVk ZSA8bGludXgvY2xrLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9jbGstcHJvdmlkZXIuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L210ZC9yYXduYW5kLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tdGQvbXRkLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+Cj4gQEAgLTE5LDYgKzIwLDcgQEAKPiAg I2luY2x1ZGUgPGxpbnV4L2lvcG9sbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5o Pgo+ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvdGFza19zdGFjay5oPgo+ICAKPiAgI2RlZmluZSBO RkNfUkVHX0NNRAkJMHgwMAo+IEBAIC0xMDQsNiArMTA2LDkgQEAKPiAgCj4gICNkZWZpbmUgUEVS X0lORk9fQllURQkJOAo+ICAKPiArI2RlZmluZSBDTEtfRElWX1NISUZUCQkwCj4gKyNkZWZpbmUg Q0xLX0RJVl9XSURUSAkJNgo+ICsKPiAgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgewo+ICAJ c3RydWN0IGxpc3RfaGVhZCBub2RlOwo+ICAJc3RydWN0IG5hbmRfY2hpcCBuYW5kOwo+IEBAIC0x NTEsMTUgKzE1NiwxNyBAQCBzdHJ1Y3QgbWVzb25fbmZjIHsKPiAgCXN0cnVjdCBuYW5kX2NvbnRy b2xsZXIgY29udHJvbGxlcjsKPiAgCXN0cnVjdCBjbGsgKmNvcmVfY2xrOwo+ICAJc3RydWN0IGNs ayAqZGV2aWNlX2NsazsKPiAtCXN0cnVjdCBjbGsgKnBoYXNlX3R4Owo+IC0Jc3RydWN0IGNsayAq cGhhc2Vfcng7Cj4gKwlzdHJ1Y3QgY2xrICpuYW5kX2NsazsKPiArCXN0cnVjdCBjbGtfZGl2aWRl ciBuYW5kX2RpdmlkZXI7Cj4gIAo+ICAJdW5zaWduZWQgbG9uZyBjbGtfcmF0ZTsKPiAgCXUzMiBi dXNfdGltaW5nOwo+ICAKPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsKPiAtCXZvaWQgX19pb21lbSAq cmVnX2Jhc2U7Cj4gLQlzdHJ1Y3QgcmVnbWFwICpyZWdfY2xrOwo+ICsJc3RydWN0IHsKPiArCQl2 b2lkIF9faW9tZW0gKnJlZ19iYXNlOwo+ICsJCXZvaWQgX19pb21lbSAqc2RfZW1tY19jbG9jazsK PiArCX0gcmVzOwoKUGxlYXNlIHNwbGl0IHlvdXIgY29tbWl0OiBmaXJzdCB0aGUgbWVjaGFuaWNh bCBjaGFuZ2VzLCB0aGVuIHRoZSB1c2Ugb2YKdGhlIG5ldyBhcmVhIG9yIHNvbWV0aGluZyBsaWtl IHRoYXQuCgpPdGhlcndpc2UgdGhlcmUgYXJlIHRvbyBtYW55IGxpbmVzIGNoYW5nZWQsIEkgY2Fu J3Qgc3BvdCB3aGVyZSBpdCBpcwppbnRlcmVzdGluZy4KClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1U RCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31B68C433EF for ; Fri, 28 Jan 2022 11:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1mnmzKSRlbz9GsW/W9CbhAfuRaQcsQAITwPytoud2tM=; b=yOAyykU2alaNem OnW4xTg9mOkdEvifgj0KQIk2tHpICHzUyvQLincBbTUmWP2uIWN8YwVrhQfFmzqRyK42kF4U1ZiUB 66q3HgbsaavgNOaejTScBmd9IlEKLhp4xaE9MuqMsghH40y8K9ZBAnxzifzveyDCae4ua7NnLfk4F mNmOIUkl8/Vm7owc+xPoFi/1K5L/8f7OTc/PeCBFqTdLEdiM+HXhzlLa1pnskzkZfcJRDux03wOzs ImgcV+iWAtZ/+kRBtmfwXupJWmDQXGv5bzvzE9rvG429H5Ie7JeathG0aFezdl3F8bytbDlLFz4zt 2kI7LCk9pHi/zCCS3U3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcb-001kWB-8j; Fri, 28 Jan 2022 11:40:53 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDPcU-001kSd-FP; Fri, 28 Jan 2022 11:40:48 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 17EA760008; Fri, 28 Jan 2022 11:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1643370040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQ1me8J/Zy0/NpDBsjxiNJCRMDYVYBgfgf4KXYlMBQE=; b=mhkRrkTFQg/3TwqlXdkqBpBcXYqooijDEC2Kv+kedQOmu14iMZ3uqYYp7BiMJpKHPzO7iy K64mkM4MAc2MJ7OVlGPAgcqvyNzthsTgD/NKZuOl7ELRyABV+8rc8HwoIbzZmAtRAuWGg+ fzwgwjlFGo6ML3GP5Mj3WTlewRxkK7vgDTYSnmuUQ8OA+C5eK0WJSiW0qjzuSdhgMtfPC0 8FQsAx5DK5K0oJiMV2V1Tq1YhS+iDXdMMvRuwx48thJ7g0dGuFvVEItgQzpadG/4q3RABR FvkCkJISCwUQzpok9OZsWFy77buG+yRQap9aK4cOeMt6MKRMAkLsFcmMpngpDg== Date: Fri, 28 Jan 2022 12:40:36 +0100 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v2 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220128124036.25fe0539@xps13> In-Reply-To: <20220128113237.39996-2-liang.yang@amlogic.com> References: <20220128113237.39996-1-liang.yang@amlogic.com> <20220128113237.39996-2-liang.yang@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_034046_857388_2D8D7355 X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGlhbmcsCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIEZyaSwgMjggSmFuIDIw MjIgMTk6MzI6MzYgKzA4MDA6Cgo+IEVNTUMgYW5kIE5BTkQgaGFzIHRoZSBzYW1lIGNsb2NrIGNv bnRyb2wgcmVnaXN0ZXIgbmFtZWQgJ1NEX0VNTUNfQ0xPQ0snIHdoaWNoIGlzCgpoYXZlCgo+IGRl ZmluZWQgaW4gRU1NQyBwb3J0IGludGVybmFsbHkuIGJpdDB+NSBvZiAnU0RfRU1NQ19DTE9DSycg aXMgdGhlIGRpdmlkZXIgYW5kCj4gYml0Nn43IGlzIHRoZSBtdXggZm9yIGZpeCBwbGwgYW5kIHh0 YWwuCgo+IFByZXZpb3VzbHkgYSBjb21tb24gTU1DIHN1YiBjbG9jayBmcmFtZXdvcmsgaXMgaW1w bGVtZW50ZWQgYW5kIHNoYXJlZCBieSBFTU1DIGFuZAoKSSBiZWxpZXZlIHlvdSBtZWFudCB0aGF0 IHRoaXMgaGFzYSBhbHJlYWR5IGJlZW4gY29udHJpYnV0ZWQ/IEkgd291bGQKdGhlbiByZXBocmFz ZSB3aXRoOgoKQSBjb21tb24gTU1DIGFuZCBOQU5EIHN1Yi1jbG9jayBoYXMgYmVlbiBpbXBsZW1l bnRlZCBhbmQgY2FuIGJlIHVzZWQgYnkKdGhlIGVNTUMgYW5kIE5BTkQgY29udHJvbGxlciAod2hp Y2ggYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSBhbnl3YXkpLgoKTGV0J3MgdXNlIHRoaXMgbmV3IGNs b2NrLgoKPiBOQU5ELCBidXQgdGhhdCBpcyBjb3VwbGluZyB0aGUgRU1NQyBhbmQgTkFORCwgYWx0 aG91Z2ggRU1NQyBhbmQgTkFORCBpcyBtdXR1YWxseQo+IGV4Y2x1c2l2ZS4KPiAKPiBDaGFuZ2Ut SWQ6IEliZWI0YzdmZjg4NmY1ODg2YWFjNGQ2YzY2NGQ3YmJkMWIxYmNiOTk3CgpObyBjaGFuZ2Ug SWRzLgoKPiBTaWduZWQtb2ZmLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAxNjEgKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4OSBpbnNlcnRpb25z KCspLCA3MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9y YXcvbWVzb25fbmFuZC5jIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gaW5k ZXggYWMzYmU5Mjg3MmQwLi5mNmEzZDVjMmVhMWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tdGQv bmFuZC9yYXcvbWVzb25fbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25f bmFuZC5jCj4gQEAgLTIsNyArMiw3IEBACj4gIC8qCj4gICAqIEFtbG9naWMgTWVzb24gTmFuZCBG bGFzaCBDb250cm9sbGVyIERyaXZlcgo+ICAgKgo+IC0gKiBDb3B5cmlnaHQgKGMpIDIwMTggQW1s b2dpYywgaW5jLgo+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMTgtMjAyMSBBbWxvZ2ljLCBpbmMuCgpQ bGVhc2UgZG9uJ3QuCgo+ICAgKiBBdXRob3I6IExpYW5nIFlhbmcgPGxpYW5nLnlhbmdAYW1sb2dp Yy5jb20+Cj4gICAqLwo+ICAKPiBAQCAtMTAsNiArMTAsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgv ZG1hLW1hcHBpbmcuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ICAjaW5jbHVk ZSA8bGludXgvY2xrLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9jbGstcHJvdmlkZXIuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L210ZC9yYXduYW5kLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tdGQvbXRkLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+Cj4gQEAgLTE5LDYgKzIwLDcgQEAKPiAg I2luY2x1ZGUgPGxpbnV4L2lvcG9sbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5o Pgo+ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvdGFza19zdGFjay5oPgo+ICAKPiAgI2RlZmluZSBO RkNfUkVHX0NNRAkJMHgwMAo+IEBAIC0xMDQsNiArMTA2LDkgQEAKPiAgCj4gICNkZWZpbmUgUEVS X0lORk9fQllURQkJOAo+ICAKPiArI2RlZmluZSBDTEtfRElWX1NISUZUCQkwCj4gKyNkZWZpbmUg Q0xLX0RJVl9XSURUSAkJNgo+ICsKPiAgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgewo+ICAJ c3RydWN0IGxpc3RfaGVhZCBub2RlOwo+ICAJc3RydWN0IG5hbmRfY2hpcCBuYW5kOwo+IEBAIC0x NTEsMTUgKzE1NiwxNyBAQCBzdHJ1Y3QgbWVzb25fbmZjIHsKPiAgCXN0cnVjdCBuYW5kX2NvbnRy b2xsZXIgY29udHJvbGxlcjsKPiAgCXN0cnVjdCBjbGsgKmNvcmVfY2xrOwo+ICAJc3RydWN0IGNs ayAqZGV2aWNlX2NsazsKPiAtCXN0cnVjdCBjbGsgKnBoYXNlX3R4Owo+IC0Jc3RydWN0IGNsayAq cGhhc2Vfcng7Cj4gKwlzdHJ1Y3QgY2xrICpuYW5kX2NsazsKPiArCXN0cnVjdCBjbGtfZGl2aWRl ciBuYW5kX2RpdmlkZXI7Cj4gIAo+ICAJdW5zaWduZWQgbG9uZyBjbGtfcmF0ZTsKPiAgCXUzMiBi dXNfdGltaW5nOwo+ICAKPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsKPiAtCXZvaWQgX19pb21lbSAq cmVnX2Jhc2U7Cj4gLQlzdHJ1Y3QgcmVnbWFwICpyZWdfY2xrOwo+ICsJc3RydWN0IHsKPiArCQl2 b2lkIF9faW9tZW0gKnJlZ19iYXNlOwo+ICsJCXZvaWQgX19pb21lbSAqc2RfZW1tY19jbG9jazsK PiArCX0gcmVzOwoKUGxlYXNlIHNwbGl0IHlvdXIgY29tbWl0OiBmaXJzdCB0aGUgbWVjaGFuaWNh bCBjaGFuZ2VzLCB0aGVuIHRoZSB1c2Ugb2YKdGhlIG5ldyBhcmVhIG9yIHNvbWV0aGluZyBsaWtl IHRoYXQuCgpPdGhlcndpc2UgdGhlcmUgYXJlIHRvbyBtYW55IGxpbmVzIGNoYW5nZWQsIEkgY2Fu J3Qgc3BvdCB3aGVyZSBpdCBpcwppbnRlcmVzdGluZy4KClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5067C433F5 for ; Fri, 28 Jan 2022 11:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239819AbiA1Lkn (ORCPT ); Fri, 28 Jan 2022 06:40:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237846AbiA1Lkm (ORCPT ); Fri, 28 Jan 2022 06:40:42 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD123C061714; Fri, 28 Jan 2022 03:40:41 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 17EA760008; Fri, 28 Jan 2022 11:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1643370040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQ1me8J/Zy0/NpDBsjxiNJCRMDYVYBgfgf4KXYlMBQE=; b=mhkRrkTFQg/3TwqlXdkqBpBcXYqooijDEC2Kv+kedQOmu14iMZ3uqYYp7BiMJpKHPzO7iy K64mkM4MAc2MJ7OVlGPAgcqvyNzthsTgD/NKZuOl7ELRyABV+8rc8HwoIbzZmAtRAuWGg+ fzwgwjlFGo6ML3GP5Mj3WTlewRxkK7vgDTYSnmuUQ8OA+C5eK0WJSiW0qjzuSdhgMtfPC0 8FQsAx5DK5K0oJiMV2V1Tq1YhS+iDXdMMvRuwx48thJ7g0dGuFvVEItgQzpadG/4q3RABR FvkCkJISCwUQzpok9OZsWFy77buG+yRQap9aK4cOeMt6MKRMAkLsFcmMpngpDg== Date: Fri, 28 Jan 2022 12:40:36 +0100 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v2 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220128124036.25fe0539@xps13> In-Reply-To: <20220128113237.39996-2-liang.yang@amlogic.com> References: <20220128113237.39996-1-liang.yang@amlogic.com> <20220128113237.39996-2-liang.yang@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Liang, liang.yang@amlogic.com wrote on Fri, 28 Jan 2022 19:32:36 +0800: > EMMC and NAND has the same clock control register named 'SD_EMMC_CLOCK' w= hich is have > defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is the divider= and > bit6~7 is the mux for fix pll and xtal. > Previously a common MMC sub clock framework is implemented and shared by = EMMC and I believe you meant that this hasa already been contributed? I would then rephrase with: A common MMC and NAND sub-clock has been implemented and can be used by the eMMC and NAND controller (which are mutually exclusive anyway). Let's use this new clock. > NAND, but that is coupling the EMMC and NAND, although EMMC and NAND is m= utually > exclusive. >=20 > Change-Id: Ibeb4c7ff886f5886aac4d6c664d7bbd1b1bcb997 No change Ids. > Signed-off-by: Liang Yang > --- > drivers/mtd/nand/raw/meson_nand.c | 161 +++++++++++++++++------------- > 1 file changed, 89 insertions(+), 72 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index ac3be92872d0..f6a3d5c2ea1c 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -2,7 +2,7 @@ > /* > * Amlogic Meson Nand Flash Controller Driver > * > - * Copyright (c) 2018 Amlogic, inc. > + * Copyright (c) 2018-2021 Amlogic, inc. Please don't. > * Author: Liang Yang > */ > =20 > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -19,6 +20,7 @@ > #include > #include > #include > +#include > #include > =20 > #define NFC_REG_CMD 0x00 > @@ -104,6 +106,9 @@ > =20 > #define PER_INFO_BYTE 8 > =20 > +#define CLK_DIV_SHIFT 0 > +#define CLK_DIV_WIDTH 6 > + > struct meson_nfc_nand_chip { > struct list_head node; > struct nand_chip nand; > @@ -151,15 +156,17 @@ struct meson_nfc { > struct nand_controller controller; > struct clk *core_clk; > struct clk *device_clk; > - struct clk *phase_tx; > - struct clk *phase_rx; > + struct clk *nand_clk; > + struct clk_divider nand_divider; > =20 > unsigned long clk_rate; > u32 bus_timing; > =20 > struct device *dev; > - void __iomem *reg_base; > - struct regmap *reg_clk; > + struct { > + void __iomem *reg_base; > + void __iomem *sd_emmc_clock; > + } res; Please split your commit: first the mechanical changes, then the use of the new area or something like that. Otherwise there are too many lines changed, I can't spot where it is interesting. Thanks, Miqu=C3=A8l