diff for duplicates of <202201281246.NKFv8GyG-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 5280262..77bb8d6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,7 @@ -CC: kbuild-all(a)lists.01.org -In-Reply-To: <20220127164125.3651285-7-michael@walle.cc> -References: <20220127164125.3651285-7-michael@walle.cc> -TO: Michael Walle <michael@walle.cc> - Hi Michael, -I love your patch! Perhaps something to improve: - -[auto build test WARNING on soc/for-next] -[also build test WARNING on next-20220127] -[cannot apply to linux/master linus/master v5.17-rc1] -[If your patch is applied to the wrong git tree, kindly drop us a note. -And when submitting patch, we suggest to use '--base' as documented in -https://git-scm.com/docs/git-format-patch] - url: https://github.com/0day-ci/linux/commits/Michael-Walle/soc-fsl-guts-cleanups-and-serial_number-support/20220128-004223 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next -:::::: branch date: 12 hours ago -:::::: commit date: 12 hours ago config: openrisc-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220128/202201281246.NKFv8GyG-lkp(a)intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 @@ -33,7 +17,6 @@ drivers/soc/fsl/guts.c:182 fsl_guts_init() warn: possible memory leak of 'soc_de vim +/soc_dev_attr +169 drivers/soc/fsl/guts.c -a83b17321e29c5 Michael Walle 2022-01-27 144 a83b17321e29c5 Michael Walle 2022-01-27 145 static int __init fsl_guts_init(void) a6fc3b69813023 yangbo lu 2016-11-09 146 { c93df5b7c92a04 Michael Walle 2022-01-27 147 struct soc_device_attribute *soc_dev_attr; @@ -51,6 +34,8 @@ a83b17321e29c5 Michael Walle 2022-01-27 158 if (!np) a83b17321e29c5 Michael Walle 2022-01-27 159 return 0; a6fc3b69813023 yangbo lu 2016-11-09 160 a83b17321e29c5 Michael Walle 2022-01-27 161 soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); + ^^^^^^^^^^^^^^^ + c93df5b7c92a04 Michael Walle 2022-01-27 162 if (!soc_dev_attr) c93df5b7c92a04 Michael Walle 2022-01-27 163 return -ENOMEM; c93df5b7c92a04 Michael Walle 2022-01-27 164 @@ -59,6 +44,10 @@ a6fc3b69813023 yangbo lu 2016-11-09 166 01e929af81c348 Michael Walle 2022-01-27 167 regs = of_iomap(np, 0); 01e929af81c348 Michael Walle 2022-01-27 168 if (IS_ERR(regs)) 01e929af81c348 Michael Walle 2022-01-27 @169 return PTR_ERR(regs); + ^^^^^^^^^^^^^^^^^^^^ +No error handling. We'd want to call of_node_put(np) as well. + + --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index 901b58e..3f3bf51 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,29 +1,14 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "ref\020220127164125.3651285-7-michael@walle.cc\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH v1 6/7] soc: fsl: guts: drop platform driver\0" - "Date\0Fri, 28 Jan 2022 12:50:34 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Fri, 28 Jan 2022 10:25:03 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "In-Reply-To: <20220127164125.3651285-7-michael@walle.cc>\n" - "References: <20220127164125.3651285-7-michael@walle.cc>\n" - "TO: Michael Walle <michael@walle.cc>\n" - "\n" "Hi Michael,\n" "\n" - "I love your patch! Perhaps something to improve:\n" - "\n" - "[auto build test WARNING on soc/for-next]\n" - "[also build test WARNING on next-20220127]\n" - "[cannot apply to linux/master linus/master v5.17-rc1]\n" - "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" - "And when submitting patch, we suggest to use '--base' as documented in\n" - "https://git-scm.com/docs/git-format-patch]\n" - "\n" "url: https://github.com/0day-ci/linux/commits/Michael-Walle/soc-fsl-guts-cleanups-and-serial_number-support/20220128-004223\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next\n" - ":::::: branch date: 12 hours ago\n" - ":::::: commit date: 12 hours ago\n" "config: openrisc-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220128/202201281246.NKFv8GyG-lkp(a)intel.com/config)\n" "compiler: or1k-linux-gcc (GCC) 11.2.0\n" "\n" @@ -39,7 +24,6 @@ "\n" "vim +/soc_dev_attr +169 drivers/soc/fsl/guts.c\n" "\n" - "a83b17321e29c5 Michael Walle 2022-01-27 144 \n" "a83b17321e29c5 Michael Walle 2022-01-27 145 static int __init fsl_guts_init(void)\n" "a6fc3b69813023 yangbo lu 2016-11-09 146 {\n" "c93df5b7c92a04 Michael Walle 2022-01-27 147 \tstruct soc_device_attribute *soc_dev_attr;\n" @@ -57,6 +41,8 @@ "a83b17321e29c5 Michael Walle 2022-01-27 159 \t\treturn 0;\n" "a6fc3b69813023 yangbo lu 2016-11-09 160 \n" "a83b17321e29c5 Michael Walle 2022-01-27 161 \tsoc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);\n" + " ^^^^^^^^^^^^^^^\n" + "\n" "c93df5b7c92a04 Michael Walle 2022-01-27 162 \tif (!soc_dev_attr)\n" "c93df5b7c92a04 Michael Walle 2022-01-27 163 \t\treturn -ENOMEM;\n" "c93df5b7c92a04 Michael Walle 2022-01-27 164 \n" @@ -65,9 +51,13 @@ "01e929af81c348 Michael Walle 2022-01-27 167 \tregs = of_iomap(np, 0);\n" "01e929af81c348 Michael Walle 2022-01-27 168 \tif (IS_ERR(regs))\n" "01e929af81c348 Michael Walle 2022-01-27 @169 \t\treturn PTR_ERR(regs);\n" + " ^^^^^^^^^^^^^^^^^^^^\n" + "No error handling. We'd want to call of_node_put(np) as well.\n" + "\n" + "\n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -bd4a63c37e6ed8c3ca62cdbbb1c174e032fa4e55b8c1f23d0f80271a59c82472 +e6a1fedd1f241a67cd594210d8f287c7f00ff0e0869b7f6a76c8d07297896792
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.