From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0475590947767190238==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 29 Jan 2022 01:59:39 +0800 Message-ID: <20220128175939.GA13705@b9c7d76355f5> In-Reply-To: <202201290131.vQRFF968-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0475590947767190238== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Ferruh Yigit CC: Dmitry Torokhov CC: linux-input(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ w= ith no primary handler requested without IRQF_ONESHOT (unless it is nested = IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 145d9b498fc827b79c1260b4caa29a8e59d4c2b9 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 8 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! cyttsp4_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/input/touchscreen/cyttsp4_core.c +++ b/drivers/input/touchscreen/cyttsp4_core.c @@ -2090,8 +2090,9 @@ struct cyttsp4 *cyttsp4_probe(const stru /* use edge triggered interrupts */ irq_flags =3D IRQF_TRIGGER_FALLING | IRQF_ONESHOT; = - rc =3D request_threaded_irq(cd->irq, NULL, cyttsp4_irq, irq_flags, - dev_name(dev), cd); + rc =3D request_threaded_irq(cd->irq, NULL, cyttsp4_irq, + irq_flags | IRQF_ONESHOT, + dev_name(dev), cd); if (rc < 0) { dev_err(dev, "%s: Error, could not request irq\n", __func__); goto error_request_irq; --===============0475590947767190238==--