From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4678072229860789992==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 29 Jan 2022 03:28:50 +0800 Message-ID: <20220128192849.GA3647@6caf23feb5e9> In-Reply-To: <202201290335.68sRjdlN-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4678072229860789992== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Lee Jones CC: patches(a)opensource.cirrus.com CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/mfd/wm8994-irq.c:232:8-28: WARNING: Threaded IRQ with no primary ha= ndler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 145d9b498fc827b79c1260b4caa29a8e59d4c2b9 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 10 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! wm8994-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mfd/wm8994-irq.c +++ b/drivers/mfd/wm8994-irq.c @@ -231,7 +231,7 @@ int wm8994_irq_init(struct wm8994 *wm899 = ret =3D request_threaded_irq(wm8994->irq, NULL, wm8994_edge_irq, - irqflags, + irqflags | IRQF_ONESHOT, "WM8994 edge", wm8994); } else { ret =3D regmap_add_irq_chip(wm8994->regmap, wm8994->irq, --===============4678072229860789992==--