From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8706292110256936131==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 29 Jan 2022 05:51:22 +0800 Message-ID: <20220128215122.GA84324@936fc5f4d8d3> In-Reply-To: <202201290510.zLzohE2x-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============8706292110256936131== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Michael Hennerich CC: Dmitry Torokhov CC: linux-input(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/input/misc/ad714x.c:1153:9-34: WARNING: Threaded IRQ with no primar= y handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 169387e2aa291a4e3cb856053730fe99d6cec06f commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 3 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! ad714x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/input/misc/ad714x.c +++ b/drivers/input/misc/ad714x.c @@ -1152,7 +1152,8 @@ struct ad714x_chip *ad714x_probe(struct = error =3D devm_request_threaded_irq(dev, ad714x->irq, NULL, ad714x_interrupt_thread, - irqflags, "ad714x_captouch", ad714x); + irqflags | IRQF_ONESHOT, + "ad714x_captouch", ad714x); if (error) { dev_err(dev, "can't allocate irq %d\n", ad714x->irq); return ERR_PTR(error); --===============8706292110256936131==--