From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0038195082072912677==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 29 Jan 2022 05:51:29 +0800 Message-ID: <20220128215128.GA86242@936fc5f4d8d3> In-Reply-To: <202201290510.zLzohE2x-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0038195082072912677== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Lee Jones CC: patches(a)opensource.cirrus.com CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/mfd/wm8350-irq.c:527:7-27: WARNING: Threaded IRQ with no primary ha= ndler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 169387e2aa291a4e3cb856053730fe99d6cec06f commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 3 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! wm8350-irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mfd/wm8350-irq.c +++ b/drivers/mfd/wm8350-irq.c @@ -524,7 +524,8 @@ int wm8350_irq_init(struct wm8350 *wm835 irq_clear_status_flags(cur_irq, IRQ_NOREQUEST | IRQ_NOPROBE); } = - ret =3D request_threaded_irq(irq, NULL, wm8350_irq, flags, + ret =3D request_threaded_irq(irq, NULL, wm8350_irq, + flags | IRQF_ONESHOT, "wm8350", wm8350); if (ret !=3D 0) dev_err(wm8350->dev, "Failed to request IRQ: %d\n", ret); --===============0038195082072912677==--