From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/pci/controller/dwc/pcie-kirin.c:321:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
Date: Sat, 29 Jan 2022 14:52:02 +0800 [thread overview]
Message-ID: <202201291228.17gN1FOR-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4086 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 169387e2aa291a4e3cb856053730fe99d6cec06f
commit: 61d37547436dce45e3590db72360df0e230ca969 PCI: kirin: Reorganize the PHY logic inside the driver
date: 3 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 3 months ago
compiler: riscv32-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/pci/controller/dwc/pcie-kirin.c:321:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
pdev = container_of(dev, struct platform_device, dev);
^
vim +321 drivers/pci/controller/dwc/pcie-kirin.c
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 305
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 306 static int hi3660_pcie_phy_init(struct platform_device *pdev,
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 307 struct kirin_pcie *pcie)
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 308 {
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 309 struct device *dev = &pdev->dev;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 310 struct hi3660_pcie_phy *phy;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 311 int ret;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 312
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 313 phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 314 if (!phy)
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 315 return -ENOMEM;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 316
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 317 pcie->phy_priv = phy;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 318 phy->dev = dev;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 319
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 320 /* registers */
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 @321 pdev = container_of(dev, struct platform_device, dev);
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 322
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 323 ret = hi3660_pcie_phy_get_clk(phy);
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 324 if (ret)
fc5165db245ac4 drivers/pci/dwc/pcie-kirin.c Xiaowei Song 2017-06-19 325 return ret;
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 326
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 327 return hi3660_pcie_phy_get_resource(phy);
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 328 }
61d37547436dce drivers/pci/controller/dwc/pcie-kirin.c Mauro Carvalho Chehab 2021-10-21 329
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2022-01-29 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 6:52 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-25 0:56 drivers/pci/controller/dwc/pcie-kirin.c:321:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201291228.17gN1FOR-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.