From: Tom Rini <trini@konsulko.com>
To: Adam Ford <aford173@gmail.com>
Cc: u-boot@lists.denx.de, marex@denx.de, aford@beaconembedded.com
Subject: Re: [PATCH V3] phy: nop-phy: Enable reset-gpios support
Date: Sat, 29 Jan 2022 07:50:47 -0500 [thread overview]
Message-ID: <20220129125047.GP7515@bill-the-cat> (raw)
In-Reply-To: <20220122180202.13583-1-aford173@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Sat, Jan 22, 2022 at 12:02:02PM -0600, Adam Ford wrote:
> Some usb-nop-xceiv devices use a gpio to put them in and
> out of reset. Add a reset function to put them into that
> state. This is similar to how Linux handles the
> usb-nop-xceiv driver.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V3: Encapsulate the nop_phy_ops reference to nop_phy_reset
> in an if-def so it doesn't appear when DM_GPIO is not
> enabled.
>
> V2: Only use the GPIO functions when DM_GPIO is enabled
> Add error handling so if the GPIO fails, it will shutdown
> the clocks and return with the error code.
> Call nop_phy_reset() instead of repeating the same code.
At the risk of sounding a bit too cranky, please build test v4 for
k2e_evm as it's still failing to build due to these changes.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-01-29 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 18:02 [PATCH V3] phy: nop-phy: Enable reset-gpios support Adam Ford
2022-01-29 12:50 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129125047.GP7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.