Re: [RFC PATCH v3 09/13] module: Move kallsyms support into a separate file

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4959 bytes --]

Hi Aaron,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on a97ac8cb24a3c3ad74794adb83717ef1605d1b47]

url:    https://github.com/0day-ci/linux/commits/Aaron-Tomlin/module-core-code-clean-up/20220129-044218
base:   a97ac8cb24a3c3ad74794adb83717ef1605d1b47
config: arc-randconfig-s032-20220124 (https://download.01.org/0day-ci/archive/20220129/202201291433.XLcEC5fB-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/fd6ae2d3fa439baa614e32c58b4c2f0dd0faa186
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aaron-Tomlin/module-core-code-clean-up/20220129-044218
        git checkout fd6ae2d3fa439baa614e32c58b4c2f0dd0faa186
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   kernel/module/kallsyms.c: note: in included file:
   include/linux/module.h:386:3: sparse: sparse: symbol 'mod_tree' was not declared. Should it be static?
>> kernel/module/kallsyms.c:174:23: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct mod_kallsyms [noderef] __rcu *kallsyms @@     got void * @@
   kernel/module/kallsyms.c:174:23: sparse:     expected struct mod_kallsyms [noderef] __rcu *kallsyms
   kernel/module/kallsyms.c:174:23: sparse:     got void *
>> kernel/module/kallsyms.c:176:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:177:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:179:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:180:12: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:189:18: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:190:35: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:191:20: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:196:32: sparse: sparse: dereference of noderef expression
   kernel/module/kallsyms.c:199:45: sparse: sparse: dereference of noderef expression

vim +174 kernel/module/kallsyms.c

   159	
   160	/*
   161	 * We use the full symtab and strtab which layout_symtab arranged to
   162	 * be appended to the init section.  Later we switch to the cut-down
   163	 * core-only ones.
   164	 */
   165	void add_kallsyms(struct module *mod, const struct load_info *info)
   166	{
   167		unsigned int i, ndst;
   168		const Elf_Sym *src;
   169		Elf_Sym *dst;
   170		char *s;
   171		Elf_Shdr *symsec = &info->sechdrs[info->index.sym];
   172	
   173		/* Set up to point into init section. */
 > 174		mod->kallsyms = mod->init_layout.base + info->mod_kallsyms_init_off;
   175	
 > 176		mod->kallsyms->symtab = (void *)symsec->sh_addr;
   177		mod->kallsyms->num_symtab = symsec->sh_size / sizeof(Elf_Sym);
   178		/* Make sure we get permanent strtab: don't use info->strtab. */
   179		mod->kallsyms->strtab = (void *)info->sechdrs[info->index.str].sh_addr;
   180		mod->kallsyms->typetab = mod->init_layout.base + info->init_typeoffs;
   181	
   182		/*
   183		 * Now populate the cut down core kallsyms for after init
   184		 * and set types up while we still have access to sections.
   185		 */
   186		mod->core_kallsyms.symtab = dst = mod->core_layout.base + info->symoffs;
   187		mod->core_kallsyms.strtab = s = mod->core_layout.base + info->stroffs;
   188		mod->core_kallsyms.typetab = mod->core_layout.base + info->core_typeoffs;
   189		src = mod->kallsyms->symtab;
   190		for (ndst = i = 0; i < mod->kallsyms->num_symtab; i++) {
   191			mod->kallsyms->typetab[i] = elf_type(src + i, info);
   192			if (i == 0 || is_livepatch_module(mod) ||
   193			    is_core_symbol(src+i, info->sechdrs, info->hdr->e_shnum,
   194					   info->index.pcpu)) {
   195				mod->core_kallsyms.typetab[ndst] =
   196				    mod->kallsyms->typetab[i];
   197				dst[ndst] = src[i];
   198				dst[ndst++].st_name = s - mod->core_kallsyms.strtab;
   199				s += strscpy(s, &mod->kallsyms->strtab[src[i].st_name],
   200					     KSYM_NAME_LEN) + 1;
   201			}
   202		}
   203		mod->core_kallsyms.num_symtab = ndst;
   204	}
   205	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org