Re: [PATCH] drm/lsdc: add drm driver support for loongson display controller

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3683 bytes --]

Hi Sui,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on v5.17-rc2 next-20220128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sui-Jingfeng/drm-lsdc-add-drm-driver-support-for-loongson-display-controller/20220130-130855
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: s390-randconfig-r044-20220130 (https://download.01.org/0day-ci/archive/20220131/202201310744.a12EW0LM-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3595361f14c6607486d8c94cf7f012f8c8b267c3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sui-Jingfeng/drm-lsdc-add-drm-driver-support-for-loongson-display-controller/20220130-130855
        git checkout 3595361f14c6607486d8c94cf7f012f8c8b267c3
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/drm/lsdc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/lsdc/lsdc_pll.c:219: warning: Function parameter or member 'this' not described in 'lsdc_pixpll_find'
   drivers/gpu/drm/lsdc/lsdc_pll.c:219: warning: Function parameter or member 'clock' not described in 'lsdc_pixpll_find'
   drivers/gpu/drm/lsdc/lsdc_pll.c:219: warning: Function parameter or member 'pout' not described in 'lsdc_pixpll_find'
>> drivers/gpu/drm/lsdc/lsdc_pll.c:219: warning: expecting prototype for lsdc_crtc_init(). Prototype was for lsdc_pixpll_find() instead


vim +219 drivers/gpu/drm/lsdc/lsdc_pll.c

   195	
   196	
   197	/**
   198	 * lsdc_crtc_init
   199	 *
   200	 * @ddev: point to the drm_device structure
   201	 * @index: hardware crtc index
   202	 *
   203	 * Init CRTC
   204	 */
   205	
   206	/*
   207	 * Find a set of pll parameters (to generate pixel clock) from a static
   208	 * local table, which avoid to compute the pll parameter everytime a
   209	 * modeset is triggered.
   210	 *
   211	 * @clock: the desired pixel clock wanted to generate, the unit is kHz
   212	 * @pout: pointer to where hardware pll parameters(if found) to save
   213	 *
   214	 *  Return true if a parameter is found, otherwise return false.
   215	 */
   216	static bool lsdc_pixpll_find(struct lsdc_pll * const this,
   217				     unsigned int clock,
   218				     struct lsdc_pll_core_values * const pout)
 > 219	{
   220		unsigned int num = ARRAY_SIZE(pll_param_table);
   221		unsigned int i;
   222	
   223		for (i = 0; i < num; i++) {
   224			if (clock != pll_param_table[i].clock)
   225				continue;
   226	
   227			pout->div_ref = pll_param_table[i].div_ref;
   228			pout->loopc   = pll_param_table[i].loopc;
   229			pout->div_out = pll_param_table[i].div_out;
   230	
   231			return true;
   232		}
   233	
   234		drm_dbg(this->ddev, "pixel clock %u: miss\n", clock);
   235	
   236		return false;
   237	}
   238	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org