From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7478717964435475218==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [RFC PATCH v4 13/13] module: Move version support into a separate file Date: Mon, 31 Jan 2022 08:41:10 +0800 Message-ID: <202201310837.htvWxdpM-lkp@intel.com> In-Reply-To: <20220130213214.1042497-14-atomlin@redhat.com> List-Id: --===============7478717964435475218== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Aaron, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on a97ac8cb24a3c3ad74794adb83717ef1605d1b47] url: https://github.com/0day-ci/linux/commits/Aaron-Tomlin/module-core-c= ode-clean-up/20220131-053513 base: a97ac8cb24a3c3ad74794adb83717ef1605d1b47 config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220131= /202201310837.htvWxdpM-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4b7033ba7af584b33c6319a1c= b62c2639230228d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Aaron-Tomlin/module-core-code-clea= n-up/20220131-053513 git checkout 4b7033ba7af584b33c6319a1cb62c2639230228d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash kernel/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from kernel/module/version.c:8: include/linux/module.h: In function 'is_livepatch_module': include/linux/module.h:708:26: error: 'struct module' has no member name= d 'klp'; did you mean 'kp'? 708 | if (mod->klp) | ^~~ | kp include/linux/module.h: In function 'set_livepatch_module': include/linux/module.h:717:22: error: 'struct module' has no member name= d 'klp'; did you mean 'kp'? 717 | mod->klp =3D true; | ^~~ | kp In file included from kernel/module/version.c:11: kernel/module/internal.h: In function 'mod_find': >> kernel/module/internal.h:142:9: error: implicit declaration of function = 'list_for_each_entry_rcu'; did you mean 'list_for_each_entry_from'? [-Werro= r=3Dimplicit-function-declaration] 142 | list_for_each_entry_rcu(mod, &modules, list, | ^~~~~~~~~~~~~~~~~~~~~~~ | list_for_each_entry_from >> kernel/module/internal.h:142:48: error: 'list' undeclared (first use in = this function) 142 | list_for_each_entry_rcu(mod, &modules, list, | ^~~~ kernel/module/internal.h:142:48: note: each undeclared identifier is rep= orted only once for each function it appears in >> kernel/module/internal.h:143:64: error: expected ';' before '{' token 143 | lockdep_is_held(&module_mutex)) { | ^~ | ; kernel/module/internal.h:149:1: error: no return statement in function r= eturning non-void [-Werror=3Dreturn-type] 149 | } | ^ kernel/module/version.c: At top level: kernel/module/version.c:103:6: warning: no previous prototype for 'modul= e_layout' [-Wmissing-prototypes] 103 | void module_layout(struct module *mod, | ^~~~~~~~~~~~~ In file included from kernel/module/version.c:11: kernel/module/internal.h:138:23: warning: 'mod_find' defined but not use= d [-Wunused-function] 138 | static struct module *mod_find(unsigned long addr) | ^~~~~~~~ kernel/module/internal.h:137:13: warning: 'mod_tree_remove' defined but = not used [-Wunused-function] 137 | static void mod_tree_remove(struct module *mod) { } | ^~~~~~~~~~~~~~~ kernel/module/internal.h:136:13: warning: 'mod_tree_remove_init' defined= but not used [-Wunused-function] 136 | static void mod_tree_remove_init(struct module *mod) { } | ^~~~~~~~~~~~~~~~~~~~ kernel/module/internal.h:135:13: warning: 'mod_tree_insert' defined but = not used [-Wunused-function] 135 | static void mod_tree_insert(struct module *mod) { } | ^~~~~~~~~~~~~~~ kernel/module/internal.h:133:46: warning: 'module_addr_max' defined but = not used [-Wunused-variable] 133 | static unsigned long module_addr_min =3D -1UL, module_addr_max = =3D 0; | ^~~~~~~~~~~~~~~ kernel/module/internal.h:133:22: warning: 'module_addr_min' defined but = not used [-Wunused-variable] 133 | static unsigned long module_addr_min =3D -1UL, module_addr_max = =3D 0; | ^~~~~~~~~~~~~~~ In file included from kernel/module/version.c:8: include/linux/module.h:374:12: warning: 'module_enforce_rwx_sections' de= fined but not used [-Wunused-function] 374 | static int module_enforce_rwx_sections(Elf_Ehdr *hdr, Elf_Shdr *= sechdrs, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/module.h:373:13: warning: 'module_enable_ro' defined but n= ot used [-Wunused-function] 373 | static void module_enable_ro(const struct module *mod, bool afte= r_init) {} | ^~~~~~~~~~~~~~~~ include/linux/module.h:372:13: warning: 'module_enable_nx' defined but n= ot used [-Wunused-function] 372 | static void module_enable_nx(const struct module *mod) { } | ^~~~~~~~~~~~~~~~ include/linux/module.h:356:13: warning: 'module_enable_x' defined but no= t used [-Wunused-function] 356 | static void module_enable_x(const struct module *mod) { } | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +142 kernel/module/internal.h a80d594cdec224 Aaron Tomlin 2022-01-30 134 = a80d594cdec224 Aaron Tomlin 2022-01-30 135 static void mod_tree_insert(st= ruct module *mod) { } a80d594cdec224 Aaron Tomlin 2022-01-30 136 static void mod_tree_remove_in= it(struct module *mod) { } a80d594cdec224 Aaron Tomlin 2022-01-30 137 static void mod_tree_remove(st= ruct module *mod) { } a80d594cdec224 Aaron Tomlin 2022-01-30 138 static struct module *mod_find= (unsigned long addr) a80d594cdec224 Aaron Tomlin 2022-01-30 139 { a80d594cdec224 Aaron Tomlin 2022-01-30 140 struct module *mod; a80d594cdec224 Aaron Tomlin 2022-01-30 141 = a80d594cdec224 Aaron Tomlin 2022-01-30 @142 list_for_each_entry_rcu(mod, = &modules, list, a80d594cdec224 Aaron Tomlin 2022-01-30 @143 lockdep_is_held(&module_mu= tex)) { a80d594cdec224 Aaron Tomlin 2022-01-30 144 if (within_module(addr, mod)) a80d594cdec224 Aaron Tomlin 2022-01-30 145 return mod; a80d594cdec224 Aaron Tomlin 2022-01-30 146 } a80d594cdec224 Aaron Tomlin 2022-01-30 147 = a80d594cdec224 Aaron Tomlin 2022-01-30 148 return NULL; a80d594cdec224 Aaron Tomlin 2022-01-30 149 } a80d594cdec224 Aaron Tomlin 2022-01-30 150 #endif /* CONFIG_MODULES_TREE_= LOOKUP */ a9958f8b57f826 Aaron Tomlin 2022-01-30 151 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7478717964435475218==--