diff for duplicates of <20220131113351.49a47caf@rhtmp> diff --git a/a/1.txt b/N1/1.txt index 74476ba..f1ce889 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Hi, On Fri, 28 Jan 2022 11:31:49 +0100 -Petr Tesa??k <ptesarik@suse.cz> wrote: +Petr Tesařík <ptesarik@suse.cz> wrote: > Hi Tiezhu Yang, > @@ -55,11 +55,11 @@ This also works for memory restrained systems. Needs a reboot though... > > > > kernel/crash_core: Add crashkernel=auto for vmcore creation > > -> > https://lore.kernel.org/lkml/20210223174153.72802-1-saeed.mirzamohammadi at oracle.com/ +> > https://lore.kernel.org/lkml/20210223174153.72802-1-saeed.mirzamohammadi@oracle.com/ The patch was ultimately rejected by Linus -https://lore.kernel.org/linux-mm/20210507010432.IN24PudKT%25akpm at linux-foundation.org/ +https://lore.kernel.org/linux-mm/20210507010432.IN24PudKT%25akpm@linux-foundation.org/ Thanks Philipp @@ -73,35 +73,35 @@ Philipp > >>> +++ b/kernel/crash_core.c > >>> @@ -252,6 +252,26 @@ static int __init __parse_crashkernel(char > >>> *cmdline, -> >>> ????? if (suffix) -> >>> ????????? return parse_crashkernel_suffix(ck_cmdline, crash_size, -> >>> ????????????????? suffix); +> >>> if (suffix) +> >>> return parse_crashkernel_suffix(ck_cmdline, crash_size, +> >>> suffix); > >>> + -> >>> +??? if (strncmp(ck_cmdline, "auto", 4) == 0) { +> >>> + if (strncmp(ck_cmdline, "auto", 4) == 0) { > >>> +#if defined(CONFIG_X86_64) || defined(CONFIG_S390) -> >>> +??????? ck_cmdline = "1G-4G:160M,4G-64G:192M,64G-1T:256M,1T-:512M"; +> >>> + ck_cmdline = "1G-4G:160M,4G-64G:192M,64G-1T:256M,1T-:512M"; > >>> +#elif defined(CONFIG_ARM64) -> >>> +??????? ck_cmdline = "2G-:448M"; +> >>> + ck_cmdline = "2G-:448M"; > >>> +#elif defined(CONFIG_PPC64) -> >>> +??????? char *fadump_cmdline; +> >>> + char *fadump_cmdline; > >>> + -> >>> +??????? fadump_cmdline = get_last_crashkernel(cmdline, "fadump=", +> >>> + fadump_cmdline = get_last_crashkernel(cmdline, "fadump=", > >>> NULL); -> >>> +??????? fadump_cmdline = fadump_cmdline ? -> >>> +??????????????? fadump_cmdline + strlen("fadump=") : NULL; -> >>> +??????? if (!fadump_cmdline || (strncmp(fadump_cmdline, "off", 3) == +> >>> + fadump_cmdline = fadump_cmdline ? +> >>> + fadump_cmdline + strlen("fadump=") : NULL; +> >>> + if (!fadump_cmdline || (strncmp(fadump_cmdline, "off", 3) == > >>> 0)) -> >>> +??????????? ck_cmdline = +> >>> + ck_cmdline = > >>> "2G-4G:384M,4G-16G:512M,16G-64G:1G,64G-128G:2G,128G-:4G"; -> >>> +??????? else -> >>> +??????????? ck_cmdline = +> >>> + else +> >>> + ck_cmdline = > >>> "4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"; > >>> > >>> > >>> +#endif -> >>> +??????? pr_info("Using crashkernel=auto, the size chosen is a best +> >>> + pr_info("Using crashkernel=auto, the size chosen is a best > >>> effort estimation.\n"); -> >>> +??? } +> >>> + } > >>> + > >> > >> How did you even arrive at the above numbers? @@ -138,10 +138,10 @@ Philipp > > > > _______________________________________________ > > kexec mailing list -> > kexec at lists.infradead.org +> > kexec@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/kexec > > _______________________________________________ > kexec mailing list -> kexec at lists.infradead.org +> kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec diff --git a/a/content_digest b/N1/content_digest index 6883771..c180046 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,15 +3,25 @@ "ref\0f28c65f0-9bbb-6bf8-a223-0e18b861c805@loongson.cn\0" "ref\0ba065272-78bd-65d0-1e76-08455519b6db@suse.cz\0" "From\0Philipp Rudo <prudo@redhat.com>\0" - "Subject\0[RFC PATCH] kdump: Add support for crashkernel=auto\0" + "Subject\0Re: [RFC PATCH] kdump: Add support for crashkernel=auto\0" "Date\0Mon, 31 Jan 2022 11:33:51 +0100\0" - "To\0kexec@lists.infradead.org\0" + "To\0Petr Tesa\305\231\303\255k <ptesarik@suse.cz>\0" + "Cc\0Tiezhu Yang <yangtiezhu@loongson.cn>" + Baoquan He <bhe@redhat.com> + Vivek Goyal <vgoyal@redhat.com> + Dave Young <dyoung@redhat.com> + Jonathan Corbet <corbet@lwn.net> + Andrew Morton <akpm@linux-foundation.org> + Xuefeng Li <lixuefeng@loongson.cn> + kexec@lists.infradead.org + linux-doc@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "Hi,\n" "\n" "On Fri, 28 Jan 2022 11:31:49 +0100\n" - "Petr Tesa??k <ptesarik@suse.cz> wrote:\n" + "Petr Tesa\305\231\303\255k <ptesarik@suse.cz> wrote:\n" "\n" "> Hi Tiezhu Yang,\n" "> \n" @@ -65,11 +75,11 @@ "> > \n" "> > kernel/crash_core: Add crashkernel=auto for vmcore creation\n" "> > \n" - "> > https://lore.kernel.org/lkml/20210223174153.72802-1-saeed.mirzamohammadi at oracle.com/ \n" + "> > https://lore.kernel.org/lkml/20210223174153.72802-1-saeed.mirzamohammadi@oracle.com/ \n" "\n" "The patch was ultimately rejected by Linus\n" "\n" - "https://lore.kernel.org/linux-mm/20210507010432.IN24PudKT%25akpm at linux-foundation.org/\n" + "https://lore.kernel.org/linux-mm/20210507010432.IN24PudKT%25akpm@linux-foundation.org/\n" "\n" "Thanks\n" "Philipp\n" @@ -83,35 +93,35 @@ "> >>> +++ b/kernel/crash_core.c\n" "> >>> @@ -252,6 +252,26 @@ static int __init __parse_crashkernel(char \n" "> >>> *cmdline,\n" - "> >>> ????? if (suffix)\n" - "> >>> ????????? return parse_crashkernel_suffix(ck_cmdline, crash_size,\n" - "> >>> ????????????????? suffix);\n" + "> >>> \302\240\302\240\302\240\302\240\302\240 if (suffix)\n" + "> >>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 return parse_crashkernel_suffix(ck_cmdline, crash_size,\n" + "> >>> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 suffix);\n" "> >>> +\n" - "> >>> +??? if (strncmp(ck_cmdline, \"auto\", 4) == 0) {\n" + "> >>> +\302\240\302\240\302\240 if (strncmp(ck_cmdline, \"auto\", 4) == 0) {\n" "> >>> +#if defined(CONFIG_X86_64) || defined(CONFIG_S390)\n" - "> >>> +??????? ck_cmdline = \"1G-4G:160M,4G-64G:192M,64G-1T:256M,1T-:512M\";\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 ck_cmdline = \"1G-4G:160M,4G-64G:192M,64G-1T:256M,1T-:512M\";\n" "> >>> +#elif defined(CONFIG_ARM64)\n" - "> >>> +??????? ck_cmdline = \"2G-:448M\";\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 ck_cmdline = \"2G-:448M\";\n" "> >>> +#elif defined(CONFIG_PPC64)\n" - "> >>> +??????? char *fadump_cmdline;\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 char *fadump_cmdline;\n" "> >>> +\n" - "> >>> +??????? fadump_cmdline = get_last_crashkernel(cmdline, \"fadump=\", \n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 fadump_cmdline = get_last_crashkernel(cmdline, \"fadump=\", \n" "> >>> NULL);\n" - "> >>> +??????? fadump_cmdline = fadump_cmdline ?\n" - "> >>> +??????????????? fadump_cmdline + strlen(\"fadump=\") : NULL;\n" - "> >>> +??????? if (!fadump_cmdline || (strncmp(fadump_cmdline, \"off\", 3) == \n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 fadump_cmdline = fadump_cmdline ?\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 fadump_cmdline + strlen(\"fadump=\") : NULL;\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 if (!fadump_cmdline || (strncmp(fadump_cmdline, \"off\", 3) == \n" "> >>> 0))\n" - "> >>> +??????????? ck_cmdline =\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 ck_cmdline =\n" "> >>> \"2G-4G:384M,4G-16G:512M,16G-64G:1G,64G-128G:2G,128G-:4G\";\n" - "> >>> +??????? else\n" - "> >>> +??????????? ck_cmdline =\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 else\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 ck_cmdline =\n" "> >>> \"4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G\"; \n" "> >>>\n" "> >>>\n" "> >>> +#endif\n" - "> >>> +??????? pr_info(\"Using crashkernel=auto, the size chosen is a best\n" + "> >>> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 pr_info(\"Using crashkernel=auto, the size chosen is a best\n" "> >>> effort estimation.\\n\");\n" - "> >>> +??? }\n" + "> >>> +\302\240\302\240\302\240 }\n" "> >>> + \n" "> >>\n" "> >> How did you even arrive at the above numbers? \n" @@ -148,12 +158,12 @@ "> > \n" "> > _______________________________________________\n" "> > kexec mailing list\n" - "> > kexec at lists.infradead.org\n" + "> > kexec@lists.infradead.org\n" "> > http://lists.infradead.org/mailman/listinfo/kexec \n" "> \n" "> _______________________________________________\n" "> kexec mailing list\n" - "> kexec at lists.infradead.org\n" + "> kexec@lists.infradead.org\n" > http://lists.infradead.org/mailman/listinfo/kexec -5270ffb54feb743c69a8cc722ad7d678d48a9b86800b796d191e650659dcca71 +a0cde980d2414e2cda823cb6dc96f8da56098623e1c1a5e022815aaef69a05b2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.