From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C676BC433EF for ; Mon, 31 Jan 2022 11:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378263AbiAaLw1 (ORCPT ); Mon, 31 Jan 2022 06:52:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378084AbiAaLuJ (ORCPT ); Mon, 31 Jan 2022 06:50:09 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4906C09426A; Mon, 31 Jan 2022 03:36:19 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id d10so42135428eje.10; Mon, 31 Jan 2022 03:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m7A4pVSNJzjFxlNDUBif0ZSjzzxnHlIlhqH9+88MCVE=; b=nLY0dw1UbRO4nmzzwMHn2iPJSCTIQbwe0J1U5nCM53blsnqZM3dTetobnp/HM/KOIP WWnAAVCjZNvGMTy2kKFM0xg4+rZXzlZ2c5GSdvnS9L27TCy23ROd3dO/4xJPPAQGJ5EF uwr7alA8vx5rkSNppkJx/7LoGyNHO4/sMY596xAjHmJOEPJtm9bSLh31koHzzAnamm/D F/PWxFJyDAzdCww/4fXc1BoKmN36S/xxiclOylv8kKakNrw1Er8+zHVg/P3TkY2RpbSj 2AFGfKb/00Y5X53/MMTRCiw80oxYzAXB2Rdezy1o1AqgltWEaQPVpOU8I1AEPkxod69A ho5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m7A4pVSNJzjFxlNDUBif0ZSjzzxnHlIlhqH9+88MCVE=; b=xqERVj+X+E/Nhr+jEZbhvCnhb15/XxY2nhwRKpX1bqmFqcosVVZTBtmKkHD1s6E44Y BniWLVyXAVirfRuMCH1bnIjpt+ooep27n0z15GNQOX/j0sT9EnIhOn6mpmNo8ubfbwk0 8ldB1m83RNNIvAJd6GkCX49Eaa8PgJ0fRlCd3qNgAhm31aUwl93lVgTDE6HqNm7UxVjU U9VkUlGLa8Rgpge69l49d97AOcdpmoIkKueLrTXzIJXjyZxq5QDRtYqEOiXRTOxT601Y qaoLsyBn0MzegwbrQHn4svE1qp8emIJwbZ7fcdV4bREm6dMaD04MQV80x/wTM3Bmw4QF 0fUw== X-Gm-Message-State: AOAM531C70MFgvJgg6w19+r0hDLPIMNPJAo+VGEr10YwQeH4kAcThZjO prE0jK8hCsW5+YY2OID8vdwuMRfL/80KHA== X-Google-Smtp-Source: ABdhPJzNa2PvryNQRXW9SMrFZ8YqhBpr8tgJS1NdRci1rCS3yirNO2SWtbmF4gBWcUsjX5C7xw2BoA== X-Received: by 2002:a17:907:6eaa:: with SMTP id sh42mr16701737ejc.388.1643628978367; Mon, 31 Jan 2022 03:36:18 -0800 (PST) Received: from adroid (027-177-184-091.ip-addr.vsenet.de. [91.184.177.27]) by smtp.gmail.com with ESMTPSA id d2sm13343309ejw.70.2022.01.31.03.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 03:36:17 -0800 (PST) Date: Mon, 31 Jan 2022 12:36:15 +0100 From: Martin =?iso-8859-1?Q?J=FCcker?= To: Krzysztof Kozlowski Cc: Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Martin =?iso-8859-1?Q?J=FCcker?= Subject: Re: [PATCH] ARM: dts: add 533 MHz step to p4note GPU opp table Message-ID: <20220131113615.GA4916@adroid> References: <20220129221452.GA36524@adroid> <131c9bd9-b035-8a75-ca27-f9c2b3993566@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <131c9bd9-b035-8a75-ca27-f9c2b3993566@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Mon, Jan 31, 2022 at 09:54:00AM +0100, Krzysztof Kozlowski wrote: > On 29/01/2022 23:14, Martin Jücker wrote: > > The p4note devices support 533 MHz GPU speed, so let's make use of it. > > > > If there is going to be resend, please add prefix "exynos:" in subject. > Just like other commits (git log --oneline arch/arm/boot/dts/exynos*). > Okay. > > Signed-off-by: Martin Jücker > > --- > > arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi > > index 4ae6eb3091c4..d277b2337ae0 100644 > > --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi > > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi > > @@ -355,6 +355,13 @@ &gpu { > > status = "okay"; > > }; > > > > +&gpu_opp_table { > > + opp-533000000 { > > + opp-hz = /bits/ 64 <533000000>; > > + opp-microvolt = <1075000>; > > + }; > > +}; > > This looks like Exynos4412 Prime. Please check also CPU frequencies and > if they match, just include exynos4412-prime.dtsi (like Odroid U3). > I thought so as well, but unfortunately it's not. The chip id is 0xe4412211 and according to the vendor kernel, the prime version would need to have the last two digits being 0x20 or higher. See: https://github.com/Viciouss/samsung_p4note_kernel_backup/blob/da306e1846bb4b9682f46be1b23b05d6fbebffba/arch/arm/mach-exynos/cpufreq-4x12.c#L619 On the other hand, this kernel has the 533 MHz step unlocked for all versions: https://github.com/Viciouss/samsung_p4note_kernel_backup/blob/da306e1846bb4b9682f46be1b23b05d6fbebffba/drivers/gpu/mali400/r3p2/mali/platform/pegasus-m400/exynos4_pmm.c#L88 > > + > > &hsotg { > > vusb_a-supply = <&ldo12_reg>; > > dr_mode = "peripheral"; > > > Best regards, > Krzysztof Kind Regards Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA179C433F5 for ; Mon, 31 Jan 2022 11:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P60X9vJ0l8O+UQfxiKWNKrZuspx7+dRJZHnQjAeNaXg=; b=YEtVJ5r6sdwmFi 9lbREPJRc8Gq7F7YzJRlfdMWHvEkRkOhGzyzukQ+4jW2ur44lOHO2bdz/qs7dbAiNNvxfOq0pYg01 /JLGkGj631NB1H01tMnAJoB2vVXcEhKbZzdn7qLoiGhAbWJcPF3/lZPxozYFBvowXGPtWOzGsAIcJ 0X1v+mQ0klCXBmAtiTxluovAHpnjXRdTjfPyBL277CHCb8i6ztyZVkrs555ed3LXnB2wfWvjvgGma oLyiRhFG87ir3QIfP/P0PLyzyivbNpzT3FogpZqrS3XCZH5BlVKg6ZrIZzzMSe1iBZYyEdzJ/yGAs f03xqUt++yDWwRVTGUxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEUyt-009AL1-23; Mon, 31 Jan 2022 11:36:23 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEUyq-009AKY-3C for linux-arm-kernel@lists.infradead.org; Mon, 31 Jan 2022 11:36:21 +0000 Received: by mail-ej1-x631.google.com with SMTP id me13so42228234ejb.12 for ; Mon, 31 Jan 2022 03:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m7A4pVSNJzjFxlNDUBif0ZSjzzxnHlIlhqH9+88MCVE=; b=nLY0dw1UbRO4nmzzwMHn2iPJSCTIQbwe0J1U5nCM53blsnqZM3dTetobnp/HM/KOIP WWnAAVCjZNvGMTy2kKFM0xg4+rZXzlZ2c5GSdvnS9L27TCy23ROd3dO/4xJPPAQGJ5EF uwr7alA8vx5rkSNppkJx/7LoGyNHO4/sMY596xAjHmJOEPJtm9bSLh31koHzzAnamm/D F/PWxFJyDAzdCww/4fXc1BoKmN36S/xxiclOylv8kKakNrw1Er8+zHVg/P3TkY2RpbSj 2AFGfKb/00Y5X53/MMTRCiw80oxYzAXB2Rdezy1o1AqgltWEaQPVpOU8I1AEPkxod69A ho5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m7A4pVSNJzjFxlNDUBif0ZSjzzxnHlIlhqH9+88MCVE=; b=gndErPFac3ffGFbnaGAWiEpL/iE9FC6wvrEsEHOsCQ41cZWC1Pu1k2NFZbeI9eXfNl VZXPDs3UqYOvpOtqHq0BqHyO8afBLiJFdVkzd0HbnzvGOJIB0i5ZlZsFlVbzO440VpQV 83PDm9ZoYeAaPmz3iYRNrVvz+XMyA+dhBjvJ8JJzVYep8n8q4T+yTP+TH918bHPqWVfc cCUqIN4pqHjGpwp9T0Ejg6IXNr+ssqkBvv2ynl66O2nwyQyUfjEF9Tfm+ZWlvgfBV6Bg uIYXDBwQrVMiKKEN24OPfyvc8Gj0MulhN+vYwzPA/msco/vOGSeVVUOm7Bcrsd6BSpoS cQ2g== X-Gm-Message-State: AOAM5338l0sxKOk5PpTHqm1uc2hDyn8twlrcVElpMQH6EJUq/QA6SDC6 srXP7j5X47iNMRAF7uGtFmc= X-Google-Smtp-Source: ABdhPJzNa2PvryNQRXW9SMrFZ8YqhBpr8tgJS1NdRci1rCS3yirNO2SWtbmF4gBWcUsjX5C7xw2BoA== X-Received: by 2002:a17:907:6eaa:: with SMTP id sh42mr16701737ejc.388.1643628978367; Mon, 31 Jan 2022 03:36:18 -0800 (PST) Received: from adroid (027-177-184-091.ip-addr.vsenet.de. [91.184.177.27]) by smtp.gmail.com with ESMTPSA id d2sm13343309ejw.70.2022.01.31.03.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 03:36:17 -0800 (PST) Date: Mon, 31 Jan 2022 12:36:15 +0100 From: Martin =?iso-8859-1?Q?J=FCcker?= To: Krzysztof Kozlowski Cc: Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Martin =?iso-8859-1?Q?J=FCcker?= Subject: Re: [PATCH] ARM: dts: add 533 MHz step to p4note GPU opp table Message-ID: <20220131113615.GA4916@adroid> References: <20220129221452.GA36524@adroid> <131c9bd9-b035-8a75-ca27-f9c2b3993566@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <131c9bd9-b035-8a75-ca27-f9c2b3993566@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_033620_173044_41CF2AD5 X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 31, 2022 at 09:54:00AM +0100, Krzysztof Kozlowski wrote: > On 29/01/2022 23:14, Martin J=FCcker wrote: > > The p4note devices support 533 MHz GPU speed, so let's make use of it. > > = > = > If there is going to be resend, please add prefix "exynos:" in subject. > Just like other commits (git log --oneline arch/arm/boot/dts/exynos*). > = Okay. > > Signed-off-by: Martin J=FCcker > > --- > > arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > = > > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/d= ts/exynos4412-p4note.dtsi > > index 4ae6eb3091c4..d277b2337ae0 100644 > > --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi > > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi > > @@ -355,6 +355,13 @@ &gpu { > > status =3D "okay"; > > }; > > = > > +&gpu_opp_table { > > + opp-533000000 { > > + opp-hz =3D /bits/ 64 <533000000>; > > + opp-microvolt =3D <1075000>; > > + }; > > +}; > = > This looks like Exynos4412 Prime. Please check also CPU frequencies and > if they match, just include exynos4412-prime.dtsi (like Odroid U3). > = I thought so as well, but unfortunately it's not. The chip id is 0xe4412211 and according to the vendor kernel, the prime version would need to have the last two digits being 0x20 or higher. See: https://github.com/Viciouss/samsung_p4note_kernel_backup/blob/da306e1846bb4= b9682f46be1b23b05d6fbebffba/arch/arm/mach-exynos/cpufreq-4x12.c#L619 On the other hand, this kernel has the 533 MHz step unlocked for all versions: https://github.com/Viciouss/samsung_p4note_kernel_backup/blob/da306e1846bb4= b9682f46be1b23b05d6fbebffba/drivers/gpu/mali400/r3p2/mali/platform/pegasus-= m400/exynos4_pmm.c#L88 > > + > > &hsotg { > > vusb_a-supply =3D <&ldo12_reg>; > > dr_mode =3D "peripheral"; > = > = > Best regards, > Krzysztof Kind Regards Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel