From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Peter Xu" <peterx@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 2/4] mm/gup: clean up follow_pfn_pte() slightly
Date: Mon, 31 Jan 2022 09:36:49 -0400 [thread overview]
Message-ID: <20220131133649.GX8034@ziepe.ca> (raw)
In-Reply-To: <20220131051752.447699-3-jhubbard@nvidia.com>
On Sun, Jan 30, 2022 at 09:17:50PM -0800, John Hubbard wrote:
> Regardless of any FOLL_* flags, get_user_pages() and its variants should
> handle PFN-only entries by stopping early, if the caller expected
> **pages to be filled in.
>
> This makes for a more reliable API, as compared to the previous approach
> of skipping over such entries (and thus leaving them silently
> unwritten).
>
> Cc: Peter Xu <peterx@redhat.com>
> Suggested-by: Jason Gunthorpe <jgg@ziepe.ca>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> mm/gup.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
I still think it should be squashed into the previous path, but
otherwise
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2022-01-31 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 5:17 [PATCH 0/4] mm/gup: some cleanups John Hubbard
2022-01-31 5:17 ` [PATCH 1/4] mm: Fix invalid page pointer returned with FOLL_PIN gups John Hubbard
2022-02-02 14:04 ` Christoph Hellwig
2022-01-31 5:17 ` [PATCH 2/4] mm/gup: clean up follow_pfn_pte() slightly John Hubbard
2022-01-31 13:36 ` Jason Gunthorpe [this message]
2022-01-31 5:17 ` [PATCH 3/4] mm/gup: remove unused pin_user_pages_locked() John Hubbard
2022-01-31 14:06 ` David Hildenbrand
2022-01-31 14:43 ` Jason Gunthorpe
2022-02-02 14:05 ` Christoph Hellwig
2022-01-31 5:17 ` [PATCH 4/4] mm/gup: remove get_user_pages_locked() John Hubbard
2022-01-31 12:05 ` Jan Kara
2022-01-31 20:01 ` John Hubbard
2022-01-31 13:36 ` Jason Gunthorpe
2022-01-31 20:01 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131133649.GX8034@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.