From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH V2 2/2] nvmet: allow bdev in buffered_io mode
Date: Tue, 1 Feb 2022 09:05:41 +0100 [thread overview]
Message-ID: <20220201080541.GA29678@lst.de> (raw)
In-Reply-To: <20220128085148.11638-3-chaitanyak@nvidia.com>
On Fri, Jan 28, 2022 at 12:51:48AM -0800, Chaitanya Kulkarni wrote:
> + if (ns->buffered_io)
> + return -ENOTBLK;
Maybe add a comment here that we want to force a fallback to the file
backend for buffered I/O here as this check on it's own isn't totally
obvious.
Otherwise the series looks good to me.
next prev parent reply other threads:[~2022-02-01 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 8:51 [PATCH V2 0/2] nvmet: add buffered_io support for bdev-ns Chaitanya Kulkarni
2022-01-28 8:51 ` [PATCH V2 1/2] nvmet: use i_size_read() to set size for file-ns Chaitanya Kulkarni
2022-01-28 8:51 ` [PATCH V2 2/2] nvmet: allow bdev in buffered_io mode Chaitanya Kulkarni
2022-02-01 8:05 ` Christoph Hellwig [this message]
2022-02-02 6:49 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201080541.GA29678@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.