From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 1/9] staging: r8188eu: ExternalPA is read-only
Date: Tue, 1 Feb 2022 09:42:51 +0100 [thread overview]
Message-ID: <20220201084259.7497-2-straube.linux@gmail.com> (raw)
In-Reply-To: <20220201084259.7497-1-straube.linux@gmail.com>
The variable ExternalPA in struct hal_data_8188e is never set.
It stays at the default value 0. Remove it and remove related
dead code.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 3 ---
drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
index d10a6cc2d4ab..9b06a23df2ac 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
@@ -99,9 +99,6 @@ rtl8188e_PHY_RF6052SetCckTxPower(
TxAGC[idx1] =
pPowerlevel[idx1] | (pPowerlevel[idx1] << 8) |
(pPowerlevel[idx1] << 16) | (pPowerlevel[idx1] << 24);
- /* 2010/10/18 MH For external PA module. We need to limit power index to be less than 0x20. */
- if (TxAGC[idx1] > 0x20 && pHalData->ExternalPA)
- TxAGC[idx1] = 0x20;
}
} else {
for (idx1 = RF_PATH_A; idx1 <= RF_PATH_B; idx1++) {
diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index a24cdbfa83de..2de7c0464411 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -181,7 +181,6 @@ struct hal_data_8188e {
u32 MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16];
u8 CrystalCap;
- u8 ExternalPA;
u32 AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */
--
2.34.1
next prev parent reply other threads:[~2022-02-01 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 8:42 [PATCH 0/9] staging: r8188eu: hal_data_8188e cleanups Michael Straube
2022-02-01 8:42 ` Michael Straube [this message]
2022-02-01 8:42 ` [PATCH 2/9] staging: r8188eu: remove PGMaxGroup from struct hal_data_8188e Michael Straube
2022-02-01 8:42 ` [PATCH 3/9] staging: r8188eu: remove ReceiveConfig " Michael Straube
2022-02-01 8:42 ` [PATCH 4/9] staging: r8188eu: BasicRateSet is set but never used Michael Straube
2022-02-01 8:42 ` [PATCH 5/9] staging: r8188eu: remove UsbTxAggDescNum from struct hal_data_8188e Michael Straube
2022-02-01 8:42 ` [PATCH 6/9] staging: r8188eu: remove UsbTxAggMode " Michael Straube
2022-02-01 8:42 ` [PATCH 7/9] staging: r8188eu: remove UsbRxAggMode " Michael Straube
2022-02-01 8:42 ` [PATCH 8/9] staging: r8188eu: remove UsbRxAggBlock* " Michael Straube
2022-02-01 8:42 ` [PATCH 9/9] staging: r8188eu: remove UsbRxAggPage* " Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201084259.7497-2-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.