From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7000DC433F5 for ; Wed, 2 Feb 2022 05:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbiBBFGo (ORCPT ); Wed, 2 Feb 2022 00:06:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbiBBFGg (ORCPT ); Wed, 2 Feb 2022 00:06:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E91C06173E for ; Tue, 1 Feb 2022 21:06:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB4806171B for ; Wed, 2 Feb 2022 05:06:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13BBBC340EF; Wed, 2 Feb 2022 05:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643778395; bh=EgYMh5oTAtjmn/oeOeD0pSp1VBioVPevjDwulnSB6Wg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VRLm76vmkBMi53LA/AhevabFRS47fg69tumtf50C9fg/hdEf2LvgBHx1cb5N6Gn+z 6Gkpmis13SXJXaeVwW+COuet3zlEUkliRJq2x9uVSuYx6XuCskZP+6S33NvryXV5xC lgh8ek5LdXYVVyNNyFRekcUKYI7eAxUYHICTDnVoFA1m1ena187wc3NUwbWJBI6XjU izWoWBxh3pqk7jcBNWq6aXIibf84i9dgHNU+AEdt2lliRgooUYXv8e852EMcNjIkzl gzT7V3zftSlvpM+jrIdAliIY9tkBgAH+AgybEA1UqEQpoXJQjS8CX0+tExmugmVEZ0 hsZn6EuXbgFvQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Roi Dayan , Oz Shlomo , Saeed Mahameed Subject: [net 06/18] net/mlx5e: TC, Reject rules with forward and drop actions Date: Tue, 1 Feb 2022 21:03:52 -0800 Message-Id: <20220202050404.100122-7-saeed@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220202050404.100122-1-saeed@kernel.org> References: <20220202050404.100122-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan Such rules are redundant but allowed and passed to the driver. The driver does not support offloading such rules so return an error. Fixes: 03a9d11e6eeb ("net/mlx5e: Add TC drop and mirred/redirect action parsing for SRIOV offloads") Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 671f76c350db..4c6e3c26c1ab 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -3191,6 +3191,12 @@ actions_match_supported(struct mlx5e_priv *priv, return false; } + if (!(~actions & + (MLX5_FLOW_CONTEXT_ACTION_FWD_DEST | MLX5_FLOW_CONTEXT_ACTION_DROP))) { + NL_SET_ERR_MSG_MOD(extack, "Rule cannot support forward+drop action"); + return false; + } + if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR && actions & MLX5_FLOW_CONTEXT_ACTION_DROP) { NL_SET_ERR_MSG_MOD(extack, "Drop with modify header action is not supported"); -- 2.34.1