From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] staging: r8188eu: Fix out-of-bounds error in
Date: Wed, 2 Feb 2022 09:47:21 +0300 [thread overview]
Message-ID: <20220202064721.GT1951@kadam> (raw)
In-Reply-To: <20220202052741.GA238470@embeddedor>
Please don't put "Fix out-of-bounds error" when it's not a bug. Change
"Fix" to "Silence" and "error" to "warning". Or just say:
staging: r8188eu: Clean up flex array usage ndis_802_11_var_ie
On Tue, Feb 01, 2022 at 11:27:41PM -0600, Gustavo A. R. Silva wrote:
> HT_caps_handler()
> Reply-To:
Your email headers got messed up.
Otherwise it's fine. I guess to me I would prefer just one line of
sample error message instead of the complete one pager. Please resend
with fixed email headers and add my tag.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2022-02-02 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 5:27 [PATCH][next] staging: r8188eu: Fix out-of-bounds error in Gustavo A. R. Silva
2022-02-02 6:47 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202064721.GT1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.