From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A778CC433F5 for ; Wed, 2 Feb 2022 22:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347803AbiBBWKJ (ORCPT ); Wed, 2 Feb 2022 17:10:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347799AbiBBWKJ (ORCPT ); Wed, 2 Feb 2022 17:10:09 -0500 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E73C06173B; Wed, 2 Feb 2022 14:10:09 -0800 (PST) Received: by mail-qk1-x72c.google.com with SMTP id 200so989560qki.2; Wed, 02 Feb 2022 14:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=fcP42zsjJKBRLsCCLNxeBAvGoAUH+RgY1jYrpOhhT8bMHr7+15EWYSucDQfP1oORdR v8va2D+TIvGEUfFpYyk+KAAnpvrPj2Do2UURxQqDM2NZ0yrVKHV/Tmvmi8VnHPqEl5Sj FzsjYO1CSUmsISBtPa5x3zIEsUBOu9RZDDuPyg2QqPpe+3i2ouYdl1b7XJc+7Yz287oe n4Ll3sdxxGbRuNPqe8Va40e5cgmVlDZI5fIN6fBWjGY94knmRKOKljCldyrgDLu4eqFI 61yZGnSZcmCnvpc5Ppek75k/hWgHufZ8NwnxWp4bgKiaLrzdRDurexHwqhp4Nqyni8AG h/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=C65pH2rY/pHA4/UDlbE1AUvm+emU4zTl6GaizZbzr+Fh/rvc/8XlEKFYQ/8VxXMcjQ BmtafWC6iCpmqVuiZtDjXjFUlkCPyp9tYtOr4OTczSuIQI4bm2uluGhfuuO/K+vWkAYG cdnZwllIAFIdM5tutCsBgVIsiDA6SEhg8zPWgi5uBrsMtvaswkVj1GZIK6OQUjqh4n+L m7hxSWM89ijjSe8fBzEgH6ZaObRsv5QxVZg8ZNOpJ2x7SQKVPgu6sBcelO2oGLzmfYmN YuFCxLVN8k/DsnM62FtrFMLgTm0iTVpinTdyqXeYETiQNKIF5rQ33xURA2TiDZUYxWTo jwVQ== X-Gm-Message-State: AOAM532SVVHVa1PIRrbf07l6oATCpnGr0hBEKCAMYp8zxgLDbbS+zNWj t7vHb6vsHErwe1lSfKyiSQ== X-Google-Smtp-Source: ABdhPJwRpKyRhMilcGtomGensbv6thBpUXpxVK7cAkdNeBk0lqsREJF6QVbIyABhwvxgVYCy4DCMsQ== X-Received: by 2002:a37:4648:: with SMTP id t69mr21000172qka.702.1643839808031; Wed, 02 Feb 2022 14:10:08 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id o13sm7298868qtv.36.2022.02.02.14.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 14:10:07 -0800 (PST) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:c4e6:e49c:6958:ac58]) by serve.minyard.net (Postfix) with ESMTPSA id 68539181297; Wed, 2 Feb 2022 22:10:06 +0000 (UTC) Date: Wed, 2 Feb 2022 16:10:05 -0600 From: Corey Minyard To: "Verdun, Jean-Marie" Cc: "Hawkins, Nick" , Mark Rutland , Wang Kefeng , Vignesh Raghavendra , Sam Ravnborg , "Rafael J. Wysocki" , David Airlie , Linus Walleij , Amit Kucheria , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Thierry Reding , "linux-mtd@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Miquel Raynal , "netdev@vger.kernel.org" , Lee Jones , Ard Biesheuvel , Stanislav Jakubek , Hao Fang , Krzysztof Kozlowski , Richard Weinberger , Bartosz Golaszewski , Daniel Lezcano , Russell King , "linux-pwm@vger.kernel.org" , "linux-serial@vger.kernel.org" , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "openipmi-developer@lists.sourceforge.net" , Jakub Kicinski , Zhang Rui , Masahiro Yamada , Guenter Roeck , "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Arnd Bergmann , Anshuman Khandual , "linux-gpio@vger.kernel.org" , "soc@kernel.org" , Rob Herring , Lukas Bulwahn , Thomas Gleixner , Wim Van Sebroeck , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-pm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "Russell King (Oracle)" , "linux-spi@vger.kernel.org" , Mark Brown , Daniel Vetter , Marc Zyngier , Shawn Guo , "David S. Miller" Subject: Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT Message-ID: <20220202221005.GD2091156@minyard.net> Reply-To: minyard@acm.org References: <20220202165315.18282-1-nick.hawkins@hpe.com> <20220202175635.GC2091156@minyard.net> <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Feb 02, 2022 at 06:14:57PM +0000, Verdun, Jean-Marie wrote: > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in individual patches. The way it is it can't be reviewed in any > > sane manner. > > > -corey > > Thanks for your feedback. We are getting a little bit lost here, as our plan was to submit initial > > - bindings > - dts for SoC and 1 board > - initial platform init code > > Then drivers code avoiding to send many dts updates which might complexify the review. We wanted to send all drivers code to relevant reviewers by tomorrow. > > So, what you are asking ( do not worry I am not trying to negotiate, I just want to avoid English misunderstandings as I am French) is to send per driver > > - binding > - dts update > - driver code > > For each driver through different submission (with each of them containing the 3 associated parts) ? Arnd gave an excellent explaination for this. To be clear, you need to split out changes to individual subsystems and submit those to the maintainers for that subsystem and not send them to everyone. That way you reduce sending emails to people who don't need to see them. Once you have a set of patches for a subsystem, you can submit them as one set. That is generally preferred. The "git send-email" or "git format-patch" tools are generally what we use, they let you compose a header message where you can give an overall explaination, then it sends the individual changes as followup messages to the header message. -corey > > What shall be the initial one in our case as we are introducing a platform ? An empty dts infrastructure and then we make it grow one step at a time ? > > vejmarie > >  > > > > _______________________________________________ > Openipmi-developer mailing list > Openipmi-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openipmi-developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80273C433F5 for ; Wed, 2 Feb 2022 22:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pkaa761VNERB3ZO4kcaBM2ZBF9qIWkuQI0GIonf/u60=; b=fSFpfGYgmXijXF ZQH/oycyVkf8MWw6wXt3Q3w7s6Zt7CHrrCDfmN3J/5fVYMkleFi+lCVf1wzy3eitWfe7aYpoXlALM pw5CKY5cH8wo0xGzIpXOPxmxeDrGMYZJVaI+Jp5xx6RZBSNooM3fL0CS6eWwF+rofqQ8Qyxw2wJfa pR9/zFAp3SzWwFsbIfSpqj+qTbCPu9shw7psNCwRnOGDA44617IMpSfG7R2bMohxiS97oNY2wKTOy K6yio7y8OsC3TFyqORJUYMa74ng7qDJ+dglKxN8w5rVSEsqYm9YFd84rt1xtPzlelwAVWHv1CBVj4 RCk1c5A8EDiORwhfji2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFNpP-00Gyxz-0s; Wed, 02 Feb 2022 22:10:15 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFNpK-00GywF-I9; Wed, 02 Feb 2022 22:10:12 +0000 Received: by mail-qk1-x730.google.com with SMTP id g145so977976qke.3; Wed, 02 Feb 2022 14:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=fcP42zsjJKBRLsCCLNxeBAvGoAUH+RgY1jYrpOhhT8bMHr7+15EWYSucDQfP1oORdR v8va2D+TIvGEUfFpYyk+KAAnpvrPj2Do2UURxQqDM2NZ0yrVKHV/Tmvmi8VnHPqEl5Sj FzsjYO1CSUmsISBtPa5x3zIEsUBOu9RZDDuPyg2QqPpe+3i2ouYdl1b7XJc+7Yz287oe n4Ll3sdxxGbRuNPqe8Va40e5cgmVlDZI5fIN6fBWjGY94knmRKOKljCldyrgDLu4eqFI 61yZGnSZcmCnvpc5Ppek75k/hWgHufZ8NwnxWp4bgKiaLrzdRDurexHwqhp4Nqyni8AG h/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=DHyrYY6R0MRmbv6zxl5LafCo+YORF8sGqDF8xqLZmlQsJDh4YGSMHfua2ID6qgsGS1 ASxEoDJ4INIxapqruIjD0v9PkH5azOfFDoBdzwKwgBHU/bLNkVuwb4ek8HYFGLe+doxP rFGl9CC6SCW71bZxlsC5uTs1/XuQGS8hI7ve1GTYMV+bALicnDWu3ZdwqhXt4WmX4QIO mZ4HGbyqS/SNUsfywT0yrfJitf8LiLLfWT5Ox/5f8lVdfHEf0pAzrd5Jb+WgXocgEwmz sCcHEwcYZZPBuxz9cuSY1fe5OqeLGr3hluMy0CuQL0gEnJqxU6jtzZ4MeHL26pTHjr7y Z7XA== X-Gm-Message-State: AOAM532HvEbStsy84wgZxiQVBbKnS3M6FZozi07GyXrxEWClfGjHpcz/ 75F3Y4XzEf5WVDJtpfJWhg== X-Google-Smtp-Source: ABdhPJwRpKyRhMilcGtomGensbv6thBpUXpxVK7cAkdNeBk0lqsREJF6QVbIyABhwvxgVYCy4DCMsQ== X-Received: by 2002:a37:4648:: with SMTP id t69mr21000172qka.702.1643839808031; Wed, 02 Feb 2022 14:10:08 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id o13sm7298868qtv.36.2022.02.02.14.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 14:10:07 -0800 (PST) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:c4e6:e49c:6958:ac58]) by serve.minyard.net (Postfix) with ESMTPSA id 68539181297; Wed, 2 Feb 2022 22:10:06 +0000 (UTC) Date: Wed, 2 Feb 2022 16:10:05 -0600 From: Corey Minyard To: "Verdun, Jean-Marie" Cc: "Hawkins, Nick" , Mark Rutland , Wang Kefeng , Vignesh Raghavendra , Sam Ravnborg , "Rafael J. Wysocki" , David Airlie , Linus Walleij , Amit Kucheria , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Thierry Reding , "linux-mtd@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Miquel Raynal , "netdev@vger.kernel.org" , Lee Jones , Ard Biesheuvel , Stanislav Jakubek , Hao Fang , Krzysztof Kozlowski , Richard Weinberger , Bartosz Golaszewski , Daniel Lezcano , Russell King , "linux-pwm@vger.kernel.org" , "linux-serial@vger.kernel.org" , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "openipmi-developer@lists.sourceforge.net" , Jakub Kicinski , Zhang Rui , Masahiro Yamada , Guenter Roeck , "devicetree@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Arnd Bergmann , Anshuman Khandual , "linux-gpio@vger.kernel.org" , "soc@kernel.org" , Rob Herring , Lukas Bulwahn , Thomas Gleixner , Wim Van Sebroeck , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-pm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "Russell King (Oracle)" , "linux-spi@vger.kernel.org" , Mark Brown , Daniel Vetter , Marc Zyngier , Shawn Guo , "David S. Miller" Subject: Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT Message-ID: <20220202221005.GD2091156@minyard.net> References: <20220202165315.18282-1-nick.hawkins@hpe.com> <20220202175635.GC2091156@minyard.net> <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_141010_634500_4104F651 X-CRM114-Status: GOOD ( 28.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gV2VkLCBGZWIgMDIsIDIwMjIgYXQgMDY6MTQ6NTdQTSArMDAwMCwgVmVyZHVuLCBKZWFuLU1h cmllIHdyb3RlOgo+ID4gVGhpcyBpcyBmYXIgdG9vIGJpZyBmb3IgYSBzaW5nbGUgcGF0Y2guICBJ dCBuZWVkcyB0byBiZSBicm9rZW4gaW50bwo+ID4gZnVuY3Rpb25hbCBjaHVua3MgdGhhdCBjYW4g YmUgcmV2aWV3ZWQgaW5kaXZpZHVhbGx5LiAgRWFjaCBkcml2ZXIgYW5kCj4gPiBlYWNoIGRldmlj ZSB0cmVlIGNoYW5nZSBhbG9uZyB3aXRoIGl0J3MgYWNjb21wYW55aW5nIGNvZGUgbmVlZCB0byBi ZQo+ID4gZG9uZSBpbiBpbmRpdmlkdWFsIHBhdGNoZXMuICBUaGUgd2F5IGl0IGlzIGl0IGNhbid0 IGJlIHJldmlld2VkIGluIGFueQo+ID4gc2FuZSBtYW5uZXIuCj4gCj4gPiAtY29yZXkKPiAKPiBU aGFua3MgZm9yIHlvdXIgZmVlZGJhY2suIFdlIGFyZSBnZXR0aW5nIGEgbGl0dGxlIGJpdCBsb3N0 IGhlcmUsIGFzIG91ciBwbGFuIHdhcyB0byBzdWJtaXQgaW5pdGlhbAo+IAo+IC0gYmluZGluZ3MK PiAtIGR0cyBmb3IgU29DIGFuZCAxIGJvYXJkCj4gLSBpbml0aWFsIHBsYXRmb3JtIGluaXQgY29k ZQo+IAo+IFRoZW4gZHJpdmVycyBjb2RlIGF2b2lkaW5nIHRvIHNlbmQgbWFueSBkdHMgdXBkYXRl cyB3aGljaCBtaWdodCBjb21wbGV4aWZ5IHRoZSByZXZpZXcuIFdlIHdhbnRlZCB0byBzZW5kIGFs bCBkcml2ZXJzIGNvZGUgdG8gcmVsZXZhbnQgcmV2aWV3ZXJzIGJ5IHRvbW9ycm93Lgo+IAo+IFNv LCB3aGF0IHlvdSBhcmUgYXNraW5nICggZG8gbm90IHdvcnJ5IEkgYW0gbm90IHRyeWluZyB0byBu ZWdvdGlhdGUsIEkganVzdCB3YW50IHRvIGF2b2lkIEVuZ2xpc2ggbWlzdW5kZXJzdGFuZGluZ3Mg YXMgSSBhbSBGcmVuY2gpIGlzIHRvIHNlbmQgcGVyIGRyaXZlcgo+IAo+IC0gYmluZGluZwo+IC0g ZHRzIHVwZGF0ZQo+IC0gZHJpdmVyIGNvZGUKPiAKPiBGb3IgZWFjaCBkcml2ZXIgdGhyb3VnaCBk aWZmZXJlbnQgc3VibWlzc2lvbiAod2l0aCBlYWNoIG9mIHRoZW0gY29udGFpbmluZyB0aGUgMyBh c3NvY2lhdGVkIHBhcnRzKSA/CgpBcm5kIGdhdmUgYW4gZXhjZWxsZW50IGV4cGxhaW5hdGlvbiBm b3IgdGhpcy4KClRvIGJlIGNsZWFyLCB5b3UgbmVlZCB0byBzcGxpdCBvdXQgY2hhbmdlcyB0byBp bmRpdmlkdWFsIHN1YnN5c3RlbXMgYW5kCnN1Ym1pdCB0aG9zZSB0byB0aGUgbWFpbnRhaW5lcnMg Zm9yIHRoYXQgc3Vic3lzdGVtIGFuZCBub3Qgc2VuZCB0aGVtIHRvCmV2ZXJ5b25lLiAgVGhhdCB3 YXkgeW91IHJlZHVjZSBzZW5kaW5nIGVtYWlscyB0byBwZW9wbGUgd2hvIGRvbid0IG5lZWQKdG8g c2VlIHRoZW0uCgpPbmNlIHlvdSBoYXZlIGEgc2V0IG9mIHBhdGNoZXMgZm9yIGEgc3Vic3lzdGVt LCB5b3UgY2FuIHN1Ym1pdCB0aGVtIGFzIG9uZQpzZXQuICBUaGF0IGlzIGdlbmVyYWxseSBwcmVm ZXJyZWQuICBUaGUgImdpdCBzZW5kLWVtYWlsIiBvciAiZ2l0CmZvcm1hdC1wYXRjaCIgdG9vbHMg YXJlIGdlbmVyYWxseSB3aGF0IHdlIHVzZSwgdGhleSBsZXQgeW91IGNvbXBvc2UgYQpoZWFkZXIg bWVzc2FnZSB3aGVyZSB5b3UgY2FuIGdpdmUgYW4gb3ZlcmFsbCBleHBsYWluYXRpb24sIHRoZW4g aXQgc2VuZHMKdGhlIGluZGl2aWR1YWwgY2hhbmdlcyBhcyBmb2xsb3d1cCBtZXNzYWdlcyB0byB0 aGUgaGVhZGVyIG1lc3NhZ2UuCgotY29yZXkKCj4gCj4gV2hhdCBzaGFsbCBiZSB0aGUgaW5pdGlh bCBvbmUgaW4gb3VyIGNhc2UgYXMgd2UgYXJlIGludHJvZHVjaW5nIGEgcGxhdGZvcm0gPyBBbiBl bXB0eSBkdHMgaW5mcmFzdHJ1Y3R1cmUgYW5kIHRoZW4gd2UgbWFrZSBpdCBncm93IG9uZSBzdGVw IGF0IGEgdGltZSA/Cj4gCj4gdmVqbWFyaWUKPiAKPiDvu78KPiAgCj4gCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBPcGVuaXBtaS1kZXZlbG9w ZXIgbWFpbGluZyBsaXN0Cj4gT3BlbmlwbWktZGV2ZWxvcGVyQGxpc3RzLnNvdXJjZWZvcmdlLm5l dAo+IGh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL29wZW5pcG1p LWRldmVsb3BlcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E21EFC433EF for ; Wed, 2 Feb 2022 23:17:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F226B10E65B; Wed, 2 Feb 2022 23:17:36 +0000 (UTC) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86EF910E162 for ; Wed, 2 Feb 2022 22:10:09 +0000 (UTC) Received: by mail-qk1-x734.google.com with SMTP id b22so933667qkk.12 for ; Wed, 02 Feb 2022 14:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=fcP42zsjJKBRLsCCLNxeBAvGoAUH+RgY1jYrpOhhT8bMHr7+15EWYSucDQfP1oORdR v8va2D+TIvGEUfFpYyk+KAAnpvrPj2Do2UURxQqDM2NZ0yrVKHV/Tmvmi8VnHPqEl5Sj FzsjYO1CSUmsISBtPa5x3zIEsUBOu9RZDDuPyg2QqPpe+3i2ouYdl1b7XJc+7Yz287oe n4Ll3sdxxGbRuNPqe8Va40e5cgmVlDZI5fIN6fBWjGY94knmRKOKljCldyrgDLu4eqFI 61yZGnSZcmCnvpc5Ppek75k/hWgHufZ8NwnxWp4bgKiaLrzdRDurexHwqhp4Nqyni8AG h/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Rr5xR3phcMmOtciTLGMao2x+J3LzUpf33KP5PgsG6mw=; b=z/Q2Z87ZRLZtc/rPC2K9PD5sYMWndkOZZZPy+AHS2Vs0iNeavwroVVLQCjjO0Sjixh Oz3/O3vskQqDmma1ZbLLt1x/1UftgRxr+iohmXXci/VR8tN7jrC9qNbo8UTFie7PbHd3 vkEqz6FkODIu4zijnJmxjnFyBt2uG0P4ka5LHUN2GdRmAU1by0dRLYKd5Tu454lc1k/A SqFzlYpUX9AaKHv0CyyfwLIimYE7FwTRRaKbSFGtMv6Ef5+fOrHRhw1t80oIMsiCo/d2 u55U4BwElp3uib6i+KB/GTAR9Vyyj/c96hJscLJTZMiOCJxGzqLMKUbZB0dRDeXR9ZpR I5bA== X-Gm-Message-State: AOAM532/B8yBMLm9uWwgdHHu/nY5TlwdAZXP/UD37LR+vlbYYJFYzY3u hbIZojPADi9uIHeCL+JJig== X-Google-Smtp-Source: ABdhPJwRpKyRhMilcGtomGensbv6thBpUXpxVK7cAkdNeBk0lqsREJF6QVbIyABhwvxgVYCy4DCMsQ== X-Received: by 2002:a37:4648:: with SMTP id t69mr21000172qka.702.1643839808031; Wed, 02 Feb 2022 14:10:08 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id o13sm7298868qtv.36.2022.02.02.14.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 14:10:07 -0800 (PST) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:c4e6:e49c:6958:ac58]) by serve.minyard.net (Postfix) with ESMTPSA id 68539181297; Wed, 2 Feb 2022 22:10:06 +0000 (UTC) Date: Wed, 2 Feb 2022 16:10:05 -0600 From: Corey Minyard To: "Verdun, Jean-Marie" Subject: Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT Message-ID: <20220202221005.GD2091156@minyard.net> References: <20220202165315.18282-1-nick.hawkins@hpe.com> <20220202175635.GC2091156@minyard.net> <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3E9905F2-1576-4826-ADC2-85796DE0F4DB@hpe.com> X-Mailman-Approved-At: Wed, 02 Feb 2022 23:17:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Mark Rutland , Wang Kefeng , Vignesh Raghavendra , Sam Ravnborg , "Rafael J. Wysocki" , David Airlie , Amit Kucheria , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , Thierry Reding , "linux-mtd@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Miquel Raynal , Shawn Guo , Lee Jones , Ard Biesheuvel , Stanislav Jakubek , "David S. Miller" , Marc Zyngier , Hao Fang , Krzysztof Kozlowski , Richard Weinberger , Bartosz Golaszewski , Daniel Lezcano , Russell King , "linux-serial@vger.kernel.org" , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jakub Kicinski , Zhang Rui , Guenter Roeck , "linux-pwm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Arnd Bergmann , Anshuman Khandual , "linux-gpio@vger.kernel.org" , "soc@kernel.org" , Rob Herring , "Hawkins, Nick" , Lukas Bulwahn , "openipmi-developer@lists.sourceforge.net" , Wim Van Sebroeck , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , Mark Brown , Thomas Gleixner , Greg Kroah-Hartman , "Russell King \(Oracle\)" , Masahiro Yamada Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 02, 2022 at 06:14:57PM +0000, Verdun, Jean-Marie wrote: > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in individual patches. The way it is it can't be reviewed in any > > sane manner. > > > -corey > > Thanks for your feedback. We are getting a little bit lost here, as our plan was to submit initial > > - bindings > - dts for SoC and 1 board > - initial platform init code > > Then drivers code avoiding to send many dts updates which might complexify the review. We wanted to send all drivers code to relevant reviewers by tomorrow. > > So, what you are asking ( do not worry I am not trying to negotiate, I just want to avoid English misunderstandings as I am French) is to send per driver > > - binding > - dts update > - driver code > > For each driver through different submission (with each of them containing the 3 associated parts) ? Arnd gave an excellent explaination for this. To be clear, you need to split out changes to individual subsystems and submit those to the maintainers for that subsystem and not send them to everyone. That way you reduce sending emails to people who don't need to see them. Once you have a set of patches for a subsystem, you can submit them as one set. That is generally preferred. The "git send-email" or "git format-patch" tools are generally what we use, they let you compose a header message where you can give an overall explaination, then it sends the individual changes as followup messages to the header message. -corey > > What shall be the initial one in our case as we are introducing a platform ? An empty dts infrastructure and then we make it grow one step at a time ? > > vejmarie > >  > > > > _______________________________________________ > Openipmi-developer mailing list > Openipmi-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openipmi-developer