From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4261100885771311183==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records Date: Thu, 03 Feb 2022 14:34:49 +0800 Message-ID: <202202031436.8ZZBmoEC-lkp@intel.com> In-Reply-To: <20220202235323.23929-25-casey@schaufler-ca.com> List-Id: --===============4261100885771311183== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Casey, I love your patch! Perhaps something to improve: [auto build test WARNING on pcmoore-audit/next] [also build test WARNING on nf-next/master nf/master linus/master v5.17-rc2] [cannot apply to jmorris-security/next-testing] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/integrity-= disassociate-ima_filter_rule-from-security_audit_rule/20220203-085302 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git n= ext config: arc-randconfig-r043-20220131 (https://download.01.org/0day-ci/archi= ve/20220203/202202031436.8ZZBmoEC-lkp(a)intel.com/config) compiler: arc-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/25bd76f704528c053f7260a22= eeecbd214b11982 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Casey-Schaufler/integrity-disassoc= iate-ima_filter_rule-from-security_audit_rule/20220203-085302 git checkout 25bd76f704528c053f7260a22eeecbd214b11982 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): kernel/audit.c:1804:14: warning: no previous prototype for 'audit_serial= ' [-Wmissing-prototypes] 1804 | unsigned int audit_serial(void) | ^~~~~~~~~~~~ kernel/audit.c: In function 'audit_log_vformat': kernel/audit.c:1954:9: warning: function 'audit_log_vformat' might be a = candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=3Dformat] 1954 | len =3D vsnprintf(skb_tail_pointer(skb), avail, fmt, arg= s); | ^~~ kernel/audit.c:1963:17: warning: function 'audit_log_vformat' might be a= candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=3Dformat] 1963 | len =3D vsnprintf(skb_tail_pointer(skb), avail, = fmt, args2); | ^~~ kernel/audit.c: At top level: >> kernel/audit.c:2399:6: warning: no previous prototype for '__audit_log_e= nd' [-Wmissing-prototypes] 2399 | void __audit_log_end(struct audit_buffer *ab) | ^~~~~~~~~~~~~~~ vim +/__audit_log_end +2399 kernel/audit.c 2389 = 2390 /** 2391 * __audit_log_end - end one audit record 2392 * @ab: the audit_buffer 2393 * 2394 * We can not do a netlink send inside an irq context because it blo= cks (last 2395 * arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is p= laced on a 2396 * queue and a kthread is scheduled to remove them from the queue ou= tside the 2397 * irq context. May be called in any context. 2398 */ > 2399 void __audit_log_end(struct audit_buffer *ab) 2400 { 2401 struct sk_buff *skb; 2402 struct nlmsghdr *nlh; 2403 = 2404 if (!ab) 2405 return; 2406 = 2407 if (audit_rate_check()) { 2408 skb =3D ab->skb; 2409 ab->skb =3D NULL; 2410 = 2411 /* setup the netlink header, see the comments in 2412 * kauditd_send_multicast_skb() for length quirks */ 2413 nlh =3D nlmsg_hdr(skb); 2414 nlh->nlmsg_len =3D skb->len - NLMSG_HDRLEN; 2415 = 2416 /* queue the netlink packet and poke the kauditd thread */ 2417 skb_queue_tail(&audit_queue, skb); 2418 wake_up_interruptible(&kauditd_wait); 2419 } else 2420 audit_log_lost("rate limit exceeded"); 2421 } 2422 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4261100885771311183==--