Re: [PATCH phy v3 2/5] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation

["Marek Behún" <kabel@kernel.org>]

On Wed, 2 Feb 2022 21:22:20 +0530
Vinod Koul <vkoul@kernel.org> wrote:

> > +	if (ret) {
> > +		dev_err(lane->dev, "Failed to lock SATA PLL\n");
> > +		return ret;
> > +	}
> > +
> > +	return 0;  
> 
> This can be:
>         ret = comphy_lane_reg_poll(lane, COMPHY_DIG_LOOPBACK_EN, ...);
>         if (ret)
>                 dev_err(...);
> 
>         return ret;

Ok, will change all such occurances in v4.


> > +	/*
> > +	 * 12. As long as DFE function needs to be enabled in any mode,
> > +	 * COMPHY register DFE_UPDATE_EN[5:0] shall be programmed to 0x3F
> > +	 * for real chip during COMPHY power on.  
> 
> Okay where is this step..?

As is written in rest of the comment, the value of DFE_UPDATE_EN is
0x3F already (after PHY reset, because it is default value of the
register), so this is not needed. I have changed the comment a little in
v4, but I would like to leave it here.

> > +	 * The step 14 exists (and empty) in the original initialization flow
> > +	 * obtained from the verification team. According to the functional
> > +	 * specification DFE_UPDATE_EN already has the default value 0x3F
> > +	 */

snip

> > +
> > +	/*
> > +	 * 14. [Simulation Only] should not be used for real chip.
> > +	 * By pass power up calibration by programming EXT_FORCE_CAL_DONE
> > +	 * (R02h[9]) to 1 to shorten COMPHY simulation time.
> > +	 */
> > +
> > +	/*
> > +	 * 15. [Simulation Only: should not be used for real chip]
> > +	 * Program COMPHY register FAST_DFE_TIMER_EN=1 to shorten RX training
> > +	 * simulation time.
> > +	 */  
> 
> can we skip Simulation Only comments?

ok, removed in v4 and subsequent steps renumbered

> > +static void
> > +mvebu_a3700_comphy_usb3_power_off(struct mvebu_a3700_comphy_lane *lane)
> > +{
> > +	/*
> > +	 * Currently the USB3 MAC sets the USB3 PHY to low state, so we do not
> > +	 * need to power off USB3 PHY again.
> > +	 */
> > +}  
> 
> lets drop the dummy and move this comment to caller..?

ok

will send v4 in a couple of minutes.

Thanks, Vinod.

Marek

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy