From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FCE2C433F5 for ; Fri, 4 Feb 2022 15:37:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C351983A10; Fri, 4 Feb 2022 16:37:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FJ0VHzmc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F15F9839FB; Fri, 4 Feb 2022 16:37:40 +0100 (CET) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F08DF83A2D for ; Fri, 4 Feb 2022 16:37:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id h16so5583593qvk.10 for ; Fri, 04 Feb 2022 07:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gAcJv6p3JFh+ineyEv13O/eRkNDwjg15VIFIi+Lu/Bw=; b=FJ0VHzmcUlYY1l5n/UZwvUUe6dpAjE48ksa5Q3Gpvl3+ypWXOYkx6OVGNbfawdB4P6 3ojWJMmL+WOvRBY6E+g7RyRttnNT3rZ2zjsyjjkcgXbBoCqjyHPi1fjIZeG+GnCDy10G BRQnAC+E3+atfat22akB/yRu/Gq9K2pjgKpTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gAcJv6p3JFh+ineyEv13O/eRkNDwjg15VIFIi+Lu/Bw=; b=opgzmTyIXkACIAdeG56WqYGTNyjvVktql97dYowUsSE6oTw4pusABIJhKfhofT4Z2k EwkPBNixFExQrsVXvahDc23+y00nwH+Yh/xZjxGbmV1iSo1R+TT1Z0ZsbhoZga4Ikeac gV/8J+ea6jyA7RGE1ToAxnqtkg6k2ERBoFWIhBTYbyds8NDd8fnhobpFl7ICoUWUrltO 7UdxJMTsSZ/UxoOaiVK/AnplOhHxL30EClKq/p7GvSLC60AIZH+vRCmsqeJoi1U1y2PL +4WSmIbfuZBSYp9mGlTJg+H0/UbS4th+y6dV2atGG/5xagxPEm2MURWtwjVsCO3oiEIa HvHw== X-Gm-Message-State: AOAM530ha19ZIYrze0KFF2YkEoOHb+axMq8bvT6yTwncp2BAIL/vNbOA WnzIdXHpXmZjOA3/WmBhFQO0ZRJEqCl9ng== X-Google-Smtp-Source: ABdhPJyNIAEU1NfjtKhO8XIglGQPsF5F5vSzHJ9MVPmEru3to+RSwIo8ix6TgIk4EDLYuCoizAIYIg== X-Received: by 2002:ad4:4ee9:: with SMTP id dv9mr2284213qvb.47.1643989054909; Fri, 04 Feb 2022 07:37:34 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id bp37sm1105341qkb.135.2022.02.04.07.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 07:37:34 -0800 (PST) Date: Fri, 4 Feb 2022 10:37:32 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD Message-ID: <20220204153732.GR7515@bill-the-cat> References: <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> <20220204105652.sluginmttbwgcwku@pali> <20220204134155.GP7515@bill-the-cat> <20220204135539.n24gfoh5nw3wzjw7@pali> <20220204140055.GQ7515@bill-the-cat> <20220204141310.lfbjvrqpct5y7stg@pali> <20220204153023.7oc5lyc5ageanveo@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ivrUthVTr0Ce7KDI" Content-Disposition: inline In-Reply-To: <20220204153023.7oc5lyc5ageanveo@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ivrUthVTr0Ce7KDI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 04, 2022 at 04:30:23PM +0100, Pali Roh=E1r wrote: > On Friday 04 February 2022 08:24:03 Simon Glass wrote: > > Hi Pali, > >=20 > > On Fri, 4 Feb 2022 at 07:13, Pali Roh=E1r wrote: > > > > > > On Friday 04 February 2022 09:00:55 Tom Rini wrote: > > > > On Fri, Feb 04, 2022 at 02:55:39PM +0100, Pali Roh=E1r wrote: > > > > > On Friday 04 February 2022 08:41:55 Tom Rini wrote: > > > > > > On Fri, Feb 04, 2022 at 11:56:52AM +0100, Pali Roh=E1r wrote: > > > > > > > On Thursday 03 February 2022 15:02:02 Simon Glass wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > On Thu, 3 Feb 2022 at 14:53, Tom Rini = wrote: > > > > > > > > > > > > > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > > > > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrot= e: > > > > > > > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Roh=E1= r wrote: > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > > > I would really appreciate if U-Boot test framework = starts printing > > > > > > > > > > > > deprecation warnings, instead of sending patches wh= ich directly drop > > > > > > > > > > > > support for some boards. > > > > > > > > > > > > > > > > > > > > > > > > There is absolutely no warning during building U-Bo= ot for RX-51 board > > > > > > > > > > > > that this board has not been converted to DM_KEYBOA= RD yet. > > > > > > > > > > > > > > > > > > > > > > Please send some patch that implements what you're wa= nting to see for > > > > > > > > > > > how to make the warnings more visible. I do agree th= e warning for > > > > > > > > > > > v2022.10 only showed up after the merge to -next once= v2022.01 came out, > > > > > > > > > > > but it's still a fairly long time to clean up the few= unconverted > > > > > > > > > > > boards. > > > > > > > > > > > > > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD chec= k isn't > > > > > > > > > > triggering for any boards. I'll look more. > > > > > > > > > > > > > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG= _KEYBOARD, so > > > > > > > > > didn't trigger the warning about migration. Every platf= orm that sets > > > > > > > > > CONFIG_KEYBOARD is migrated. I don't know how many other= platforms are > > > > > > > > > in the situation nokia_rx51 is in. Yanking out the legac= y code and > > > > > > > > > seeing what fails to build, and going from there is proba= bly the next > > > > > > > > > option. > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > > > > > As to your questoin, none that I know of. I sent a series t= o drop > > > > > > > > cfb_console which was how this used to work, although in fa= ct it > > > > > > > > hasn't worked for a while. The problem here seems to be tha= t this > > > > > > > > board was multiple migrations behind and so was not caught. > > > > > > > > > > > > > > It is not truth that cfb_console has not worked. This driver = is / was > > > > > > > working fine on n900 without any issues. > > > > > > > > > > > > Yes, it's such an old missed migration that there's no check fo= r it. > > > > > > > > > > > > > > We should be able to remove the migration check. > > > > > > > > > > > > > > > > Pali, just to explain from the other POV, I am finding it i= ncreasingly > > > > > > > > frustrating dealing with ad-hoc CONFIG options, old drivers= , etc. We > > > > > > > > really need to complete some of the migrations we started 6= years ago. > > > > > > > > > > > > > > > > Regards, > > > > > > > > Simon > > > > > > > > > > > > > > Well, I see and understand you. But as I explained it more ti= mes, it was > > > > > > > me who is/was waiting for review of n900 patches and I was no= t able to > > > > > > > speed up review process. There was always some n900 patch in = waiting > > > > > > > state. > > > > > > > > > > > > > > Now when pending n900 patches were reviewed and merged, I pre= pared and > > > > > > > sent another one -- this DM_KEYBOARD which removes one part of > > > > > > > cfb_console code from n900 board code. > > > > > > > > > > > > Alright. So, do you see the warning about DM_SERIAL? Are you = going to > > > > > > start work on that migration now, or in about a week or two whe= n I pick > > > > > > this up, assuming no changes are requested? > > > > > > > > > > I do not see any warning, neither about DM_SERIAL nor any other i= n RX-51 > > > > > test job which builds bootable image for RX-51. See CI link: > > > > > https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3D3580= &view=3Dlogs&j=3D7f54f624-c8dd-54be-07eb-7f2dda6bba78&t=3Dfc9e5b19-7cbc-51d= 2-a2e2-6e73893dece5 > > > > > > > > > > But there is CONFIG_DM_SERIAL warning for nokia_rx51 board in the > > > > > Build the World omap job, see CI link: > > > > > https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3D3580= &view=3Dlogs&j=3D36d465ef-27e5-5934-99d6-cf4495f0bf3d&t=3D2b422a7f-7065-531= c-aa25-e0171b04f5d1 > > > > > > > > It's also visible when just doing "make CROSS_COMPILE=3D... > > > > nokia_rx51_config all" so I guess you need to debug your script and= see > > > > why it's not showing that? > > > > > > > > > After this DM_KEYBOARD patch, I'm planning to look at DM_VIDEO as= Simon > > > > > really wants it and then I can look at DM_SERIAL. > > > > > > > > OK. But, are you going to start before or after this gets merged? > > > > > > > > -- > > > > Tom > > > > > > As that cfb code shares both video and keyboard functionality, switch= ing > > > to DM_VIDEO depends on working DM_KEYBOARD migration. So I can start > > > working on DM_VIDEO changes after I would see how support for > > > DM_KEYBOARD for n900 would look like. I do not want before because I > > > would enter into rebase, conflicts, rework and reimplementation from > > > zero circle (with which I have experience from past n900 u-boot patch= es). > >=20 > > If the problem is reviews I can help with that. If it is lost patches > > then we should be able to get them all in now-ish. Can you resend > > everything that is outstanding. >=20 > This is the only outstanding patch right now. All others were finally > reviewed and merged. >=20 > > Yes you do need to put drivers in drivers/ so please create a Kconfig > > for your keyboard driver and put it in drivers/input >=20 > But this is not easy and make it harder to develop and debug. All these > functionality shares lot of functions, variables and locks; so it cannot > be moved into drivers/input unless you want also watchdog or other code > in drivers/input. Not mentioning that this is specific board code which > is not on any other board, so I do not see any value of trying to invest > lot of time in this. So yes, board/nokia/rx51/rx51.c is 751 lines and should get split in to having watchdog under drivers/watchdog/ and video stuff under drivers/video/ and keyboard under drivers/input/ as that's how a modern board would be done. I probably should have pushed back on such a large board file when things first came in as that's really always been the case, but there used to be more bad examples than there are now. But at the end of the day, I really want to see this board brought up to modern APIs and it's not going to be used as the basis for a new board port, so there's a smaller risk of something new using this as an example. --=20 Tom --ivrUthVTr0Ce7KDI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH9SDUACgkQFHw5/5Y0 tyxPjgwAj/8gCLVckq9SHypVYsO6vFn7kZ0v8Apj+FYY/+U9YXmT+kJUus0W8yxT i/zdAkQ9Mzd0jlRFnZQWH5lVvP4TbUBxJyLsEbJ2lZGUkzOgPOaos4merKA3Aa8S ms+zDAn6cJl/J96SzyqfPUetFLvlqS1T+0Ht3L/RM8OAv5OC3yClG4QyFhg1OPnV zfle+GizrTmOUTnIxdalS/WolTNoz+umklFQ+MXjcLYvAOWwe04oJ45FPxQrhzmU nT7NBTPjhDhXSHnUdA/GmZRI/tPsVw4MfgVV5SUo6oMx29UpYxJ4cwoe2Ufj6uhy C3u7jeCdCFsMbvn1P9nvwWFJ5NpKsmNiWcdcAMd9SxOpgSJuNs8/zWV0yXUCbGjL nV96nplaxQMwINNMEqzyh42+4uv/TwIcdKybFY1SDJjSEB639IG8pZdMQ6DIUe4+ k0F/Gf2QS0AsrzlO6A4/ZeXKB9muGM535DL1KHiBXB2vpppVLE3XTJkXMX5yxrLq FNkRW2c3 =cCOr -----END PGP SIGNATURE----- --ivrUthVTr0Ce7KDI--