All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [PATCH 5/6] eal/windows: fix the curly braces mismatch problem
Date: Sun, 6 Feb 2022 19:23:03 +0300	[thread overview]
Message-ID: <20220206192303.38c560f7@sovereign> (raw)
In-Reply-To: <tencent_0F918E18589EEC53D388089DA7EF86913C07@qq.com>

2022-02-06 08:44 (UTC+0800), Weiguo Li:
> Supplement the first half of braces for the extern "C" block
> 
> Fixes: 99a2dd955fba6 ("lib: remove librte_ prefix from directory names")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>  lib/eal/windows/include/dirent.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/eal/windows/include/dirent.h b/lib/eal/windows/include/dirent.h
> index 34eb077f8c..0a399d3145 100644
> --- a/lib/eal/windows/include/dirent.h
> +++ b/lib/eal/windows/include/dirent.h
> @@ -28,6 +28,10 @@
>  #include <sys/stat.h>
>  #include <errno.h>
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  /* Maximum length of file name */
>  #if !defined(PATH_MAX)
>  #   define PATH_MAX MAX_PATH

This file is not public, used only from DPDK C code.
Rather then adding the opening part, the closing part should be removed.
The "Fixes" tag is incorrect, should be:

Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation")
Cc: pallavi.kadam@intel.com

  reply	other threads:[~2022-02-06 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220206004414.2801177-1-liwg06@foxmail.com>
2022-02-06  0:44 ` [PATCH 1/6] bus/dpaa: fix the curly braces mismatch problem Weiguo Li
2022-02-07  9:26   ` Bruce Richardson
2022-02-06  0:44 ` [PATCH 2/6] common/mlx5: " Weiguo Li
2022-02-06  0:44 ` [PATCH 3/6] net/cxgbe: " Weiguo Li
2022-02-06  0:44 ` [PATCH 4/6] net/dpaa2: " Weiguo Li
2022-02-06  0:44 ` [PATCH 5/6] eal/windows: " Weiguo Li
2022-02-06 16:23   ` Dmitry Kozlyuk [this message]
2022-02-07 11:43   ` Weiguo Li
2022-02-06  0:44 ` [PATCH 6/6] eventdev: remove C++ include guard from private header Weiguo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220206192303.38c560f7@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=liwg06@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.