All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmytro Bagrii <dimich.dmb@gmail.com>
To: linux-usb@vger.kernel.org
Cc: Dmytro Bagrii <dimich.dmb@gmail.com>
Subject: [PATCH] Revert "USB: serial: ch341: add new Product ID for CH341A"
Date: Mon,  7 Feb 2022 02:08:23 +0200	[thread overview]
Message-ID: <20220207000822.697343-1-dimich.dmb@gmail.com> (raw)

This reverts commit 46ee4abb10a07bd8f8ce910ee6b4ae6a947d7f63.

CH341A has three different modes of operation selectable either by
hardware pin connections or by external EEPROM configuration. Each
mode is represented by corresponding product ID:

0x5523: Asyncronous Serial Interface
0x5584: Parallel Printer Interface
0x5512: EPP/MEM Interface

(See "5.3.Function configuration" in datasheet at wch-ic.com/downloads/CH341DS1_PDF.html)

When CH341A is configured as EPP/MEM Interface it appears as 1a86:5512 and being mistakenly
handled by ch341 USB serial driver.

It is possible to use CH341A in EPP/MEM mode only if ch341 module is blacklisted, but it must be
unblacklisted every time to use CH341A as a serial converter. Also obviously it is impossible
to use two CH341A boards in different modes simoultaneously.

Signed-off-by: Dmytro Bagrii <dimich.dmb@gmail.com>
---
 drivers/usb/serial/ch341.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 29f4b87a9e74..65f1286f7905 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -81,7 +81,6 @@
 #define CH341_QUIRK_SIMULATE_BREAK	BIT(1)
 
 static const struct usb_device_id id_table[] = {
-	{ USB_DEVICE(0x1a86, 0x5512) },
 	{ USB_DEVICE(0x1a86, 0x5523) },
 	{ USB_DEVICE(0x1a86, 0x7522) },
 	{ USB_DEVICE(0x1a86, 0x7523) },
-- 
2.35.1


             reply	other threads:[~2022-02-07  0:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  0:08 Dmytro Bagrii [this message]
2022-02-08 10:34 ` [PATCH] Revert "USB: serial: ch341: add new Product ID for CH341A" Greg KH
2022-02-08 13:34   ` Dmytro Bagrii
2022-02-09 14:18     ` Johan Hovold
2022-02-09 17:24       ` Jan-Niklas Burfeind
2022-02-10  5:41       ` Dmytro Bagrii
2022-02-21  8:48         ` Johan Hovold
2022-02-10 10:18       ` Jan-Niklas Burfeind
2022-02-21  8:49         ` Johan Hovold
2022-02-10 16:41   ` [PATCH v2] " Dmytro Bagrii
2022-02-21  9:02     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207000822.697343-1-dimich.dmb@gmail.com \
    --to=dimich.dmb@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.