From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8725081640026228542==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] PCI:pciehp: Replace request_threaded_irq with devm_request_threaded_irq Date: Mon, 07 Feb 2022 02:37:18 +0800 Message-ID: <202202070253.VcJImRNn-lkp@intel.com> In-Reply-To: <20220206140705.10705-1-sensor1010@163.com> List-Id: --===============8725081640026228542== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi lizhe, Thank you for the patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on v5.17-rc2 next-20220204] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/lizhe/PCI-pciehp-Replace-r= equest_threaded_irq-with-devm_request_threaded_irq/20220206-222442 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/2022020= 7/202202070253.VcJImRNn-lkp(a)intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8c1aa010219ad629dc74363ec= 0392a9e868ca536 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review lizhe/PCI-pciehp-Replace-request_t= hreaded_irq-with-devm_request_threaded_irq/20220206-222442 git checkout 8c1aa010219ad629dc74363ec0392a9e868ca536 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dalpha SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pci/hotplug/pciehp_hpc.c: In function 'pciehp_request_irq': drivers/pci/hotplug/pciehp_hpc.c:69:44: warning: passing argument 1 of '= devm_request_threaded_irq' makes pointer from integer without a cast [-Wint= -conversion] 69 | retval =3D devm_request_threaded_irq(irq, pciehp_isr, pc= iehp_ist, | ^~~ | | | int In file included from include/linux/pci.h:38, from drivers/pci/hotplug/pciehp_hpc.c:22: include/linux/interrupt.h:205:42: note: expected 'struct device *' but a= rgument is of type 'int' 205 | devm_request_threaded_irq(struct device *dev, unsigned int irq, | ~~~~~~~~~~~~~~~^~~ drivers/pci/hotplug/pciehp_hpc.c:69:49: warning: passing argument 2 of '= devm_request_threaded_irq' makes integer from pointer without a cast [-Wint= -conversion] 69 | retval =3D devm_request_threaded_irq(irq, pciehp_isr, pc= iehp_ist, | ^~~~~~~~~~ | | | irqreturn_t (*)(= int, void *) {aka enum irqreturn (*)(int, void *)} In file included from include/linux/pci.h:38, from drivers/pci/hotplug/pciehp_hpc.c:22: include/linux/interrupt.h:205:60: note: expected 'unsigned int' but argu= ment is of type 'irqreturn_t (*)(int, void *)' {aka 'enum irqreturn (*)(in= t, void *)'} 205 | devm_request_threaded_irq(struct device *dev, unsigned int irq, | ~~~~~~~~~~~~~^~~ include/linux/interrupt.h:71:33: warning: passing argument 4 of 'devm_re= quest_threaded_irq' makes pointer from integer without a cast [-Wint-conver= sion] 71 | #define IRQF_SHARED 0x00000080 | ^~~~~~~~~~ | | | int drivers/pci/hotplug/pciehp_hpc.c:70:39: note: in expansion of macro 'IRQ= F_SHARED' 70 | IRQF_SHARED, "pciehp", ctr= l); | ^~~~~~~~~~~ include/linux/interrupt.h:206:64: note: expected 'irq_handler_t' {aka 'e= num irqreturn (*)(int, void *)'} but argument is of type 'int' 206 | irq_handler_t handler, irq_handler_t t= hread_fn, | ~~~~~~~~~~~~~~^= ~~~~~~~~ drivers/pci/hotplug/pciehp_hpc.c:70:52: warning: passing argument 5 of '= devm_request_threaded_irq' makes integer from pointer without a cast [-Wint= -conversion] 70 | IRQF_SHARED, "pciehp", ctr= l); | ^~~~~~~~ | | | char * In file included from include/linux/pci.h:38, from drivers/pci/hotplug/pciehp_hpc.c:22: include/linux/interrupt.h:207:41: note: expected 'long unsigned int' but= argument is of type 'char *' 207 | unsigned long irqflags, const char *de= vname, | ~~~~~~~~~~~~~~^~~~~~~~ >> drivers/pci/hotplug/pciehp_hpc.c:70:62: error: passing argument 6 of 'de= vm_request_threaded_irq' from incompatible pointer type [-Werror=3Dincompat= ible-pointer-types] 70 | IRQF_SHARED, "pciehp", ctr= l); | ^~~~ | | | str= uct controller * In file included from include/linux/pci.h:38, from drivers/pci/hotplug/pciehp_hpc.c:22: include/linux/interrupt.h:207:63: note: expected 'const char *' but argu= ment is of type 'struct controller *' 207 | unsigned long irqflags, const char *de= vname, | ~~~~~~~~~~~~^~= ~~~~~ >> drivers/pci/hotplug/pciehp_hpc.c:69:18: error: too few arguments to func= tion 'devm_request_threaded_irq' 69 | retval =3D devm_request_threaded_irq(irq, pciehp_isr, pc= iehp_ist, | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/pci.h:38, from drivers/pci/hotplug/pciehp_hpc.c:22: include/linux/interrupt.h:205:1: note: declared here 205 | devm_request_threaded_irq(struct device *dev, unsigned int irq, | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/devm_request_threaded_irq +70 drivers/pci/hotplug/pciehp_hpc.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 56 = 2aeeef11999590 Kenji Kaneshige 2008-04-25 57 static inline int pciehp_req= uest_irq(struct controller *ctrl) 2aeeef11999590 Kenji Kaneshige 2008-04-25 58 { f7a10e32a1a7ae Kenji Kaneshige 2008-08-22 59 int retval, irq =3D ctrl->p= cie->irq; 2aeeef11999590 Kenji Kaneshige 2008-04-25 60 = 2aeeef11999590 Kenji Kaneshige 2008-04-25 61 if (pciehp_poll_mode) { ec07a4473072ff Lukas Wunner 2018-07-19 62 ctrl->poll_thread =3D kthr= ead_run(&pciehp_poll, ctrl, ec07a4473072ff Lukas Wunner 2018-07-19 63 "pciehp_poll-%s", 5790a9c78e78aa Lukas Wunner 2018-09-18 64 slot_name(ctrl)); ec07a4473072ff Lukas Wunner 2018-07-19 65 return PTR_ERR_OR_ZERO(ctr= l->poll_thread); 2aeeef11999590 Kenji Kaneshige 2008-04-25 66 } 2aeeef11999590 Kenji Kaneshige 2008-04-25 67 = 2aeeef11999590 Kenji Kaneshige 2008-04-25 68 /* Installs the interrupt h= andler */ 8c1aa010219ad6 lizhe 2022-02-06 @69 retval =3D devm_request_thr= eaded_irq(irq, pciehp_isr, pciehp_ist, e07ca82a5fde88 Bjorn Helgaas 2019-05-08 @70 IRQF_SHARED, "pcie= hp", ctrl); 2aeeef11999590 Kenji Kaneshige 2008-04-25 71 if (retval) 7f2feec140f1f1 Taku Izumi 2008-09-05 72 ctrl_err(ctrl, "Cannot get= irq %d for the hotplug controller\n", 7f2feec140f1f1 Taku Izumi 2008-09-05 73 irq); 2aeeef11999590 Kenji Kaneshige 2008-04-25 74 return retval; 2aeeef11999590 Kenji Kaneshige 2008-04-25 75 } 2aeeef11999590 Kenji Kaneshige 2008-04-25 76 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8725081640026228542==--