From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5057072248983069123==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] drm: mxsfb: Simplify LCDIF clock handling Date: Mon, 07 Feb 2022 04:08:50 +0800 Message-ID: <202202070442.Bio2oCXj-lkp@intel.com> In-Reply-To: <20220206185555.275768-1-marex@denx.de> List-Id: --===============5057072248983069123== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on next-20220204] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos= -drm-next tegra-drm/drm/tegra/for-next v5.17-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/drm-mxsfb-Simp= lify-LCDIF-clock-handling/20220207-025717 base: git://anongit.freedesktop.org/drm/drm drm-next config: h8300-randconfig-r025-20220206 (https://download.01.org/0day-ci/arc= hive/20220207/202202070442.Bio2oCXj-lkp(a)intel.com/config) compiler: h8300-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7e48d24c5ec466eddb1bfbb6f= 39daaf061d2a84b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/drm-mxsfb-Simplify-LCD= IF-clock-handling/20220207-025717 git checkout 7e48d24c5ec466eddb1bfbb6f39daaf061d2a84b # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dh8300 SHELL=3D/bin/bash drivers/gpu/drm/mxsfb/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/gpu/drm/mxsfb/mxsfb_drv.c: In function 'mxsfb_load': >> drivers/gpu/drm/mxsfb/mxsfb_drv.c:263:17: error: label 'err_vblank' used= but not defined 263 | goto err_vblank; | ^~~~ At top level: drivers/gpu/drm/mxsfb/mxsfb_drv.c:411:12: warning: 'mxsfb_resume' define= d but not used [-Wunused-function] 411 | static int mxsfb_resume(struct device *dev) | ^~~~~~~~~~~~ drivers/gpu/drm/mxsfb/mxsfb_drv.c:399:12: warning: 'mxsfb_suspend' defin= ed but not used [-Wunused-function] 399 | static int mxsfb_suspend(struct device *dev) | ^~~~~~~~~~~~~ vim +/err_vblank +263 drivers/gpu/drm/mxsfb/mxsfb_drv.c 5fc40f41c137cc Thomas Zimmermann 2021-08-03 189 = c6ddee8220bf8a Laurent Pinchart 2020-07-27 190 static int mxsfb_load(str= uct drm_device *drm, c6ddee8220bf8a Laurent Pinchart 2020-07-27 191 const struct mxsf= b_devdata *devdata) 45d59d704080cc Marek Vasut 2016-08-18 192 { 45d59d704080cc Marek Vasut 2016-08-18 193 struct platform_device *= pdev =3D to_platform_device(drm->dev); 45d59d704080cc Marek Vasut 2016-08-18 194 struct mxsfb_drm_private= *mxsfb; 45d59d704080cc Marek Vasut 2016-08-18 195 struct resource *res; 45d59d704080cc Marek Vasut 2016-08-18 196 int ret; 45d59d704080cc Marek Vasut 2016-08-18 197 = 45d59d704080cc Marek Vasut 2016-08-18 198 mxsfb =3D devm_kzalloc(&= pdev->dev, sizeof(*mxsfb), GFP_KERNEL); 45d59d704080cc Marek Vasut 2016-08-18 199 if (!mxsfb) 45d59d704080cc Marek Vasut 2016-08-18 200 return -ENOMEM; 45d59d704080cc Marek Vasut 2016-08-18 201 = c42001e357f7de Laurent Pinchart 2020-07-27 202 mxsfb->drm =3D drm; 45d59d704080cc Marek Vasut 2016-08-18 203 drm->dev_private =3D mxs= fb; c6ddee8220bf8a Laurent Pinchart 2020-07-27 204 mxsfb->devdata =3D devda= ta; 45d59d704080cc Marek Vasut 2016-08-18 205 = 45d59d704080cc Marek Vasut 2016-08-18 206 res =3D platform_get_res= ource(pdev, IORESOURCE_MEM, 0); 45d59d704080cc Marek Vasut 2016-08-18 207 mxsfb->base =3D devm_ior= emap_resource(drm->dev, res); 45d59d704080cc Marek Vasut 2016-08-18 208 if (IS_ERR(mxsfb->base)) 45d59d704080cc Marek Vasut 2016-08-18 209 return PTR_ERR(mxsfb->b= ase); 45d59d704080cc Marek Vasut 2016-08-18 210 = 45d59d704080cc Marek Vasut 2016-08-18 211 mxsfb->clk =3D devm_clk_= get(drm->dev, NULL); 45d59d704080cc Marek Vasut 2016-08-18 212 if (IS_ERR(mxsfb->clk)) 45d59d704080cc Marek Vasut 2016-08-18 213 return PTR_ERR(mxsfb->c= lk); 45d59d704080cc Marek Vasut 2016-08-18 214 = 7e48d24c5ec466 Marek Vasut 2022-02-06 215 mxsfb->clk_axi =3D devm_= clk_get_optional(drm->dev, "axi"); 45d59d704080cc Marek Vasut 2016-08-18 216 if (IS_ERR(mxsfb->clk_ax= i)) 7e48d24c5ec466 Marek Vasut 2022-02-06 217 return PTR_ERR(mxsfb->c= lk_axi); 45d59d704080cc Marek Vasut 2016-08-18 218 = 7e48d24c5ec466 Marek Vasut 2022-02-06 219 mxsfb->clk_disp_axi =3D = devm_clk_get_optional(drm->dev, "disp_axi"); 45d59d704080cc Marek Vasut 2016-08-18 220 if (IS_ERR(mxsfb->clk_di= sp_axi)) 7e48d24c5ec466 Marek Vasut 2022-02-06 221 return PTR_ERR(mxsfb->c= lk_disp_axi); 45d59d704080cc Marek Vasut 2016-08-18 222 = 45d59d704080cc Marek Vasut 2016-08-18 223 ret =3D dma_set_mask_and= _coherent(drm->dev, DMA_BIT_MASK(32)); 45d59d704080cc Marek Vasut 2016-08-18 224 if (ret) 45d59d704080cc Marek Vasut 2016-08-18 225 return ret; 45d59d704080cc Marek Vasut 2016-08-18 226 = 45d59d704080cc Marek Vasut 2016-08-18 227 /* Modeset init */ 45d59d704080cc Marek Vasut 2016-08-18 228 drm_mode_config_init(drm= ); 45d59d704080cc Marek Vasut 2016-08-18 229 = ae1ed009328193 Laurent Pinchart 2020-07-27 230 ret =3D mxsfb_kms_init(m= xsfb); 45d59d704080cc Marek Vasut 2016-08-18 231 if (ret < 0) { ae1ed009328193 Laurent Pinchart 2020-07-27 232 dev_err(drm->dev, "Fail= ed to initialize KMS pipeline\n"); 7e48d24c5ec466 Marek Vasut 2022-02-06 233 return ret; 45d59d704080cc Marek Vasut 2016-08-18 234 } 45d59d704080cc Marek Vasut 2016-08-18 235 = b9f5937680a8f1 Laurent Pinchart 2020-07-27 236 ret =3D drm_vblank_init(= drm, drm->mode_config.num_crtc); b9f5937680a8f1 Laurent Pinchart 2020-07-27 237 if (ret < 0) { b9f5937680a8f1 Laurent Pinchart 2020-07-27 238 dev_err(drm->dev, "Fail= ed to initialise vblank\n"); 7e48d24c5ec466 Marek Vasut 2022-02-06 239 return ret; b9f5937680a8f1 Laurent Pinchart 2020-07-27 240 } b9f5937680a8f1 Laurent Pinchart 2020-07-27 241 = b9f5937680a8f1 Laurent Pinchart 2020-07-27 242 /* Start with vertical b= lanking interrupt reporting disabled. */ b9f5937680a8f1 Laurent Pinchart 2020-07-27 243 drm_crtc_vblank_off(&mxs= fb->crtc); b9f5937680a8f1 Laurent Pinchart 2020-07-27 244 = c42001e357f7de Laurent Pinchart 2020-07-27 245 ret =3D mxsfb_attach_bri= dge(mxsfb); 45d59d704080cc Marek Vasut 2016-08-18 246 if (ret) { ee46d16d2e40be Guido G=C3=BCnther 2020-12-15 247 if (ret !=3D -EPRO= BE_DEFER) d02340436695cb Robert Chiras 2019-08-29 248 dev_err(drm->dev, "Can= not connect bridge: %d\n", ret); 7e48d24c5ec466 Marek Vasut 2022-02-06 249 return ret; 45d59d704080cc Marek Vasut 2016-08-18 250 } 45d59d704080cc Marek Vasut 2016-08-18 251 = 45d59d704080cc Marek Vasut 2016-08-18 252 drm->mode_config.min_wid= th =3D MXSFB_MIN_XRES; 45d59d704080cc Marek Vasut 2016-08-18 253 drm->mode_config.min_hei= ght =3D MXSFB_MIN_YRES; 45d59d704080cc Marek Vasut 2016-08-18 254 drm->mode_config.max_wid= th =3D MXSFB_MAX_XRES; 45d59d704080cc Marek Vasut 2016-08-18 255 drm->mode_config.max_hei= ght =3D MXSFB_MAX_YRES; 45d59d704080cc Marek Vasut 2016-08-18 256 drm->mode_config.funcs = =3D &mxsfb_mode_config_funcs; 9f19fd3bd894d6 Leonard Crestez 2018-09-17 257 drm->mode_config.helper_= private =3D &mxsfb_mode_config_helpers; 45d59d704080cc Marek Vasut 2016-08-18 258 = 45d59d704080cc Marek Vasut 2016-08-18 259 drm_mode_config_reset(dr= m); 45d59d704080cc Marek Vasut 2016-08-18 260 = 5fc40f41c137cc Thomas Zimmermann 2021-08-03 261 ret =3D platform_get_irq= (pdev, 0); 5fc40f41c137cc Thomas Zimmermann 2021-08-03 262 if (ret < 0) 5fc40f41c137cc Thomas Zimmermann 2021-08-03 @263 goto err_vblank; 5fc40f41c137cc Thomas Zimmermann 2021-08-03 264 mxsfb->irq =3D ret; 5fc40f41c137cc Thomas Zimmermann 2021-08-03 265 = 5fc40f41c137cc Thomas Zimmermann 2021-08-03 266 ret =3D mxsfb_irq_instal= l(drm, mxsfb->irq); 45d59d704080cc Marek Vasut 2016-08-18 267 if (ret < 0) { 45d59d704080cc Marek Vasut 2016-08-18 268 dev_err(drm->dev, "Fail= ed to install IRQ handler\n"); 7e48d24c5ec466 Marek Vasut 2022-02-06 269 return ret; 45d59d704080cc Marek Vasut 2016-08-18 270 } 45d59d704080cc Marek Vasut 2016-08-18 271 = 45d59d704080cc Marek Vasut 2016-08-18 272 drm_kms_helper_poll_init= (drm); 45d59d704080cc Marek Vasut 2016-08-18 273 = 45d59d704080cc Marek Vasut 2016-08-18 274 platform_set_drvdata(pde= v, drm); 45d59d704080cc Marek Vasut 2016-08-18 275 = 45d59d704080cc Marek Vasut 2016-08-18 276 drm_helper_hpd_irq_event= (drm); 45d59d704080cc Marek Vasut 2016-08-18 277 = 7e48d24c5ec466 Marek Vasut 2022-02-06 278 pm_runtime_enable(drm->d= ev); 45d59d704080cc Marek Vasut 2016-08-18 279 = 7e48d24c5ec466 Marek Vasut 2022-02-06 280 return 0; 45d59d704080cc Marek Vasut 2016-08-18 281 } 45d59d704080cc Marek Vasut 2016-08-18 282 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5057072248983069123==--