From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C75EC433EF for ; Mon, 7 Feb 2022 07:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239567AbiBGG5x (ORCPT ); Mon, 7 Feb 2022 01:57:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233369AbiBGGxU (ORCPT ); Mon, 7 Feb 2022 01:53:20 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 560D5C043181 for ; Sun, 6 Feb 2022 22:53:19 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id ACA9B68BFE; Mon, 7 Feb 2022 07:53:16 +0100 (CET) Date: Mon, 7 Feb 2022 07:53:16 +0100 From: Christoph Hellwig To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Seth Forshee , Christoph Hellwig , Al Viro Subject: Re: [PATCH 7/7] fs: clean up mount_setattr control flow Message-ID: <20220207065316.GG23601@lst.de> References: <20220203131411.3093040-1-brauner@kernel.org> <20220203131411.3093040-8-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203131411.3093040-8-brauner@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Feb 03, 2022 at 02:14:11PM +0100, Christian Brauner wrote: > Simplify the control flow of mount_setattr_{prepare,commit} so they > became easiert to follow. We kept using both an integer error variable s/became easiert/become easier/g Otherwise looks good: Reviewed-by: Christoph Hellwig