From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: alexandru.tachici@analog.com, davem@davemloft.net,
devicetree@vger.kernel.org, hkallweit1@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Date: Mon, 7 Feb 2022 10:27:53 +0100 [thread overview]
Message-ID: <20220207092753.GC23727@pengutronix.de> (raw)
In-Reply-To: <YbUTJdKN9kQAJzqA@lunn.ch>
Hi Alexandru,
On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > + if (ret < 0)
> > + return ret;
> > +
> > + if (ret & MDIO_PMA_EXTABLE_BT1)
>
>
> This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> is expected to change is it? So i wounder if it should be read once
> and stored away?
What is the state of this patches? Will you be able to make requested
changes and send new version?
Regards,
Oleskij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-02-07 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 11:05 [PATCH v4 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-12-10 11:05 ` [PATCH v4 1/7] ethtool: Add 10base-T1L link mode entry alexandru.tachici
2021-12-11 20:46 ` Andrew Lunn
2021-12-10 11:05 ` [PATCH v4 2/7] net: phy: Add 10-BaseT1L registers alexandru.tachici
2021-12-11 20:48 ` Andrew Lunn
2021-12-10 11:05 ` [PATCH v4 3/7] net: phy: Add BaseT1 auto-negotiation registers alexandru.tachici
2021-12-11 21:00 ` Andrew Lunn
2021-12-10 11:05 ` [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45 alexandru.tachici
2021-12-11 21:07 ` Andrew Lunn
2022-02-07 9:27 ` Oleksij Rempel [this message]
2022-02-09 15:12 ` alexandru.tachici
2022-02-18 7:28 ` Oleksij Rempel
2021-12-10 11:05 ` [PATCH v4 5/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-12-10 11:05 ` [PATCH v4 6/7] net: phy: adin1100: Add SQI support alexandru.tachici
2021-12-10 11:05 ` [PATCH v4 7/7] dt-bindings: net: phy: Add 10-baseT1L 2.4 Vpp alexandru.tachici
2021-12-10 22:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207092753.GC23727@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=alexandru.tachici@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.