From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36EE5C433EF for ; Mon, 7 Feb 2022 12:06:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9211710F60C; Mon, 7 Feb 2022 12:06:52 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE6C010F60C; Mon, 7 Feb 2022 12:06:51 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B19FC68AA6; Mon, 7 Feb 2022 13:06:47 +0100 (CET) Date: Mon, 7 Feb 2022 13:06:47 +0100 From: Christoph Hellwig To: Zhi Wang Message-ID: <20220207120647.GA28851@lst.de> References: <20220127120508.11330-1-zhi.a.wang@intel.com> <20220207073247.GA24327@lst.de> <20220207083535.GA25345@lst.de> <877da7rlzr.fsf@intel.com> <5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Xu, Terrence" , "dri-devel@lists.freedesktop.org" , "jgg@nvidia.com" , "intel-gvt-dev@lists.freedesktop.org" , Christoph Hellwig Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote: > Hi Christoph and Jani: > > Thanks for the comments. It would be nice that people can achieve a > agreement. I am OK with both of the options and also moving some files into > different folders doesn't needs me to do the full test run again. :) The way I understood Jani he agrees that the mmio table, which needs to be part of the core i915 module should not be under the gvt/ subdiretory. I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h or drivers/gpu/drm/i915/intel_gvt_mmio_table.h. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695E3C43219 for ; Mon, 7 Feb 2022 13:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443102AbiBGNJt (ORCPT ); Mon, 7 Feb 2022 08:09:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442248AbiBGMUt (ORCPT ); Mon, 7 Feb 2022 07:20:49 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC77DF8E3E5 for ; Mon, 7 Feb 2022 04:06:52 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B19FC68AA6; Mon, 7 Feb 2022 13:06:47 +0100 (CET) Date: Mon, 7 Feb 2022 13:06:47 +0100 From: Christoph Hellwig To: Zhi Wang Cc: Jani Nikula , Christoph Hellwig , "Wang, Zhi A" , "jgg@nvidia.com" , "intel-gfx@lists.freedesktop.org" , "intel-gvt-dev@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Joonas Lahtinen , "Vivi, Rodrigo" , Zhenyu Wang , "Xu, Terrence" , Tvrtko Ursulin Subject: Re: [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API Message-ID: <20220207120647.GA28851@lst.de> References: <20220127120508.11330-1-zhi.a.wang@intel.com> <20220207073247.GA24327@lst.de> <20220207083535.GA25345@lst.de> <877da7rlzr.fsf@intel.com> <5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 07, 2022 at 06:57:13AM -0500, Zhi Wang wrote: > Hi Christoph and Jani: > > Thanks for the comments. It would be nice that people can achieve a > agreement. I am OK with both of the options and also moving some files into > different folders doesn't needs me to do the full test run again. :) The way I understood Jani he agrees that the mmio table, which needs to be part of the core i915 module should not be under the gvt/ subdiretory. I.e. it could be drivers/gpu/drm/i915/intel_gvt_mmio_table.c. The declarations could then go either into drivers/gpu/drm/i915/intel_gvt.h or drivers/gpu/drm/i915/intel_gvt_mmio_table.h.