From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FAAAC4332F for ; Thu, 10 Feb 2022 01:00:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A668910E6D7; Thu, 10 Feb 2022 01:00:21 +0000 (UTC) X-Greylist: delayed 314 seconds by postgrey-1.36 at gabe; Mon, 07 Feb 2022 16:41:12 UTC Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E42410E15E for ; Mon, 7 Feb 2022 16:41:12 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 5A8582B0014D; Mon, 7 Feb 2022 11:35:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Feb 2022 11:35:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=RkfLFhsT0oeGyH5Q3NR1vzRXIXUZ5k WakkOr/SvCplw=; b=JpWwuFwE/j/V04CJHDv3wX6V0EFJqQgjmMIIv1jPDGhGZ1 /k9gGwSmkz/Unlvo+DUYd2o2YIEz2IgqzssdY3BR3U45fnIUqZIGQX8Qn2IqjI5f pMwe0vLbTpx6wnZAWRAEAZOA2SAsaQ/Kv447OwvdHegl995Xe/d+6rUM+rPAXnCK i+KsfpnnsPtp+GqUKsQ08QFYA04LAEfOCOZZvXuQhz+VcxUBQMXSRltlMWnPUsaf 0WnLKkhPImhe7BBhma4XHUtgUhXUH/2kXeusX7mnGPdiOvbdqexDekyL0eN+RaeM /RywVkcoNtf6Bq/kHZWwATwUB427oJIZjda+CR5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RkfLFh sT0oeGyH5Q3NR1vzRXIXUZ5kWakkOr/SvCplw=; b=nTDNgBD6enNdVjyZ7eQNR3 63bAs193AjFl7nFO48OejRLSgFPXpexTOjM311Xk2yKI6iBr1UZysd+mgCMZg/bS d/pMr/hgqOCwnRUB+23RW4DnNu2Jn32D5Gt9xBSzsJ6erwq+Hk8OBpqKHOTH3dDz 0CD/55FSAYILCAPvov76xCVkjIhwL45KzgYxLrq/49sv7iZvi0RQvN2sn/UaHiZY 7rtsbx6r+wKoI2sobPeOE40Nd51UBFqW8UwYporQa972gSRvtfDVZTAyUPZkbMrA YcSVtKw9mGBzsimPj2uv6WBtYJ90Ychr4bJusNF4Bwp3mbfc464/sX7VUHdB+M4w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 11:35:56 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Date: Mon, 7 Feb 2022 17:35:05 +0100 Message-Id: <20220207163515.1038648-14-maxime@cerno.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207163515.1038648-1-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 10 Feb 2022 01:00:19 +0000 Subject: [Nouveau] [PATCH 13/23] drm/nouveau/kms: Remove redundant zpos initialisation X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , nouveau@lists.freedesktop.org, Maarten Lankhorst , dri-devel@lists.freedesktop.org, Maxime Ripard , Phil Elwell , Ben Skeggs Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" The nouveau KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in nv50_wndw_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: nouveau@lists.freedesktop.org Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Signed-off-by: Maxime Ripard --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c index 133c8736426a..0c1a2ea0ed04 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c +++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c @@ -635,8 +635,6 @@ nv50_wndw_reset(struct drm_plane *plane) plane->funcs->atomic_destroy_state(plane, plane->state); __drm_atomic_helper_plane_reset(plane, &asyw->state); - plane->state->zpos = nv50_wndw_zpos_default(plane); - plane->state->normalized_zpos = nv50_wndw_zpos_default(plane); } static void -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 782FAC433EF for ; Mon, 7 Feb 2022 16:36:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95C9E10F871; Mon, 7 Feb 2022 16:36:00 +0000 (UTC) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2F0F10F8BB for ; Mon, 7 Feb 2022 16:35:58 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 5A8582B0014D; Mon, 7 Feb 2022 11:35:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Feb 2022 11:35:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=RkfLFhsT0oeGyH5Q3NR1vzRXIXUZ5k WakkOr/SvCplw=; b=JpWwuFwE/j/V04CJHDv3wX6V0EFJqQgjmMIIv1jPDGhGZ1 /k9gGwSmkz/Unlvo+DUYd2o2YIEz2IgqzssdY3BR3U45fnIUqZIGQX8Qn2IqjI5f pMwe0vLbTpx6wnZAWRAEAZOA2SAsaQ/Kv447OwvdHegl995Xe/d+6rUM+rPAXnCK i+KsfpnnsPtp+GqUKsQ08QFYA04LAEfOCOZZvXuQhz+VcxUBQMXSRltlMWnPUsaf 0WnLKkhPImhe7BBhma4XHUtgUhXUH/2kXeusX7mnGPdiOvbdqexDekyL0eN+RaeM /RywVkcoNtf6Bq/kHZWwATwUB427oJIZjda+CR5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=RkfLFh sT0oeGyH5Q3NR1vzRXIXUZ5kWakkOr/SvCplw=; b=nTDNgBD6enNdVjyZ7eQNR3 63bAs193AjFl7nFO48OejRLSgFPXpexTOjM311Xk2yKI6iBr1UZysd+mgCMZg/bS d/pMr/hgqOCwnRUB+23RW4DnNu2Jn32D5Gt9xBSzsJ6erwq+Hk8OBpqKHOTH3dDz 0CD/55FSAYILCAPvov76xCVkjIhwL45KzgYxLrq/49sv7iZvi0RQvN2sn/UaHiZY 7rtsbx6r+wKoI2sobPeOE40Nd51UBFqW8UwYporQa972gSRvtfDVZTAyUPZkbMrA YcSVtKw9mGBzsimPj2uv6WBtYJ90Ychr4bJusNF4Bwp3mbfc464/sX7VUHdB+M4w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 11:35:56 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Subject: [PATCH 13/23] drm/nouveau/kms: Remove redundant zpos initialisation Date: Mon, 7 Feb 2022 17:35:05 +0100 Message-Id: <20220207163515.1038648-14-maxime@cerno.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207163515.1038648-1-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Karol Herbst , Maxime Ripard , Thomas Zimmermann , Phil Elwell , Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The nouveau KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in nv50_wndw_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: nouveau@lists.freedesktop.org Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Signed-off-by: Maxime Ripard --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c index 133c8736426a..0c1a2ea0ed04 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c +++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c @@ -635,8 +635,6 @@ nv50_wndw_reset(struct drm_plane *plane) plane->funcs->atomic_destroy_state(plane, plane->state); __drm_atomic_helper_plane_reset(plane, &asyw->state); - plane->state->zpos = nv50_wndw_zpos_default(plane); - plane->state->normalized_zpos = nv50_wndw_zpos_default(plane); } static void -- 2.34.1