From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E460C433F5 for ; Mon, 7 Feb 2022 19:35:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D75DF10F8ED; Mon, 7 Feb 2022 19:35:55 +0000 (UTC) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BFA010F8ED for ; Mon, 7 Feb 2022 19:27:32 +0000 (UTC) Received: by mail-qt1-x831.google.com with SMTP id l14so554748qtp.7 for ; Mon, 07 Feb 2022 11:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=Ch8C10PSNgUgzrJSYUwNmUYPnK3KqD5nVzs8U25K8dQe5Nz0RHnqD34dfcVzOfHQn0 Z7A2NrwTV3T8U5qAOPkdl18fdhCkDtt27sDhMF9az9KwL3bhZc1wWsNakacs8mHp4+2i ATHSdkH9LZE8z74Q7FsDuavDIliXPR3QE65Wv381+/ZcyQuEMN7ZFrlis4MW0UWFA66p hAq2I0gQh10LCJLc1hBJhl0b+SX/rRCFuGSDgkT7h5GKbOua68a4YV58mo6/qZ9LpsXw xHl/NBuQ1Pg3+hWr0zmMYM2z5/HBKY5RxkuejNX/FdePkUnSlgZKK24pt/x4bYmxOQsS FISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=b5qldx5yftED2bq4qkFFsYjJKhUgnWVQAO76VoUbOOLAgdTZ6B/Ee7Ck38qcllfO+B V2dqZFLL1rHrAykOjzdJ7s7YY1NrqDU8y+uuUlJmjTR366geZX+AOOzVjg6Tj1ZaIJVU ZbipVo+qCsQEChbdYQ2eDTauervaw/a/oG6+ISVzEA/FCCuLoCBESjmvGVG8TNy5368W XJcLGV8RMi1Bj/1JtK+0d75k6tagt39r9aXIIqJkgJKGLz6j9thLAEqcsf6exRYTaNNJ 3cicwKcGAeJAmH4HmCy06/h3r91XRU0hsW5OgPqSSbk5I7l3T/0IhiNidxYJvtHypfNM 7QwA== X-Gm-Message-State: AOAM5311lXL9IuG3tssuGVUhp61h25mAUGCkRCjzoj89Vyl6eHgeN5+Q VazyZ7t5nHVcKk6f9KNZnhaIKw== X-Google-Smtp-Source: ABdhPJxE/dHX+9xmPplXl1VvJP7kBTi3tiLgJTGk2+Y/ZJni8J0n6I1+6ACqdKe2xRydNCRf+KVUww== X-Received: by 2002:ac8:7ca4:: with SMTP id z4mr750427qtv.526.1644262051598; Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id de15sm5546110qkb.107.2022.02.07.11.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9fe-000HwP-GM; Mon, 07 Feb 2022 15:27:30 -0400 Date: Mon, 7 Feb 2022 15:27:30 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c Message-ID: <20220207192730.GE49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-5-hch@lst.de> X-Mailman-Approved-At: Mon, 07 Feb 2022 19:35:52 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Feb 07, 2022 at 07:32:45AM +0100, Christoph Hellwig wrote: > free_devmap_managed_page has nothing to do with the code in swap.c, > move it to live with the rest of the code for devmap handling. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 1 - > mm/memremap.c | 21 +++++++++++++++++++++ > mm/swap.c | 23 ----------------------- > 3 files changed, 21 insertions(+), 24 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6A9CC433FE for ; Mon, 7 Feb 2022 19:27:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 392E210F8EB; Mon, 7 Feb 2022 19:27:34 +0000 (UTC) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68F2310F8E7 for ; Mon, 7 Feb 2022 19:27:32 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id e16so12840097qtq.6 for ; Mon, 07 Feb 2022 11:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=Ch8C10PSNgUgzrJSYUwNmUYPnK3KqD5nVzs8U25K8dQe5Nz0RHnqD34dfcVzOfHQn0 Z7A2NrwTV3T8U5qAOPkdl18fdhCkDtt27sDhMF9az9KwL3bhZc1wWsNakacs8mHp4+2i ATHSdkH9LZE8z74Q7FsDuavDIliXPR3QE65Wv381+/ZcyQuEMN7ZFrlis4MW0UWFA66p hAq2I0gQh10LCJLc1hBJhl0b+SX/rRCFuGSDgkT7h5GKbOua68a4YV58mo6/qZ9LpsXw xHl/NBuQ1Pg3+hWr0zmMYM2z5/HBKY5RxkuejNX/FdePkUnSlgZKK24pt/x4bYmxOQsS FISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=i7xMiQP8i+7YCSAWm42etuVppGommSa0ykUAsWoRSthZ615CVi4gW1fpb+ZsbeEjnj UihAFkCI3CjXztYFgE4F5r+0SvBiRRrjQtzS1r0e8n79BcTKFbNWLOnGoVlJ1qECTfJl r5hWOiIFKT3KsebnZq6tMXp1nl0i+tORA2lrP/JZu17fRcbQNgeJl1d7/s0gDv28pZ1v /2w7yf6D7kfA2cmdnSQABfGdpEoxFV+BU3yuji97w8DDMbhYRBh9HvbdYnX3KXWNqrKi dJk/xypk244iCLlyVZ5qta+y2/RFDpezRsRjYRZH1yK1AHRDzx9pWJDrQkPT5ymaZcKx htBw== X-Gm-Message-State: AOAM53181sHfafSJql1kUgl4sStdwUdrTeT4jJY5J8YlCP+NAycBbxPV dxiSITY6bZ8BODPS1ve8ixlhww== X-Google-Smtp-Source: ABdhPJxE/dHX+9xmPplXl1VvJP7kBTi3tiLgJTGk2+Y/ZJni8J0n6I1+6ACqdKe2xRydNCRf+KVUww== X-Received: by 2002:ac8:7ca4:: with SMTP id z4mr750427qtv.526.1644262051598; Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id de15sm5546110qkb.107.2022.02.07.11.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9fe-000HwP-GM; Mon, 07 Feb 2022 15:27:30 -0400 Date: Mon, 7 Feb 2022 15:27:30 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20220207192730.GE49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-5-hch@lst.de> Subject: Re: [Nouveau] [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, Feb 07, 2022 at 07:32:45AM +0100, Christoph Hellwig wrote: > free_devmap_managed_page has nothing to do with the code in swap.c, > move it to live with the rest of the code for devmap handling. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 1 - > mm/memremap.c | 21 +++++++++++++++++++++ > mm/swap.c | 23 ----------------------- > 3 files changed, 21 insertions(+), 24 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 859C42F26 for ; Mon, 7 Feb 2022 19:27:32 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id r14so12843382qtt.5 for ; Mon, 07 Feb 2022 11:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=Ch8C10PSNgUgzrJSYUwNmUYPnK3KqD5nVzs8U25K8dQe5Nz0RHnqD34dfcVzOfHQn0 Z7A2NrwTV3T8U5qAOPkdl18fdhCkDtt27sDhMF9az9KwL3bhZc1wWsNakacs8mHp4+2i ATHSdkH9LZE8z74Q7FsDuavDIliXPR3QE65Wv381+/ZcyQuEMN7ZFrlis4MW0UWFA66p hAq2I0gQh10LCJLc1hBJhl0b+SX/rRCFuGSDgkT7h5GKbOua68a4YV58mo6/qZ9LpsXw xHl/NBuQ1Pg3+hWr0zmMYM2z5/HBKY5RxkuejNX/FdePkUnSlgZKK24pt/x4bYmxOQsS FISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BoyrZhI/SFo2F7HoszDIan4CMWU1RWbm6+Gl19zQGEA=; b=o+/48QL3QceEhzObCTlDqRPAISK/EI3j2BTsHBAcIm32/iX+tTdh4Y6zHXDVq/pW3z hOTgNUGvTzk/kthZcjLNpivaRu0cKgqwf6vEbcTJO4BZ29b5eMoHc7PCr+9i3uSmSpei dxSiH8FG2XfPEPCtknq6IO4O9Z2JamU+PUxBz1A3gTRkpY/kmU6x7EHGN4LIPKtWkDho S4UmYgJPnR6zYGLbSKTadMi5+sMHLuOTPAgpxWpH+yhvfhlJJv7fo2b5A70tCO58VweK HKJOFSFSf/2RL9kUiHhLgNeJWIPseCevJt9viBdhfRATRzA+VctGFFknHl8S5J55TlKp /avg== X-Gm-Message-State: AOAM530wpKQDqAG9+53y+hwcB3W7SPKPSU5fqQQbunlwERjgOcSe20cU 1IFes1JVXxbSPWcEM52MFoTbtQ== X-Google-Smtp-Source: ABdhPJxE/dHX+9xmPplXl1VvJP7kBTi3tiLgJTGk2+Y/ZJni8J0n6I1+6ACqdKe2xRydNCRf+KVUww== X-Received: by 2002:ac8:7ca4:: with SMTP id z4mr750427qtv.526.1644262051598; Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id de15sm5546110qkb.107.2022.02.07.11.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:27:31 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9fe-000HwP-GM; Mon, 07 Feb 2022 15:27:30 -0400 Date: Mon, 7 Feb 2022 15:27:30 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Andrew Morton , Dan Williams , Felix Kuehling , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c Message-ID: <20220207192730.GE49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-5-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-5-hch@lst.de> On Mon, Feb 07, 2022 at 07:32:45AM +0100, Christoph Hellwig wrote: > free_devmap_managed_page has nothing to do with the code in swap.c, > move it to live with the rest of the code for devmap handling. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 1 - > mm/memremap.c | 21 +++++++++++++++++++++ > mm/swap.c | 23 ----------------------- > 3 files changed, 21 insertions(+), 24 deletions(-) Reviewed-by: Jason Gunthorpe Jason