From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12887C433EF for ; Tue, 8 Feb 2022 14:30:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FDC883CC9; Tue, 8 Feb 2022 15:30:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OJU1SEQ8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A60A83CD1; Tue, 8 Feb 2022 15:30:24 +0100 (CET) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C632083CAF for ; Tue, 8 Feb 2022 15:30:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id bs32so13823190qkb.1 for ; Tue, 08 Feb 2022 06:30:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+nGPTxKMSYRtITX1Wu9CAMHg4h7/WmyA34N2Sr2sW9c=; b=OJU1SEQ8gTUMw1sWKw8EJV38eOHCS+N/R0gGiNTyamnDaEWflbH4RFQk/6ezaUXjQf 0nkM7taR7+ai2e2SN9vM5EbDAFLngUp4EfgznS7oIhh8b5YJ5dY0xRroAT0vbKGv8hQI JPg/p/Nmgsfz+191uj2uvcnpIblYheDEvhhxo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+nGPTxKMSYRtITX1Wu9CAMHg4h7/WmyA34N2Sr2sW9c=; b=w0xVNrENvHPPCuvdGXSGbnrTOnMKd3xCt/Jdmy9SMGc5tLWYxeLt31sAy1eQOBRUda b21XURjrlgFV3KYu4L/MGB1pzkAvHjJPbhwYLeKoebpleIy9IMyS9V5Whoi1bbEiA+Pz OgSLZxsGkHGODWp2059S83BWO6cwACuJBu2QbQ9M8W+nYsu1Tg180ubd6MnR74nxsjyw NlmpYKMjBMr7ezkx7/gXjdF+0zLgRDgGy/LpXfH4WECoAN0d+OWqe+zckocIihBj7eSL P2u0krUQxIACd05jVZs+ATuqKpKxXpCU8F6TQWbW3lP6WNKvnk9WfkiQxFDTGgJ9FBUZ pRtg== X-Gm-Message-State: AOAM530gdbcto/Zlne6xIsKgHk2Etnpnd2M/oOSRPXyiKK1q5Ni/uwFV vgupl7EWujLrzBzt084Is74cSZ60GhHzIQ== X-Google-Smtp-Source: ABdhPJwJR3vwZO1QiCq5j8MWYa7OfPUsQnJQ4oexKC9eoskfNbPWPpS8xwGzbHZ7lImAEO0hn63pMA== X-Received: by 2002:a05:620a:40c9:: with SMTP id g9mr2727965qko.299.1644330618587; Tue, 08 Feb 2022 06:30:18 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id y20sm6203071qtw.28.2022.02.08.06.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 06:30:17 -0800 (PST) Date: Tue, 8 Feb 2022 09:30:16 -0500 From: Tom Rini To: Troy Kisky Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Message-ID: <20220208143016.GN7515@bill-the-cat> References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> <20220107151250.GK2773246@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AWp5UnKkrrfm+LWP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --AWp5UnKkrrfm+LWP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 07, 2022 at 10:33:34AM -0800, Troy Kisky wrote: > On 1/7/2022 7:12 AM, Tom Rini wrote: > > On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: > >> On 12/28/2021 5:11 AM, Tom Rini wrote: > >>> On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: > >>>> Hi Troy, > >>>> > >>>> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: > >>>>> > >>>>> This series intends to let board specific files live in the boards > >>>>> directory. The last patch moves files for nitrogen6x. > >>>>> I have tested it with buildman > >>>>> > >>>>> ./tools/buildman/buildman boundary -b denx_master > >>>>> > >>>>> But it is likely the more scripts then just tools/genboardscfg.py w= ould > >>>>> need to be updated. > >>>>> > >>>>> Troy Kisky (5): > >>>>> kconfig: allow defconfigs to live in board directory > >>>>> dts: allow dts files in board directory > >>>>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to = live > >>>>> in board directory > >>>>> genboardcfg: allow defconfigs in board directory > >>>>> nitrogen6x: move board specific files to nitrogen6x directory > >>>>> > >>>>> arch/arm/dts/Makefile | 3 -- > >>>>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- > >>>>> board/boundary/nitrogen6x/Makefile | 13 +++++++ > >>>>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 > >>>>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 > >>>>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 > >>>>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 > >>>>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 > >>>>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 > >>>>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 > >>>>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 > >>>>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 > >>>>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 > >>>>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 > >>>>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 > >>>>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- > >>>>> dts/Makefile | 11 +++++- > >>>>> scripts/Makefile.autoconf | 9 ++++- > >>>>> scripts/Makefile.lib | 1 + > >>>>> scripts/kconfig/Makefile | 9 ++++- > >>>>> tools/genboardscfg.py | 37 +++++++++++++++= +++- > >>>>> 21 files changed, 75 insertions(+), 23 deletions(-) > >>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6dl-nitrog= en6x.dts (100%) > >>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-nitroge= n6x.dts (100%) > >>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-sabreli= te.dts (100%) > >>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-nitro= gen6x.dtsi (100%) > >>>>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-sabre= lite.dtsi (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/mx6qsabrelite_defc= onfig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl2g_defc= onfig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl_defcon= fig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q2g_defco= nfig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q_defconf= ig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s1g_defco= nfig (100%) > >>>>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s_defconf= ig (100%) > >>>>> rename {include/configs =3D> board/boundary/nitrogen6x}/nitrogen6x= =2Eh (98%) I'm not about the goal. > >>>> > >>>> Can you please add a few notes about the motivation for this change? > >>> > >>> Sorry for the delayed reply here. I'm also not entirely sure this is= a > >>> good idea. Moving the defconfig files? Maybe. It does make checking > >>> all configs a bit more tricky, but indeed the configs directory is > >>> unwieldy. Moving the dts files? Those should be a direct cp from the > >>> kernel, so that makes things less clear to me. Especially since it w= ill > >>> need other common files that will still be elsewhere. > >>> > >> > >> They will still be a direct copy. Notice the 100% rename. Common files= still living in the dts > >> directory is less clear. I can try to address the "piecemeal building = of .dts files" if this > >> still has a chance of being accepted. > >=20 > > So, here's my worry. Today, in an ideal world that we're not yet at, I > > could do: > > 1. cd ~/src/linux; git checkout v5.16 > > 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ > > [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done > >=20 >=20 > Still, a script could easily check that a dts file exists before overwrit= ing it > and find the correct directory to put it in. A little more complicated, b= ut not a lot. >=20 >=20 > > And now we're resynced with v5.16. That gets a lot more complex with > > board/*/*/*.dts* too. And since those files should be direct imports > > I'm not sure how them residing in board/ helps. >=20 > One thing that maybe be worth remembering, at one time, Linus was suggest= ing that dtb's would NOT be > a permanent part of Linux. That has probably changed, but maybe eventuall= y, that master repo will be > vendor specific. >=20 >=20 > >=20 > > But! I can see how having board-u-boot.dtsi exist under board/ might > > help. Or at least, having those files reside somewhere that's NOT where > > the unmodified imported dts files also live. Long term I think we need > > to move towards making it easier to import the dts files, and clearer > > that they should be "read only" other than when being resynced, than it > > is today. > >=20 >=20 > If you guys are OK with any of the patches, let me know, and I'll submit = a restricted series. Again, sorry for the delay. I just don't think right now these file moves are the right path forward. Maybe at some point further down the road perhaps, once other cleanups are done and having defconfig/u-boot.dtsi/etc in the board directory will be easier to maintain long term. --=20 Tom --AWp5UnKkrrfm+LWP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmICfngACgkQFHw5/5Y0 tyzJzwv+P9xeHxa7J7gjwHxNGYFa4LBeavgARtNbcyo9T4AWEKT55kmFe0cp4VkY dm0dDPu3169XgLLPA6Uc2JhkeuCZsIbU55j+xkYe6WKbFkJkD+J1Y8NcmSeqFoKk VWZga78yEnwaePkvGq+62MnZn6+dLD7WwR4Iy2eay6NwAb4kZ3vFKzAxBy37ZQ8U sIDbRt0tu5cOmMQiC8CC0hNWIYtlBJgbzgry5x/i9W2zQ3ba4/0LPHiUkYE7P2DH kKxUF3PeosYrZQs98Po37dk/uYOPwwT7gSjYxZMPCVyKq6ixjJfKilf2z3nze/XF fPjx38UgYgcCBkK6zSa1EigUz7mOaDaRDf8y0KyreY9EmBQbjlo0gAuj+6yLmk+h XZYyM6T1nuvVAz5zjKO0ehPkQvssuNlzWsbMQqMy7e9dBpie/aeVb6ltgRUXiKLu 1bWRX2suK5TpEBrYyc/UKNfSaWo5SVe3ySQMR46AsMIVDWb4cRtR+U1sc8beo+ph w/5HPj9a =KZLJ -----END PGP SIGNATURE----- --AWp5UnKkrrfm+LWP--