All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] mtd: spi-nor: fix minmax.cocci warnings
Date: Wed, 09 Feb 2022 05:06:43 +0800	[thread overview]
Message-ID: <20220208210642.GA6894@02cc4c783c5e> (raw)
In-Reply-To: <202202090528.gbvHGW2s-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Tudor Ambarus <tudor.ambarus@microchip.com>
CC: Michael Walle <michael@walle.cc>
CC: Pratyush Yadav <p.yadav@ti.com>
CC: Miquel Raynal <miquel.raynal@bootlin.com>
CC: Richard Weinberger <richard@nod.at>
CC: Vignesh Raghavendra <vigneshr@ti.com>
CC: linux-mtd(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/mtd/spi-nor/core.c:2037:10-11: WARNING opportunity for min()


 Check for opencoded min(), max() implementations.
 Generated patches sometimes require adding a cast to fix compile warning.
 Warnings/patches scope intentionally limited to a function body.

Generated by: scripts/coccinelle/misc/minmax.cocci

Fixes: 2747bc2106aa ("mtd: spi-nor: Add dual parallel and stacked mode support")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 2747bc2106aa429773d9a932c799aa6229595148 [840/872] mtd: spi-nor: Add dual parallel and stacked mode support
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago

Please take the patch only if it's a positive warning. Thanks!

 core.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2034,10 +2034,7 @@ static int spi_nor_read(struct mtd_info
 						(offset << nor->shift);
 			}
 		}
-		if (len < rem_bank_len)
-			read_len = len;
-		else
-			read_len = rem_bank_len;
+		read_len = min(len, rem_bank_len);
 
 		/* Wait till previous write/erase is done. */
 		ret = spi_nor_wait_till_ready(nor);

  reply	other threads:[~2022-02-08 21:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 21:07 [xilinx-xlnx:xlnx_rebase_v5.15 840/872] drivers/mtd/spi-nor/core.c:2037:10-11: WARNING opportunity for min() kernel test robot
2022-02-08 21:06 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-09 11:35 [PATCH] mtd: spi-nor: fix minmax.cocci warnings Julia Lawall
2022-02-09 11:35 ` Julia Lawall
2022-02-09 11:35 ` Julia Lawall
2022-02-09 11:35 ` Julia Lawall
2022-03-26  0:27 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 840/1029] drivers/mtd/spi-nor/core.c:2037:10-11: WARNING opportunity for min() kernel test robot
2022-03-26  0:18 ` [PATCH] mtd: spi-nor: fix minmax.cocci warnings kernel test robot
2022-03-26  8:30 Julia Lawall
2022-03-26  8:30 ` Julia Lawall
2022-03-26  8:30 ` Julia Lawall
2022-03-26  8:30 ` Julia Lawall
2022-03-28  5:58 ` Vignesh Raghavendra
2022-03-28  5:58   ` Vignesh Raghavendra
2022-03-28  5:58   ` Vignesh Raghavendra
2022-03-28  5:58   ` Vignesh Raghavendra
2022-03-29 11:38   ` Pratyush Yadav
2022-03-29 11:38     ` Pratyush Yadav
2022-03-29 11:38     ` Pratyush Yadav
2022-03-29 11:38     ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208210642.GA6894@02cc4c783c5e \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.