From: Anna Schumaker <anna@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 2/4] generic/531: Move test from 'quick' group to 'stress'
Date: Tue, 8 Feb 2022 16:52:30 -0500 [thread overview]
Message-ID: <20220208215232.491780-3-anna@kernel.org> (raw)
In-Reply-To: <20220208215232.491780-1-anna@kernel.org>
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
The comment up top says this is a stress test, so at the very least it
should be added to this group. As for removing it from the quick group,
making this test variable on the number of CPUs means this test could
take a very long time to finish (I'm unsure exactly how long on NFS v4.1
because I usually kill it after a half hour or so)
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
I have thought of two alternatives to this patch that would work for me:
1) Could we add an _unsupported_fs function which is the opposite of
_supported_fs to prevent tests from running on specific filesystems?
2) Would it be okay to check if $FSTYP == "nfs" when setting nr_cpus,
and set it to 1 instead? Perhaps through a function in common/rc
that other tests can use if they scale work based on cpu-count?
---
tests/generic/531 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/531 b/tests/generic/531
index 5e84ca977b44..62e3cac92423 100755
--- a/tests/generic/531
+++ b/tests/generic/531
@@ -12,7 +12,7 @@
# Use every CPU possible to stress the filesystem.
#
. ./common/preamble
-_begin_fstest auto quick unlink
+_begin_fstest auto stress unlink
testfile=$TEST_DIR/$seq.txt
# Import common functions.
--
2.35.1
next prev parent reply other threads:[~2022-02-08 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 21:52 [PATCH 0/4] Improvements for NFS Anna Schumaker
2022-02-08 21:52 ` [PATCH 1/4] check: Export CHECK_OPTIONS and PLATFORM for Xunit Reporting Anna Schumaker
2022-02-08 21:52 ` Anna Schumaker [this message]
2022-02-23 16:54 ` [PATCH 2/4] generic/531: Move test from 'quick' group to 'stress' Darrick J. Wong
2022-02-23 19:38 ` Anna Schumaker
2022-02-24 4:14 ` Darrick J. Wong
2022-02-08 21:52 ` [PATCH 3/4] generic/578: Test that filefrag is supported before running Anna Schumaker
2022-02-23 16:57 ` Darrick J. Wong
2022-02-23 18:24 ` Anna Schumaker
2022-02-24 4:15 ` Darrick J. Wong
2022-02-08 21:52 ` [PATCH 4/4] generic/633: Check if idmapped mounts are " Anna Schumaker
2022-02-19 8:40 ` Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208215232.491780-3-anna@kernel.org \
--to=anna@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.