From: Stephen Hemminger <stephen@networkplumber.org>
To: Weiguo Li <liwg06@foxmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 00/16] add define guards to avoid multi-inclusion
Date: Tue, 8 Feb 2022 22:29:50 -0800 [thread overview]
Message-ID: <20220208222950.5cb35bfb@hermes.local> (raw)
In-Reply-To: <tencent_5C4748441862F4790A4EF1224A75ECBFF909@qq.com>
On Wed, 9 Feb 2022 11:02:08 +0800
Weiguo Li <liwg06@foxmail.com> wrote:
> Supplement define guards to prevent multiple inclusion.
>
> Notice that there are couples of guard styles used in this project,
> like "XX_H", "XX_H_" or "XXX_H__".
> Adhere to Thomas's advice, this patch set use the first style to
> make it simple.
>
> Weiguo Li (16):
> bus/dpaa: add define guards to avoid multi-inclusion
> event/octeontx: add define guards to avoid multi-inclusion
> net/cxgbe: add define guards to avoid multi-inclusion
> net/enetfec: add define guards to avoid multi-inclusion
> net/i40e: add define guards to avoid multi-inclusion
> net/netvsc: add define guards to avoid multi-inclusion
> net/qede: add define guards to avoid multi-inclusion
> net/tap: add define guards to avoid multi-inclusion
> net/virtio: add define guards to avoid multi-inclusion
> raw/ifpga/base: add define guards to avoid multi-inclusion
> kni: add define guards to avoid multi-inclusion
> acl: add define guards to avoid multi-inclusion
> eal: add define guards to avoid multi-inclusion
> efd: add define guards to avoid multi-inclusion
> hash: add define guards to avoid multi-inclusion
> pcapng: add define guards to avoid multi-inclusion
>
> drivers/bus/dpaa/base/qbman/qman.h | 5 +++++
> drivers/event/octeontx/timvf_worker.h | 5 +++++
> drivers/net/cxgbe/base/t4_regs.h | 5 +++++
> drivers/net/enetfec/enet_uio.h | 5 +++++
> drivers/net/i40e/i40e_regs.h | 5 +++++
> drivers/net/netvsc/hn_nvs.h | 5 +++++
> drivers/net/netvsc/hn_rndis.h | 5 +++++
> drivers/net/netvsc/hn_var.h | 5 +++++
> drivers/net/qede/base/reg_addr.h | 5 +++++
> drivers/net/qede/qede_sriov.h | 5 +++++
> drivers/net/tap/tap_bpf_insns.h | 5 +++++
> drivers/net/tap/tap_log.h | 5 +++++
> drivers/net/virtio/virtio_rxtx_packed_avx.h | 5 +++++
> drivers/net/virtio/virtio_rxtx_packed_neon.h | 5 +++++
> drivers/raw/ifpga/base/opae_at24_eeprom.h | 5 +++++
> kernel/linux/kni/compat.h | 5 +++++
> lib/acl/acl_run_altivec.h | 5 +++++
> lib/acl/acl_run_avx2.h | 5 +++++
> lib/acl/acl_run_avx512x16.h | 5 +++++
> lib/acl/acl_run_avx512x8.h | 5 +++++
> lib/acl/acl_run_neon.h | 5 +++++
> lib/acl/acl_run_sse.h | 5 +++++
> lib/eal/include/rte_eal_paging.h | 5 +++++
> lib/eal/windows/include/rte_virt2phys.h | 5 +++++
> lib/efd/rte_efd_x86.h | 5 +++++
> lib/hash/rte_cmp_arm64.h | 5 +++++
> lib/hash/rte_cmp_x86.h | 5 +++++
> lib/kni/rte_kni_fifo.h | 5 ++++-
> lib/pcapng/pcapng_proto.h | 5 +++++
> 29 files changed, 144 insertions(+), 1 deletion(-)
>
Some are good, but all the drivers and internal headers this change
is unnecessary. Please limit changes to where it matters.
next prev parent reply other threads:[~2022-02-09 6:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220206035846.2840462-1-liwg06@foxmail.com>
2022-02-06 3:58 ` [PATCH 02/16] event/octeontx: add define guards to avoid multi-inclusion Weiguo Li
2022-02-08 16:27 ` Thomas Monjalon
2022-02-09 3:02 ` [PATCH v2 00/16] " Weiguo Li
2022-02-09 6:29 ` Stephen Hemminger [this message]
2022-02-09 7:24 ` [PATCH v3 0/4] " Weiguo Li
2022-02-06 3:58 ` [PATCH 03/16] net/cxgbe: add define guards to avoid multiple inclusion Weiguo Li
2022-02-06 3:58 ` [PATCH 04/16] net/enetfec: " Weiguo Li
2022-02-06 3:58 ` [PATCH 05/16] net/i40e: " Weiguo Li
2022-02-06 3:58 ` [PATCH 06/16] net/netvsc: add define guards to avoid multi-inclusion Weiguo Li
2022-02-06 3:58 ` [PATCH 07/16] net/qede: " Weiguo Li
2022-02-06 3:58 ` [PATCH 08/16] net/tap: " Weiguo Li
2022-02-06 3:58 ` [PATCH 09/16] net/virtio: " Weiguo Li
2022-02-06 3:58 ` [PATCH 10/16] raw/ifpga/base: " Weiguo Li
2022-02-06 3:58 ` [PATCH 11/16] kni: " Weiguo Li
2022-02-06 3:58 ` [PATCH 12/16] acl: " Weiguo Li
2022-02-06 3:58 ` [PATCH 13/16] eal: " Weiguo Li
2022-02-06 16:24 ` Dmitry Kozlyuk
2022-02-06 3:58 ` [PATCH 14/16] efd: " Weiguo Li
2022-02-06 3:58 ` [PATCH 15/16] hash: " Weiguo Li
2022-02-06 3:58 ` [PATCH 16/16] pcapng: " Weiguo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208222950.5cb35bfb@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwg06@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.