From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2854282680464500568==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] iio: adc: fix for_each_child.cocci warnings Date: Wed, 09 Feb 2022 21:13:10 +0800 Message-ID: <20220209131310.GA64935@d9df6f5d589d> In-Reply-To: <202202092111.JiywQULH-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============2854282680464500568== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-arm-kernel(a)lists.infradead.org TO: Rajnikant Bhojani CC: Michal Simek CC: Hyun Kwon CC: Shubhrajyoti Datta CC: "Jean-Francois Dagenais" CC: Olivier Dugas CC: Manish Narani CC: Jonathan Cameron CC: "Lars-Peter Clausen" CC: linux-iio(a)vger.kernel.org CC: linux-arm-kernel(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of= _node" should have of_node_put() before return around line 923. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Rajnikant Bhojani Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15 head: 423a108a01e05e84b59a4c4885c16bf3cd8c90c7 commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/907] iio: adc: Add Xi= linx AMS driver :::::: branch date: 3 hours ago :::::: commit date: 8 days ago Please take the patch only if it's a positive warning. Thanks! xilinx-ams.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev * ams_channels + num_channels); if (ret < 0) { kfree(ams_channels); + of_node_put(child_node); return ret; } =20 --===============2854282680464500568==--