Re: [Buildroot] [PATCH v5] package/libcamera-apps: new package

[Peter Seiderer <ps.report@gmx.net>]

Hello Arnout,

On Tue, 8 Feb 2022 22:09:44 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:

> On 02/05/2021 11:59, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
>   (Finally) applied to master, thanks. However...
>
> [snip]
> > diff --git a/package/libcamera-apps/0001-cmake-remove-Wfatal-errors-compiler-command-line-opt.patch b/package/libcamera-apps/0001-cmake-remove-Wfatal-errors-compiler-command-line-opt.patch
> > new file mode 100644
> > index 0000000000..11d19fa526
> > --- /dev/null
> > +++ b/package/libcamera-apps/0001-cmake-remove-Wfatal-errors-compiler-command-line-opt.patch
> > @@ -0,0 +1,25 @@
> > +From 22096ef8cfb18563c1955145db24742081910e10 Mon Sep 17 00:00:00 2001
> > +From: Peter Seiderer <ps.report@gmx.net>
> > +Date: Fri, 5 Feb 2021 18:24:08 +0100
> > +Subject: [PATCH] cmake: remove -Wfatal-errors compiler command line option
> > +
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > +---
> > + CMakeLists.txt | 1 -
> > + 1 file changed, 1 deletion(-)
> > +
> > +diff --git a/CMakeLists.txt b/CMakeLists.txt
> > +index 4191245..199a0f6 100644
> > +--- a/CMakeLists.txt
> > ++++ b/CMakeLists.txt
> > +@@ -10,7 +10,6 @@ endif()
> > + set (CMAKE_EXPORT_COMPILE_COMMANDS ON)
> > + set (CMAKE_CXX_STANDARD 17)
> > + set (CMAKE CXX_FLAGS "-Wall -Wextra -pedantic -Wno-unused-parameter -faligned-new")
> > +-add_definitions(-Wfatal-errors)
>
>   Why is this patch needed? The only thing that -Wfatal-errors does is to stop
> compilation when there is an error, instead of trying to continue and find more
> errors in the rest of the file. It's not -Werror.

Do not remember the exact failure....

>
>   I kept the patch anyway because I didn't test without it.

Ups, patch needs some update anyway, fails with current libcamera package/version:

	-- Checking for module 'camera'
	--   Package 'camera', required by 'virtual:world', not found
	CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:603 (message):
	  A required package was not found
	Call Stack (most recent call first):
	  /usr/share/cmake/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal)
	  CMakeLists.txt:36 (pkg_check_modules)

Fixed upstream by [1]...

Regards,
Peter

[1] https://github.com/raspberrypi/libcamera-apps/commit/729df015fb37ab25abd73c4832f9e7fa5d1cb8de

>
>
>   Regards,
>   Arnout
>
>
> > + add_definitions(-Wno-psabi)
> > + add_definitions(-DBOOST_LOG_DYN_LINK)
> > +
> > +--
> > +2.30.0
> > +
> > diff --git a/package/libcamera-apps/Config.in b/package/libcamera-apps/Config.in
> > new file mode 100644
> > index 0000000000..08667eb830
> > --- /dev/null
> > +++ b/package/libcamera-apps/Config.in
> > @@ -0,0 +1,31 @@
> > +config BR2_PACKAGE_LIBCAMERA_APPS
> > +	bool "libcamera-apps"
> > +	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS # libcamera
> > +	depends on BR2_INSTALL_LIBSTDCPP # libcamera/boost
> > +	depends on BR2_TOOLCHAIN_HAS_THREADS # libcamera/boost/libdrm
> > +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17/libcamera
> > +	depends on !BR2_STATIC_LIBS # gnutls/libcamera
> > +	depends on BR2_USE_WCHAR # gnutls/libcamera/boost
> > +	depends on BR2_PACKAGE_XORG7
> > +	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL # libepoxy
> > +	select BR2_PACKAGE_BOOST
> > +	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
> > +	select BR2_PACKAGE_JPEG
> > +	select BR2_PACKAGE_LIBCAMERA
> > +	select BR2_PACKAGE_LIBDRM
> > +	select BR2_PACKAGE_LIBEPOXY
> > +	select BR2_PACKAGE_LIBEXIF
> > +	select BR2_PACKAGE_LIBPNG
> > +	select BR2_PACKAGE_TIFF
> > +	select BR2_PACKAGE_XLIB_LIBX11
> > +	help
> > +	  This is a small suite of libcamera-based apps that aim to copy
> > +	  the functionality of the existing "raspicam" apps.
> > +
> > +	  https://github.com/raspberrypi/libcamera-apps
> > +
> > +comment "libcamera-apps needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7 and needs an OpenGL and/or OpenGL EGL backend"
> > +	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
> > +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> > +		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
> > +	depends on !BR2_PACKAGE_HAS_LIBEGL && !BR2_PACKAGE_HAS_LIBGL
> > diff --git a/package/libcamera-apps/libcamera-apps.hash b/package/libcamera-apps/libcamera-apps.hash
> > new file mode 100644
> > index 0000000000..da426434c1
> > --- /dev/null
> > +++ b/package/libcamera-apps/libcamera-apps.hash
> > @@ -0,0 +1,3 @@
> > +# Locally computed
> > +sha256  9b3475e1c817cbcf942c4be0dac3d1f6bf2ee192b0ca5edb95c85c06c5a12b4f  libcamera-apps-326fdfd120a0f62b7e76f4ee8aa0c82c2bf008e6.tar.gz
> > +sha256  36dfed86bdef661a0a14ec1a1cc84c771d5a06b6f9b92e9ebb610ba711bd528a  license.txt
> > diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk
> > new file mode 100644
> > index 0000000000..5edcefefad
> > --- /dev/null
> > +++ b/package/libcamera-apps/libcamera-apps.mk
> > @@ -0,0 +1,25 @@
> > +################################################################################
> > +#
> > +# libcamera-apps
> > +#
> > +################################################################################
> > +
> > +LIBCAMERA_APPS_VERSION = 326fdfd120a0f62b7e76f4ee8aa0c82c2bf008e6
> > +LIBCAMERA_APPS_SITE = $(call github,raspberrypi,libcamera-apps,$(LIBCAMERA_APPS_VERSION))
> > +LIBCAMERA_APPS_LICENSE = BSD-2-Clause
> > +LIBCAMERA_APPS_LICENSE_FILES = license.txt
> > +LIBCAMERA_APPS_DEPENDENCIES = \
> > +	host-pkgconf \
> > +	boost \
> > +	jpeg \
> > +	libcamera \
> > +	libdrm \
> > +	libexif \
> > +	libepoxy \
> > +	libpng \
> > +	tiff \
> > +	xlib_libX11
> > +
> > +LIBCAMERA_APPS_CONF_OPTS = -DENABLE_COMPILE_FLAGS_FOR_TARGET=disabled
> > +
> > +$(eval $(cmake-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot