From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC3BC433FE for ; Wed, 9 Feb 2022 18:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fy6VyU9oDP8M9mTGFQIw8xev7YuUaYnbmCViS8DSJlY=; b=WO36Uhw9zhXdyr NnUTqNEkqFbgS9fPpDQ2VYagxNj4gEAilhSStnnRijw6mw3xo/UYeHFLgecQHLGzYsErVxS1YnZkP a0ZIbFYpS1IZEvUWp6VDdle4r2jjeDPLTA1D5n9eO2dxhIY0Gla8h6G72iKymAIAJuSBNWm15cOjP 5li+WvO0XvdGNF4uCzTyfNm1fVaTA379PFWeTgMfoHJQqyoscbhz1BrOjRv8qZf9qgwKFcotNNaxC dIXtAN8islyxe3wQayUsnScOdlp8aVssZzu+iOGCFXb2I5kIw+CJX+i13IjJrDtO+saHxoRKxrE1H z55Jl/sd3xQTrjXuFLHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHrqI-0018Qg-0o; Wed, 09 Feb 2022 18:37:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHrq3-0018J4-NC for linux-arm-kernel@lists.infradead.org; Wed, 09 Feb 2022 18:37:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46F0361CB2; Wed, 9 Feb 2022 18:37:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61415C340E7; Wed, 9 Feb 2022 18:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644431830; bh=06AEE+dTILRtwDY8oQbRofaIwu30iB9WUEgyuAH6rvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJLdHtCKCdfG4J9yy3VphtyUaZslzGK+1G6hP2P288TGsFtY3nTJJlAaAk9RsgKXM bdWumdDfkDEFKUm+Va4rmlEZxt2TUVniJF/mt0xgn0iN4VPjIwieBOX50CrK8o2Ft4 ZD/m/MfhXr0xzbory/wl8e1RyUqy71suGD3BeRAkCQCL4ixYZ08UjspZDKw8VkiHIG iX+yFjzEIEJOIkKih4W9ikp/SjumtvNtGV7tyFMvHPY116j+S+zEQ9+/IeXut8HUjN GsDTNLvvE096O+XzXjqDYWtpa7gXjt51s64op6p+m8e7NGYk/vSJXmd5+WMKDi52A3 71Bf3kmE24Emg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steen Hegelund , kernel test robot , Dan Carpenter , Jakub Kicinski , Sasha Levin , davem@davemloft.net, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, bjarni.jonasson@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.16 35/42] net: sparx5: do not refer to skb after passing it on Date: Wed, 9 Feb 2022 13:33:07 -0500 Message-Id: <20220209183335.46545-35-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220209183335.46545-1-sashal@kernel.org> References: <20220209183335.46545-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_103711_827012_672662BA X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Steen Hegelund [ Upstream commit 81eb8b0b18789e647e65579303529fd52d861cc2 ] Do not try to use any SKB fields after the packet has been passed up in the receive stack. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Steen Hegelund Link: https://lore.kernel.org/r/20220202083039.3774851-1-steen.hegelund@microchip.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c index dc7e5ea6ec158..148d431fcde42 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c @@ -145,9 +145,9 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap) skb_put(skb, byte_cnt - ETH_FCS_LEN); eth_skb_pad(skb); skb->protocol = eth_type_trans(skb, netdev); - netif_rx(skb); netdev->stats.rx_bytes += skb->len; netdev->stats.rx_packets++; + netif_rx(skb); } static int sparx5_inject(struct sparx5 *sparx5, -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0B3C433F5 for ; Wed, 9 Feb 2022 18:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239873AbiBIShs (ORCPT ); Wed, 9 Feb 2022 13:37:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239786AbiBIShP (ORCPT ); Wed, 9 Feb 2022 13:37:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC2FC05CBB5; Wed, 9 Feb 2022 10:37:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3AA9D61BAA; Wed, 9 Feb 2022 18:37:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61415C340E7; Wed, 9 Feb 2022 18:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644431830; bh=06AEE+dTILRtwDY8oQbRofaIwu30iB9WUEgyuAH6rvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJLdHtCKCdfG4J9yy3VphtyUaZslzGK+1G6hP2P288TGsFtY3nTJJlAaAk9RsgKXM bdWumdDfkDEFKUm+Va4rmlEZxt2TUVniJF/mt0xgn0iN4VPjIwieBOX50CrK8o2Ft4 ZD/m/MfhXr0xzbory/wl8e1RyUqy71suGD3BeRAkCQCL4ixYZ08UjspZDKw8VkiHIG iX+yFjzEIEJOIkKih4W9ikp/SjumtvNtGV7tyFMvHPY116j+S+zEQ9+/IeXut8HUjN GsDTNLvvE096O+XzXjqDYWtpa7gXjt51s64op6p+m8e7NGYk/vSJXmd5+WMKDi52A3 71Bf3kmE24Emg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steen Hegelund , kernel test robot , Dan Carpenter , Jakub Kicinski , Sasha Levin , davem@davemloft.net, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, bjarni.jonasson@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.16 35/42] net: sparx5: do not refer to skb after passing it on Date: Wed, 9 Feb 2022 13:33:07 -0500 Message-Id: <20220209183335.46545-35-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220209183335.46545-1-sashal@kernel.org> References: <20220209183335.46545-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steen Hegelund [ Upstream commit 81eb8b0b18789e647e65579303529fd52d861cc2 ] Do not try to use any SKB fields after the packet has been passed up in the receive stack. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Steen Hegelund Link: https://lore.kernel.org/r/20220202083039.3774851-1-steen.hegelund@microchip.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c index dc7e5ea6ec158..148d431fcde42 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c @@ -145,9 +145,9 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap) skb_put(skb, byte_cnt - ETH_FCS_LEN); eth_skb_pad(skb); skb->protocol = eth_type_trans(skb, netdev); - netif_rx(skb); netdev->stats.rx_bytes += skb->len; netdev->stats.rx_packets++; + netif_rx(skb); } static int sparx5_inject(struct sparx5 *sparx5, -- 2.34.1