From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D65F7C433EF for ; Thu, 10 Feb 2022 05:54:31 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31-SZ5eY8VlOsOxogdwEphEbA-1; Thu, 10 Feb 2022 00:54:27 -0500 X-MC-Unique: SZ5eY8VlOsOxogdwEphEbA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82AFD100C660; Thu, 10 Feb 2022 05:54:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AC0D5E27A; Thu, 10 Feb 2022 05:54:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 203BC1809CB8; Thu, 10 Feb 2022 05:54:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21A5pv49021751 for ; Thu, 10 Feb 2022 00:51:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4EDE3401DBE; Thu, 10 Feb 2022 05:51:57 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B404401470 for ; Thu, 10 Feb 2022 05:51:57 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 363BF1066681 for ; Thu, 10 Feb 2022 05:51:57 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-Qm1mPZxdMCG-Lk9QVo_gSg-1; Thu, 10 Feb 2022 00:51:55 -0500 X-MC-Unique: Qm1mPZxdMCG-Lk9QVo_gSg-1 Received: by verein.lst.de (Postfix, from userid 2407) id 6A40F68B05; Thu, 10 Feb 2022 06:51:51 +0100 (CET) Date: Thu, 10 Feb 2022 06:51:51 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Message-ID: <20220210055151.GA3491@lst.de> References: <20220209082828.2629273-1-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-loop: dm-devel@redhat.com Cc: axboe@kernel.dk, manoj@linux.ibm.com, linux-scsi@vger.kernel.org, philipp.reisner@linbit.com, linux-block@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, ukrishn@linux.ibm.com, lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com, jinpu.wang@ionos.com, Christoph Hellwig , mrochs@linux.ibm.com Subject: Re: [dm-devel] remove REQ_OP_WRITE_SAME v2 X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: > > Christoph, > > > Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the > > kernel there is very little use left for REQ_OP_WRITE_SAME. We only > > have two callers left, and both just export optional protocol features > > to remote systems: DRBD and the target code. > > No particular objections from me. I had a half-baked series to do the > same thing. > > One thing I would like is to either pull this series through SCSI or do > the block pieces in a post merge branch because I'm about to post my > discard/zeroing rework and that's going to clash with your changes. I'd be fine with taking this through the SCSI tree. Or we can wait another merge window to make your life easier. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68B8C4332F for ; Thu, 10 Feb 2022 05:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234883AbiBJFwN (ORCPT ); Thu, 10 Feb 2022 00:52:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235083AbiBJFv5 (ORCPT ); Thu, 10 Feb 2022 00:51:57 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D23810ED; Wed, 9 Feb 2022 21:51:55 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 6A40F68B05; Thu, 10 Feb 2022 06:51:51 +0100 (CET) Date: Thu, 10 Feb 2022 06:51:51 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Cc: Christoph Hellwig , axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, jinpu.wang@ionos.com, manoj@linux.ibm.com, mrochs@linux.ibm.com, ukrishn@linux.ibm.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com, dm-devel@redhat.com Subject: Re: remove REQ_OP_WRITE_SAME v2 Message-ID: <20220210055151.GA3491@lst.de> References: <20220209082828.2629273-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: > > Christoph, > > > Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the > > kernel there is very little use left for REQ_OP_WRITE_SAME. We only > > have two callers left, and both just export optional protocol features > > to remote systems: DRBD and the target code. > > No particular objections from me. I had a half-baked series to do the > same thing. > > One thing I would like is to either pull this series through SCSI or do > the block pieces in a post merge branch because I'm about to post my > discard/zeroing rework and that's going to clash with your changes. I'd be fine with taking this through the SCSI tree. Or we can wait another merge window to make your life easier. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 45CB7420BB1 for ; Thu, 10 Feb 2022 06:51:53 +0100 (CET) Date: Thu, 10 Feb 2022 06:51:51 +0100 From: Christoph Hellwig To: "Martin K. Petersen" Message-ID: <20220210055151.GA3491@lst.de> References: <20220209082828.2629273-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: axboe@kernel.dk, manoj@linux.ibm.com, linux-scsi@vger.kernel.org, philipp.reisner@linbit.com, linux-block@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, ukrishn@linux.ibm.com, lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com, jinpu.wang@ionos.com, Christoph Hellwig , mrochs@linux.ibm.com Subject: Re: [Drbd-dev] remove REQ_OP_WRITE_SAME v2 List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: > > Christoph, > > > Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the > > kernel there is very little use left for REQ_OP_WRITE_SAME. We only > > have two callers left, and both just export optional protocol features > > to remote systems: DRBD and the target code. > > No particular objections from me. I had a half-baked series to do the > same thing. > > One thing I would like is to either pull this series through SCSI or do > the block pieces in a post merge branch because I'm about to post my > discard/zeroing rework and that's going to clash with your changes. I'd be fine with taking this through the SCSI tree. Or we can wait another merge window to make your life easier.