From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FF9C433FE for ; Thu, 10 Feb 2022 08:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237627AbiBJInq (ORCPT ); Thu, 10 Feb 2022 03:43:46 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237761AbiBJInp (ORCPT ); Thu, 10 Feb 2022 03:43:45 -0500 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A9C197 for ; Thu, 10 Feb 2022 00:43:47 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id B254B2B000C7; Thu, 10 Feb 2022 03:43:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Feb 2022 03:43:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=CElJlaUmn4kDx8P/hMZmLBQKvsN0etoJK6/v6V 2jv4U=; b=D7oVB+GlFiv+3Sd2ajlPF1H8CKaY8ICLjFdPyIEg1b3Vp29swBs/io 2TIuSwjMFQ2470Ursxavl4HouynhJwc6ojAqne6V39ef4eyyPOeA7zDK9pte8LRX bI46xJP1/VUQiAEw6v1BG2A3BZapT4TrDzA+jHZRb/XwoJw+pctDJYnWyPmKzU2H nBPFdDe3ytSCsIaI7e514jvD1H1co4GgI0AHX9FM4JL3nRHnwJWTX1Z55AeZHEtK eftkpZNv5VM517UdHjbpd9Nk25+zutwsTf+36m4XM85OKHpTqrSYpSBEICs/mieu hNFXsvKJ2hT+/1HTBRLvqCy3+EQl57GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CElJlaUmn4kDx8P/h MZmLBQKvsN0etoJK6/v6V2jv4U=; b=ScInbgWHocqSmLVIxdgXmwZa54ICx9CUn FWVEgDmDCai/tlvVtVQtC9+zrdGH8BE7peybgwG4D+6IYhuU8B1VKmwtH3vy7eZp yoSrqp8QzjliM0S3NlcEAtJux9POyt0QQ6vs465HcanyNn9gvrn2XrocEWK6Rwsb HQ7AgrvK97Rf/NHu4/5bKrCA/LHwQZt5ZdRTqXNGO46tAiz9J37mImTAjFeP8gDv Z1N5k7NUpbPkz4FQLkKHXE93z0zZL4GnFupqH9jCExJ1XHit1cwX/PvYuwARBhYa dhwk0pIENIAz3NPEeIe2thud2o9kFjECGVIDi/lvEQKkg/S7WQDxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddriedtgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Feb 2022 03:43:44 -0500 (EST) Date: Thu, 10 Feb 2022 09:43:42 +0100 From: Maxime Ripard To: Dmitry Baryshkov Cc: Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Rob Clark , Sean Paul Subject: Re: [PATCH 04/23] drm/msm/mdp5: Fix zpos initial value mismatch Message-ID: <20220210084342.73n5wqlxsujfvqxt@houat> References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-5-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kogjopekdqrw73cf" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --kogjopekdqrw73cf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Feb 07, 2022 at 10:27:24PM +0300, Dmitry Baryshkov wrote: > On Mon, 7 Feb 2022 at 19:56, Maxime Ripard wrote: > > > > While the mdp5_plane_install_properties() function calls > > drm_plane_create_zpos_property() with an initial value of 1, > > mdp5_plane_reset() will force it to another value depending on the plane > > type. > > > > Fix the discrepancy by setting the initial zpos value to the same value > > in the drm_plane_create_zpos_property() call. >=20 > Could you please squash two msm/mdp5 patches into a single patch, > making it clear that the code is moved. >=20 > Also please add: > Fixes: 7d36db0be3b9 ("drm/msm/mdp5: switch to standard zpos property") If we are to merge both patches, we can't have a fixes tag, since it relies on the other framework patches that won't get backported. Maxime --kogjopekdqrw73cf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYgTQPgAKCRDj7w1vZxhR xeY6APkBnuF983kLttuIYG6T0lANfZCiQtji+Fht5kfy41O0pgEAy8ld1LnDQKqW qkrSTB+KLWOS9/f3fUatpCxB38gJxAg= =bSaB -----END PGP SIGNATURE----- --kogjopekdqrw73cf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9825FC433F5 for ; Thu, 10 Feb 2022 08:43:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEB2C10E79F; Thu, 10 Feb 2022 08:43:48 +0000 (UTC) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CE5810E799; Thu, 10 Feb 2022 08:43:47 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id B254B2B000C7; Thu, 10 Feb 2022 03:43:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Feb 2022 03:43:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=CElJlaUmn4kDx8P/hMZmLBQKvsN0etoJK6/v6V 2jv4U=; b=D7oVB+GlFiv+3Sd2ajlPF1H8CKaY8ICLjFdPyIEg1b3Vp29swBs/io 2TIuSwjMFQ2470Ursxavl4HouynhJwc6ojAqne6V39ef4eyyPOeA7zDK9pte8LRX bI46xJP1/VUQiAEw6v1BG2A3BZapT4TrDzA+jHZRb/XwoJw+pctDJYnWyPmKzU2H nBPFdDe3ytSCsIaI7e514jvD1H1co4GgI0AHX9FM4JL3nRHnwJWTX1Z55AeZHEtK eftkpZNv5VM517UdHjbpd9Nk25+zutwsTf+36m4XM85OKHpTqrSYpSBEICs/mieu hNFXsvKJ2hT+/1HTBRLvqCy3+EQl57GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CElJlaUmn4kDx8P/h MZmLBQKvsN0etoJK6/v6V2jv4U=; b=ScInbgWHocqSmLVIxdgXmwZa54ICx9CUn FWVEgDmDCai/tlvVtVQtC9+zrdGH8BE7peybgwG4D+6IYhuU8B1VKmwtH3vy7eZp yoSrqp8QzjliM0S3NlcEAtJux9POyt0QQ6vs465HcanyNn9gvrn2XrocEWK6Rwsb HQ7AgrvK97Rf/NHu4/5bKrCA/LHwQZt5ZdRTqXNGO46tAiz9J37mImTAjFeP8gDv Z1N5k7NUpbPkz4FQLkKHXE93z0zZL4GnFupqH9jCExJ1XHit1cwX/PvYuwARBhYa dhwk0pIENIAz3NPEeIe2thud2o9kFjECGVIDi/lvEQKkg/S7WQDxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddriedtgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Feb 2022 03:43:44 -0500 (EST) Date: Thu, 10 Feb 2022 09:43:42 +0100 From: Maxime Ripard To: Dmitry Baryshkov Subject: Re: [PATCH 04/23] drm/msm/mdp5: Fix zpos initial value mismatch Message-ID: <20220210084342.73n5wqlxsujfvqxt@houat> References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-5-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kogjopekdqrw73cf" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Dom Cobley , Tim Gover , Dave Stevenson , David Airlie , linux-arm-msm@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Daniel Vetter , freedreno@lists.freedesktop.org, Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --kogjopekdqrw73cf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Feb 07, 2022 at 10:27:24PM +0300, Dmitry Baryshkov wrote: > On Mon, 7 Feb 2022 at 19:56, Maxime Ripard wrote: > > > > While the mdp5_plane_install_properties() function calls > > drm_plane_create_zpos_property() with an initial value of 1, > > mdp5_plane_reset() will force it to another value depending on the plane > > type. > > > > Fix the discrepancy by setting the initial zpos value to the same value > > in the drm_plane_create_zpos_property() call. >=20 > Could you please squash two msm/mdp5 patches into a single patch, > making it clear that the code is moved. >=20 > Also please add: > Fixes: 7d36db0be3b9 ("drm/msm/mdp5: switch to standard zpos property") If we are to merge both patches, we can't have a fixes tag, since it relies on the other framework patches that won't get backported. Maxime --kogjopekdqrw73cf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYgTQPgAKCRDj7w1vZxhR xeY6APkBnuF983kLttuIYG6T0lANfZCiQtji+Fht5kfy41O0pgEAy8ld1LnDQKqW qkrSTB+KLWOS9/f3fUatpCxB38gJxAg= =bSaB -----END PGP SIGNATURE----- --kogjopekdqrw73cf--