From: Andre Przywara <andre.przywara@arm.com>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: Siarhei Siamashka <siarhei.siamashka@gmail.com>,
u-boot@lists.denx.de, jagan@amarulasolutions.com,
hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io,
marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com,
tharvey@gateworks.com, christianshewitt@gmail.com,
pbrobinson@gmail.com, jernej.skrabec@gmail.com, hs@denx.de,
samuel@sholland.org, arnaud.ferraris@gmail.com,
giulio.benetti@benettiengineering.com,
thirtythreeforty@gmail.com
Subject: Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV
Date: Thu, 10 Feb 2022 21:19:57 +0000 [thread overview]
Message-ID: <20220210211957.78392ad5@slackpad.lan> (raw)
In-Reply-To: <67bd2cd2-d531-9413-9974-dbfd67a149d6@gmail.com>
On Thu, 10 Feb 2022 14:51:11 -0500
Jesse Taube <mr.bossman075@gmail.com> wrote:
> On 2/10/22 14:38, Siarhei Siamashka wrote:
> > On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube <mr.bossman075@gmail.com> wrote:
> > [...]
> >> + case SUNIV_BOOTED_FROM_NAND:
> >> + case SUNIV_BOOTED_FROM_SPI:
> >> + return BOOT_DEVICE_SPI;
> >
> > Is it really okay to lump SPI and NAND together and return
> > BOOT_DEVICE_SPI for both?
> Booting from SPI NAND.
> I can change it to BOOT_DEVICE_NAND.
Ah, sorry, I missed that. So SPI NAND is different from both SPI NOR and
parallel NAND, and we just don't support it (yet).
So just bail out in this case, ideally with a message.
Cheers,
Andre
> > What's the NAND support story on this device?
> I thought BOOT_DEVICE_NAND was for parallel NAND but I may be wrong
> could come one clarify please?
>
> Thanks,
> Jesse Taube
next prev parent reply other threads:[~2022-02-10 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 4:34 [PATCH v1 0/3] Add spi boot to SPL on SUNIV Jesse Taube
2022-02-10 4:34 ` [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV Jesse Taube
2022-02-10 10:57 ` Andre Przywara
2022-02-10 19:11 ` Jesse Taube
2022-02-10 19:20 ` Jesse Taube
2022-02-10 21:15 ` Andre Przywara
[not found] ` <CACY+gR2NuuRn3qn+htsa15+cVLbE1KYsy7sUpnC5ATpRDW5V_w@mail.gmail.com>
2022-02-10 19:51 ` Jesse Taube
2022-02-10 21:19 ` Andre Przywara [this message]
2022-02-10 4:34 ` [PATCH v1 2/3] mach-sunxi: Add spi boot " Jesse Taube
2022-02-10 10:52 ` Andre Przywara
2022-02-10 4:34 ` [PATCH v1 3/3] mach-sunxi: Enable " Jesse Taube
2022-02-10 10:59 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210211957.78392ad5@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=arnaud.ferraris@gmail.com \
--cc=christianshewitt@gmail.com \
--cc=festevam@denx.de \
--cc=giulio.benetti@benettiengineering.com \
--cc=hdegoede@redhat.com \
--cc=hs@denx.de \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=marek.behun@nic.cz \
--cc=mr.bossman075@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=pbrobinson@gmail.com \
--cc=samuel@sholland.org \
--cc=siarhei.siamashka@gmail.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=thirtythreeforty@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.