From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C139AC433F5 for ; Thu, 10 Feb 2022 21:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344638AbiBJVhh (ORCPT ); Thu, 10 Feb 2022 16:37:37 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240037AbiBJVhh (ORCPT ); Thu, 10 Feb 2022 16:37:37 -0500 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [IPv6:2a01:4f8:150:2161:1:b009:f23e:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 927F726DA for ; Thu, 10 Feb 2022 13:37:36 -0800 (PST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 1471910075775; Thu, 10 Feb 2022 22:37:33 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id E6AE44A84F; Thu, 10 Feb 2022 22:37:32 +0100 (CET) Date: Thu, 10 Feb 2022 22:37:32 +0100 From: Lukas Wunner To: Andrey Grodzovsky Cc: "linux-pci@vger.kernel.org" , "helgaas@kernel.org" , "anatoli.antonovitch@amd.com" , "Kumar1, Rahul" , "Alexander.Deucher@amd.com" Subject: Re: Question about deadlock between AER and pceihp interrupts during resume from S3 with unplugged device Message-ID: <20220210213732.GA25592@wunner.de> References: <0fc31d9a-f414-a412-3765-5519cbb9b7ff@amd.com> <20220210062308.GB929@wunner.de> <6da46e96-8d71-3159-d4e1-0c744fb357ba@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6da46e96-8d71-3159-d4e1-0c744fb357ba@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Feb 10, 2022 at 03:47:10PM -0500, Andrey Grodzovsky wrote: > So the patches indeed helped resolving the deadlock but when we try > again to hotplug back there is a link status failure > > pcieport 0000:00:01.1: pciehp: Slot(0): Card present > pcieport 0000:00:01.1: Data Link Layer Link Active not set in 1000 msec > pcieport 0000:00:01.1: pciehp: Failed to check link status > > and more detailed bellow, > we are trying to debug but again, you might have a quick insight Well, the link doesn't come up. Is the Link Disable bit in the Link Control Register set for some reason? Perhaps some ACPI method fiddled with it? Compare the output of lspci -vv before and after the system sleep transition, do you see anything suspicious? If you reset the slot via sysfs, does the link come back up? You may want to open a bug over at bugzilla.kernel.org and attach the full dmesg output which didn't reach the list, as well as lspci output. Did you apply only my deadlock fix or also Kai-Heng Feng's AER disablement patch? Thanks, Lukas