From: Jason Gunthorpe <jgg@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Josef Johansson <josef@oderland.se>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask
Date: Thu, 10 Feb 2022 20:41:47 -0400 [thread overview]
Message-ID: <20220211004147.GK4160@nvidia.com> (raw)
In-Reply-To: <20220210235532.GA663996@bhelgaas>
On Thu, Feb 10, 2022 at 05:55:32PM -0600, Bjorn Helgaas wrote:
> > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
> > the logic of checking msi_attrib.can_mask, without any reason.
> >
> > This commits restores that logic.
>
> I agree, this looks like a typo in 71020a3c0dff4, but I might be
> missing something, so Thomas should take a look, and I added Jason
> since he reviewed it.
I concur
Jason
next prev parent reply other threads:[~2022-02-11 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 1:10 [PATCH] PCI/MSI: msix_setup_msi_descs: Restore logic for msi_attrib.can_mask Josef Johansson
2022-02-10 23:55 ` Bjorn Helgaas
2022-02-11 0:10 ` Josef Johansson
2022-02-11 16:14 ` Bjorn Helgaas
2022-02-11 0:41 ` Jason Gunthorpe [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-22 0:39 Josef Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211004147.GK4160@nvidia.com \
--to=jgg@nvidia.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=josef@oderland.se \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.