From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A38C8C433EF for ; Fri, 11 Feb 2022 17:07:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 649D683B8F; Fri, 11 Feb 2022 18:06:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GelIapBg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8CE6E83B65; Fri, 11 Feb 2022 18:06:44 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A56F783B99 for ; Fri, 11 Feb 2022 18:06:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id r14so9589789qtt.5 for ; Fri, 11 Feb 2022 09:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b7YaD5U+05CaV0979y3wAgSbAvuDo1sn0WI7Ya13xLc=; b=GelIapBg/ON5Z4aHoiwFGtTnq74uQNt06E8ohn1Wx0yEnrq4eVUWYOq8VOhUx13XGz 8ukRcAYoYwjmCb6xHjeirznmjWxhG+2zqQTBu5Eg/H+QoiJmNI6grVknYjoBpQjKbYIX j9rwZzPZ63zdODhf+Myo+AifpuRlGrnP5/kgM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b7YaD5U+05CaV0979y3wAgSbAvuDo1sn0WI7Ya13xLc=; b=7UNaLlXBGEckFW0s4aF/FZhNHN5yU5Gp+dBmuX8UF6q/B2M0QqnJ6vvHM1HLabCn0S PDon1wAbQwNQ03uG8uOCbMJapeF0gcemh+L5qUq5NHWhKJC6CfbN3IByJ7vXzhciXAhK gkwFluB4URb5jBNK8hYX+/dvo7a6EelOo9lMZUI2ZsVdKIp8fmz+m+0RED7+a825NnQs MocVB5xh+ERzRK1N5CwQ39ssO38vpkFzvSOsdnt698puEMKm/YNE3D5cJ5yrrHhzLaI1 Gnrqzk9nSNpnNGaVV+8En+NNEKtwa5AbxKjEspr4nAVylxu2tZKo5XfO/+9R7qq8NysD tuzg== X-Gm-Message-State: AOAM530yg/Ry6eMWBOVsEPaQ70YXY7Qka3Ukdfzu/Y/QcXh8L/AkA57+ MiXdkwcANCeRZE1NnrfqlmlJ8Q== X-Google-Smtp-Source: ABdhPJyIH9Jj3GVzHD8wtZNFWCXJkIm+VUO3Hj8I739BQn0Ye1B9YhE9ahlduNDRIsiZFxvzLt2qxg== X-Received: by 2002:ac8:5d90:: with SMTP id d16mr1795380qtx.142.1644599199513; Fri, 11 Feb 2022 09:06:39 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id de43sm11182980qkb.4.2022.02.11.09.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 09:06:38 -0800 (PST) Date: Fri, 11 Feb 2022 12:06:37 -0500 From: Tom Rini To: Masami Hiramatsu Cc: Lukasz Majewski , u-boot@lists.denx.de, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, jaswinder.singh@linaro.org Subject: Re: [PATCH v2 2/5] DFU: Accept redundant spaces and tabs in dfu_alt_info Message-ID: <20220211170637.GP2697206@bill-the-cat> References: <164359753172.280839.8310577813724924540.stgit@localhost> <164359754906.280839.1412862787511934825.stgit@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dngyMJhgXGAL5Gb8" Content-Disposition: inline In-Reply-To: <164359754906.280839.1412862787511934825.stgit@localhost> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --dngyMJhgXGAL5Gb8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 11:52:29AM +0900, Masami Hiramatsu wrote: > If dfu_alt_info has repeated spaces or tab (for indentation or > readability), the dfu fails to parse it. For example, if > dfu_alt_info=3D"mtd nor1=3Dimage raw 100000 200000" (double spaces > after "raw"), the image entity start address is '0' and the size > '0x100000'. This is because the repeated space is not skipped. >=20 > Use space and tab as a separater and apply skip_spaces() to > skip redundant spaces and tabs. >=20 > Signed-off-by: Masami Hiramatsu Applied to u-boot/master, thanks! --=20 Tom --dngyMJhgXGAL5Gb8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIGl5wACgkQFHw5/5Y0 tyy/Nwv/cffRrSZ5G1cf03WA7iBWguEUvTHSVhNRL2vMGGpDeIKxnx+MEirtOXRQ ky+lCh/sJ+GGkLrrttZeGvQFJ4jnFZJGZBx76q8ghCFdyG59KXzCc9OFsq3oVzmA SKs6z92N52TIY+qTpSlkqxl79V3xm4EfFo0Wp+eUkjIK1oyry1oQq2ZZRUOEeeHQ lq7A90GCPsn9tlwLSnLlcrG5RCACwyR3JQBABpw6mQyX+82G1HYJr4bZYbcJgabW LtGZY/Al9dn2wJJKFkBicSA0z+bzhBmXICjW6DAUgN8jpGgkZvs5X0rGU8274pwE kLIxtSnhkCiMeVOvs3I8pT+X2f0TvY8EVKTa/qtiEu1GZRm+8YNoVDO1vNboFCWe gC/piTePjx2uKDzSAoOKEVRVm0xNS2LnQ42o7B6q2Vh2Aw45zVQIr4kglRHHu90F zFDNdEjzVCXE7aTsNrkYKpAwegXiNaJ33mSCf6/LmEvtEOphZYbbNK/J04qOoPav jF3kagS8 =K0Ae -----END PGP SIGNATURE----- --dngyMJhgXGAL5Gb8--