From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2F77C433F5 for ; Fri, 11 Feb 2022 17:07:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C671383B65; Fri, 11 Feb 2022 18:06:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WdvZXPdK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B03583B65; Fri, 11 Feb 2022 18:06:54 +0100 (CET) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 17B9483B98 for ; Fri, 11 Feb 2022 18:06:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id g145so8826539qke.3 for ; Fri, 11 Feb 2022 09:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bgwda318OYaPrHnaOAK6Bk+Tk0GpaybGSWe3G9hqJAM=; b=WdvZXPdKvcHMhe0M2r55Ka9RPjVG1/lhvUfTdaEqM3jgaMkUFeHQLMV5exyk8Z5od2 ya3u9mCQjWGMZeERjDzvAlD4levgAKTCsb3HwnkkeMllR3u9R0MUzMPl69/IwA6r5AWI JMBC3wQJHPuKofFKce0vf0booXfOXb/IRS+Mw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bgwda318OYaPrHnaOAK6Bk+Tk0GpaybGSWe3G9hqJAM=; b=jZT66wodYykPUftS/03ZeL8gSH3jdRh8jd8SAhx+hb/4wKBTbiyTLjekDbq5wjQoJq pSecrqA1J+JsuQeKgAaLtv5hIK2Sl6PYrCSj1rI/YZYiQebRav3A17yJxgFk6rXFqNmt qE0ctSGUH8ZGJPloS+K1gYzX5GmGIJHcMRsUp1u4fSFGZZVzjgqVGUjjTTOfLfqw41hN zRtuYjQ2ylzYLESxElbRPc3bQDoTgwB+n1LUTElMSyIc0Ydw3tA+7rR+iBnrlMHTSg8E PAE+N5L5NQ4x92jhPkHdk+t/GM6EyX95kYhz4cKKeMlGWVmIDNze3tot2oWMvq083rNl Ve8g== X-Gm-Message-State: AOAM531re0dC1nMThiJrAEkXBEF63xrDCIlDLPIb5s75UM0gVTXe9d0W wx2rBT+M9l5gED5Na3043/7cx/caVY/Sgdls X-Google-Smtp-Source: ABdhPJyVJfpxA/PIljltg26QUCeh0YpoyzWvzKGXbh8d0ZHFi8ARJZndAPcp+X+2NMqoQC9uRbmwBA== X-Received: by 2002:a05:620a:2452:: with SMTP id h18mr1250911qkn.597.1644599207940; Fri, 11 Feb 2022 09:06:47 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id x13sm12234569qko.114.2022.02.11.09.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 09:06:47 -0800 (PST) Date: Fri, 11 Feb 2022 12:06:45 -0500 From: Tom Rini To: Masami Hiramatsu Cc: Lukasz Majewski , u-boot@lists.denx.de, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, jaswinder.singh@linaro.org Subject: Re: [PATCH v2 3/5] DFU: Check the number of arguments and argument string strictly Message-ID: <20220211170645.GQ2697206@bill-the-cat> References: <164359753172.280839.8310577813724924540.stgit@localhost> <164359755758.280839.2217137492784656400.stgit@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pndui+VhQ7yNUqd0" Content-Disposition: inline In-Reply-To: <164359755758.280839.2217137492784656400.stgit@localhost> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --pndui+VhQ7yNUqd0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 11:52:37AM +0900, Masami Hiramatsu wrote: > When parsing the dfu_alt_info, check the number of arguments > and argument string strictly. If there is any garbage data > (which is not able to be parsed correctly) in dfu_alt_info, > that means something wrong and user may make a typo or mis- > understanding about the syntax. Since the dfu_alt_info is > used for updating the firmware, this mistake may lead to > brick the hardware. > Thus it should be checked strictly for making sure there > is no mistake. >=20 > Signed-off-by: Masami Hiramatsu Applied to u-boot/master, thanks! --=20 Tom --pndui+VhQ7yNUqd0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIGl6UACgkQFHw5/5Y0 tywKWwv/SdcrcAAq9B9RHOiXkY0q1b//LzhGWisEqKKRIu5BKCX11tjfo9G4DX/D xu5kVTELlNQEsFTEnJhb8bQEYgmhrbgiyUv67vPVsB5++tuiDAfDyhOlUcxc//I4 8T6GqGNzTlsG3xPO10oDFSHkycI610rio9AKHMlrl2vBHXNZRBD/xmnWu+BVkWWU cepl3pmqC9p4AX5JRbSxNdOfFCEECqQ+obtqGBlZ9MjudrfD1/Z1fqhAO5n+zAeh 0dOapBBTaAtBcF1qGJQtyKWpza7r2coE+EZWkn3qQ3RU1zp++3c/OM/5V8666Awy CuaLFLdx3B9epz/Dg3xhfWL7JcQG4DOt/BAzpzozu7MbCeVTLnBQ/VMAt0Wj3X63 s54JZTxYOwBlnGSsouwpMScsjpkw4quXMmJErk8OnPbP3MpsIOQJeQswaDnm42f7 bhD9vLLW/PLEGbbw+k29SBHuv4Hyaj+59ZUL6ZWWib7Wh0jjhNZmKTnLPV4jachq DRCTQLDn =17TT -----END PGP SIGNATURE----- --pndui+VhQ7yNUqd0--